From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059DECD484F for ; Wed, 4 Sep 2024 14:52:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B1F76B04D9; Wed, 4 Sep 2024 10:52:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 862756B04DA; Wed, 4 Sep 2024 10:52:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5246B04DB; Wed, 4 Sep 2024 10:52:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B3546B04D9 for ; Wed, 4 Sep 2024 10:52:46 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 07C5941611 for ; Wed, 4 Sep 2024 14:52:46 +0000 (UTC) X-FDA: 82527347532.25.CF1F450 Received: from fhigh1-smtp.messagingengine.com (fhigh1-smtp.messagingengine.com [103.168.172.152]) by imf18.hostedemail.com (Postfix) with ESMTP id E0A9B1C0024 for ; Wed, 4 Sep 2024 14:52:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b="OW/LO7mC"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="P RzaQM5"; spf=pass (imf18.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.152 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725461436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GMX/FHb1NQd5lg5/NpfA0ULYpIijReg7t7hsHu+fouM=; b=ZNvY3Sccwsm2xfx2f7lQ/W/AKRAJl5sA19elOVlUvOrEPt+PIstLQqAA2fB//Q7uUaAMfV P6Ul9gvbQnfuM+G7HbFvOQJOic4jEbyIkv55wF7dfYVzUQ6X/YVoo79c1YQNCzSjUoLdkt jhJFbQvVhIWLIvt/3lNTz0yyilTbwCo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b="OW/LO7mC"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="P RzaQM5"; spf=pass (imf18.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.152 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725461436; a=rsa-sha256; cv=none; b=zKP8kOgYU1lINMbytFoxZY47abiUBZuValaxLPmoz8lDoUb6p7h7cAGjTz/K5LG92I+UQi GAvWuU69oOShk3QVQWNV9FYGYnr94wRXUavG0F1ZuSoHPk8kYbtlQEkr9QlSzhi6sCghrh Hu+0zsoLxCFIdAoNex14/q9xgYIdOig= Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id DBAC3114019A; Wed, 4 Sep 2024 10:52:42 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-04.internal (MEProxy); Wed, 04 Sep 2024 10:52:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725461562; x=1725547962; bh=GMX/FHb1NQd5lg5/NpfA0ULYpIijReg7t7hsHu+fouM=; b= OW/LO7mC2lppB30DwzXZMH6lCAiLIyJWLwTJ8WLyc+YHWV0oTdfNn4lcUoFVo7UY 9pAKcQyXorI/p55OmQQ43MuHV4CPFsIRG89uUXD0Fi320wNBlEKLPWB8SaS3j7Ur OL2WLCu5iDGAwFVAdwLAAzLhn+eFHkbDTRDvoI66AUoLz6kSZPlgrt+apWZMRtOt eZ7Vcdil8475qdV8v1uXKe0S31rfbNaXPSWF+2lBvH8zxX1Sq7j7XqB1X598LD5b Q5HP2jiSjVdvM+5CQg7w/5WHBbAFU9ZMc2b1B7FV+GoQ8KiThnSWxYKGDaEqcdUH qK807tjfVn8jH1VbOaZx7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725461562; x= 1725547962; bh=GMX/FHb1NQd5lg5/NpfA0ULYpIijReg7t7hsHu+fouM=; b=P RzaQM5+yNXaGypCnpneCASFBgjYrzkXmPGYBFr8AaDnbyojCg6tvt18W5dbb4LJY wYTOK6bot/ttO93zl45SBmDQ1k560WZYaKEDMsUktXiaP2G6W2lw8z13PwVXHQGT 0O+zoVyPzaI1bBWGnAOxqcmaBXKF1yKqsiMvipoXXl/nFCh4/Z6KI0FQbuRFD1kH S6o/to8Yzey+Olg6mt28KJ3HqlRKUtjv9U6N94n5Cz5jyX8IMJ4Adb0GHNHqOr43 +CSW8HfbKG/XhK+M9Mqe2ysZlDPHVWwvYohTnBrXRpyVwPRHsGnoNuIqqovx0tt+ K+4hVKBMyh8moJTR9QuPw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehjedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvddt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprh gtphhtthhopehvihhntggvnhiiohdrfhhrrghstghinhhosegrrhhmrdgtohhmpdhrtghp thhtoheptghhrhhishhtohhphhgvrdhlvghrohihsegtshhgrhhouhhprdgvuhdprhgtph htthhopehmrghthhhivghurdguvghsnhhohigvrhhssegvfhhfihgtihhoshdrtghomhdp rhgtphhtthhopehmphgvsegvlhhlvghrmhgrnhdrihgurdgruhdprhgtphhtthhopehnph highhgihhnsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhoshhtvgguthesghhoohgu mhhishdrohhrghdprhgtphhtthhopehluhhtoheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepmhhhihhrrghmrghtsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id CA8302220083; Wed, 4 Sep 2024 10:52:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Wed, 04 Sep 2024 14:52:21 +0000 From: "Arnd Bergmann" To: "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Christophe Leroy" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: In-Reply-To: <20240903151437.1002990-4-vincenzo.frascino@arm.com> References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-4-vincenzo.frascino@arm.com> Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E0A9B1C0024 X-Stat-Signature: ro195y6gwxpittkug3z7p4y5s5ynko7o X-Rspam-User: X-HE-Tag: 1725461563-351160 X-HE-Meta: U2FsdGVkX1/CkacjwIbjE4lVMaASkzv/RHccbXW3dF1YNcTP1ImZ2uZqHL/DTPfNS98z7LpK17NmXnisJAv+LqJ9kbaXL6exf4/tA7BLse476Keh+7F95tbbbqIU5cJWvzJfeCXZWR7I8IZOx+Md4FFS9BY7zqfp+D2uD8P48P+gst9vfjfFVw9Yg+/p5o1XtdiMupfp4NzcGoej727HrL7T/xmLd1BsOi1IkyD+vbaFUg0v2zehxa2VDm2433z1b9NnRw32YZ/ZvxZfKohCUbLhcO2jv4t4fCeOgU9mNod26ypEhmQAtt/nAh2rva9C5iH4XCyd2pJFGqhO4n/fL1IHr/uEZZg5+tpMcBHyKtokHnol/Zpx475MK6J8iU14ncpr0enUbG7Zosi5O1sskcTqaROczvu2+XmvK2jASeaLVdhwIQHbZT80AmOsZnNfvQucbW39IGfi15x50lFFCKJZoKDV7Yph0lXL2Km/sxm8oQa/R976HmDS94Bp7PKPpiaj0ubWbSlV4wTZGIqU3UvWGG89xmBg0NdhpKEjLgQuRhnlSxcHYMI4sbF40sMqyiu//FNUAWfHa7Y7HVYxfkPcg4guDZoxCoMTTF11MQJ0GRqrdSKmP528g+MUTxRgItLh9BlTa48Je2yItkWv/Z2Q1o8Xcdwn/MnEMRnCTo9mPfOLLoUzYnNSj81iBhyBOki/LHH0PXuBMGpPztUjzz9EWNUx65UdrODw0t+RB4jaQaXexekJronQQWTt4br65Af8Kd1Munjb/J7FGaBP70nx85C+tuUgPyd73FvPEN/TwnHEOD7nCAiRHOZhZgK+aivRdTzXwAfl2HbMRwb8oEauu4xyQOgLhpYCLow3RHQ9xz+hH+UUeQEqM02F14bKRODfEp/rJbCSTPK7o6cT3RgU86rbQ3/AkzHmf5OqaliQ+B7vny5ghZM5jmnUnVzhQGd0PJGH3LH8EJYv9A4 Wdyk6Er9 ecOs6XsTasEfs6rChSCK31bDuNa7FcuWEj8wkLd6MY5X9mdXPASJ2qbGKkQAuegn1bMDw+LSd3UpGKE31eXyxpsZ9jP8CRwJ1yA4cch4E5VeoF9cmA00lktgNbhPyw0lhtrLIKfVGecAfx1o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 3, 2024, at 15:14, Vincenzo Frascino wrote: > diff --git a/arch/x86/include/asm/vdso/page.h b/arch/x86/include/asm/vdso/page.h > new file mode 100644 > index 000000000000..b0af8fbef27c > --- /dev/null > +++ b/arch/x86/include/asm/vdso/page.h > @@ -0,0 +1,15 @@ > + > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __ASM_VDSO_PAGE_H > +#define __ASM_VDSO_PAGE_H > + > +#ifndef __ASSEMBLY__ > + > +#include > + > +#define VDSO_PAGE_MASK PAGE_MASK > +#define VDSO_PAGE_SIZE PAGE_SIZE > + > +#endif /* !__ASSEMBLY__ */ > + > +#endif /* __ASM_VDSO_PAGE_H */ I don't get this one: the x86 asm/page_types.h still includes other headers outside of the vdso namespace, but you seem to only need these two definitions that are the same across everything. Why not put PAGE_MASK and PAGE_SIZE into a global vdso/page.h header? I did spend a lot of time a few months ago ensuring that we can have a single definition for all architectures based on CONFIG_PAGE_SHIFT, so all the extra copies should just go away. Arnd