* [PATCH] mm: vmstat: correct the comment above preempt_disable_nested()
@ 2025-11-10 8:44 Qi Zheng
2025-11-10 8:53 ` Vlastimil Babka
2025-11-10 8:56 ` Harry Yoo
0 siblings, 2 replies; 3+ messages in thread
From: Qi Zheng @ 2025-11-10 8:44 UTC (permalink / raw)
To: akpm, david, lorenzo.stoakes, Liam.Howlett, vbabka, rppt, surenb,
mhocko, harry.yoo
Cc: linux-mm, linux-kernel, Qi Zheng
From: Qi Zheng <zhengqi.arch@bytedance.com>
The comment explaining why these parts use preempt_disable_nested() is in
__mod_zone_page_state(), not in __mod_node_page_state(), so we should see
__mod_zone_page_state(). Just correct it.
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
---
mm/vmstat.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index b53b07aa29e81..65de88cdf40e6 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -392,7 +392,7 @@ void __mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
delta >>= PAGE_SHIFT;
}
- /* See __mod_node_page_state */
+ /* See __mod_zone_page_state() */
preempt_disable_nested();
x = delta + __this_cpu_read(*p);
@@ -438,7 +438,7 @@ void __inc_zone_state(struct zone *zone, enum zone_stat_item item)
s8 __percpu *p = pcp->vm_stat_diff + item;
s8 v, t;
- /* See __mod_node_page_state */
+ /* See __mod_zone_page_state() */
preempt_disable_nested();
v = __this_cpu_inc_return(*p);
@@ -461,7 +461,7 @@ void __inc_node_state(struct pglist_data *pgdat, enum node_stat_item item)
VM_WARN_ON_ONCE(vmstat_item_in_bytes(item));
- /* See __mod_node_page_state */
+ /* See __mod_zone_page_state() */
preempt_disable_nested();
v = __this_cpu_inc_return(*p);
@@ -494,7 +494,7 @@ void __dec_zone_state(struct zone *zone, enum zone_stat_item item)
s8 __percpu *p = pcp->vm_stat_diff + item;
s8 v, t;
- /* See __mod_node_page_state */
+ /* See __mod_zone_page_state() */
preempt_disable_nested();
v = __this_cpu_dec_return(*p);
@@ -517,7 +517,7 @@ void __dec_node_state(struct pglist_data *pgdat, enum node_stat_item item)
VM_WARN_ON_ONCE(vmstat_item_in_bytes(item));
- /* See __mod_node_page_state */
+ /* See __mod_zone_page_state() */
preempt_disable_nested();
v = __this_cpu_dec_return(*p);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: vmstat: correct the comment above preempt_disable_nested()
2025-11-10 8:44 [PATCH] mm: vmstat: correct the comment above preempt_disable_nested() Qi Zheng
@ 2025-11-10 8:53 ` Vlastimil Babka
2025-11-10 8:56 ` Harry Yoo
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka @ 2025-11-10 8:53 UTC (permalink / raw)
To: Qi Zheng, akpm, david, lorenzo.stoakes, Liam.Howlett, rppt,
surenb, mhocko, harry.yoo
Cc: linux-mm, linux-kernel, Qi Zheng
On 11/10/25 09:44, Qi Zheng wrote:
> From: Qi Zheng <zhengqi.arch@bytedance.com>
>
> The comment explaining why these parts use preempt_disable_nested() is in
> __mod_zone_page_state(), not in __mod_node_page_state(), so we should see
> __mod_zone_page_state(). Just correct it.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/vmstat.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index b53b07aa29e81..65de88cdf40e6 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -392,7 +392,7 @@ void __mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item,
> delta >>= PAGE_SHIFT;
> }
>
> - /* See __mod_node_page_state */
> + /* See __mod_zone_page_state() */
> preempt_disable_nested();
>
> x = delta + __this_cpu_read(*p);
> @@ -438,7 +438,7 @@ void __inc_zone_state(struct zone *zone, enum zone_stat_item item)
> s8 __percpu *p = pcp->vm_stat_diff + item;
> s8 v, t;
>
> - /* See __mod_node_page_state */
> + /* See __mod_zone_page_state() */
> preempt_disable_nested();
>
> v = __this_cpu_inc_return(*p);
> @@ -461,7 +461,7 @@ void __inc_node_state(struct pglist_data *pgdat, enum node_stat_item item)
>
> VM_WARN_ON_ONCE(vmstat_item_in_bytes(item));
>
> - /* See __mod_node_page_state */
> + /* See __mod_zone_page_state() */
> preempt_disable_nested();
>
> v = __this_cpu_inc_return(*p);
> @@ -494,7 +494,7 @@ void __dec_zone_state(struct zone *zone, enum zone_stat_item item)
> s8 __percpu *p = pcp->vm_stat_diff + item;
> s8 v, t;
>
> - /* See __mod_node_page_state */
> + /* See __mod_zone_page_state() */
> preempt_disable_nested();
>
> v = __this_cpu_dec_return(*p);
> @@ -517,7 +517,7 @@ void __dec_node_state(struct pglist_data *pgdat, enum node_stat_item item)
>
> VM_WARN_ON_ONCE(vmstat_item_in_bytes(item));
>
> - /* See __mod_node_page_state */
> + /* See __mod_zone_page_state() */
> preempt_disable_nested();
>
> v = __this_cpu_dec_return(*p);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: vmstat: correct the comment above preempt_disable_nested()
2025-11-10 8:44 [PATCH] mm: vmstat: correct the comment above preempt_disable_nested() Qi Zheng
2025-11-10 8:53 ` Vlastimil Babka
@ 2025-11-10 8:56 ` Harry Yoo
1 sibling, 0 replies; 3+ messages in thread
From: Harry Yoo @ 2025-11-10 8:56 UTC (permalink / raw)
To: Qi Zheng
Cc: akpm, david, lorenzo.stoakes, Liam.Howlett, vbabka, rppt, surenb,
mhocko, linux-mm, linux-kernel, Qi Zheng
On Mon, Nov 10, 2025 at 04:44:37PM +0800, Qi Zheng wrote:
> From: Qi Zheng <zhengqi.arch@bytedance.com>
>
> The comment explaining why these parts use preempt_disable_nested() is in
> __mod_zone_page_state(), not in __mod_node_page_state(), so we should see
> __mod_zone_page_state(). Just correct it.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> ---
Acked-by: Harry Yoo <harry.yoo@oracle.com>
Yeah I was confused when all these comments says
"See __mod_node_page_state()" But even in the function it says
"See __mod_node_page_state()" :)
Thanks for fixing it!
--
Cheers,
Harry / Hyeonggon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-10 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 8:44 [PATCH] mm: vmstat: correct the comment above preempt_disable_nested() Qi Zheng
2025-11-10 8:53 ` Vlastimil Babka
2025-11-10 8:56 ` Harry Yoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).