From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0551AC6FD1D for ; Thu, 23 Mar 2023 10:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C1566B0072; Thu, 23 Mar 2023 06:15:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 772116B0074; Thu, 23 Mar 2023 06:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639386B0075; Thu, 23 Mar 2023 06:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 544276B0072 for ; Thu, 23 Mar 2023 06:15:26 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1EDA1A0608 for ; Thu, 23 Mar 2023 10:15:26 +0000 (UTC) X-FDA: 80599755852.12.E76656F Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf21.hostedemail.com (Postfix) with ESMTP id 4DDD81C0011 for ; Thu, 23 Mar 2023 10:15:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="LKYKTn/m"; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679566524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=FYs0HNDKIjrbcHM960jzzYGdPLX0yWmJ512l9ylAAsA=; b=c/OWlfs21V5xuJgP4pBfuyKuBAPr13cNsMVaLEa150DyWTmXok2J7ScRmpGYE+Tf/JP3zW KUY7RPMT7mkgUbRhtXABGygWYr1qUM02g/vsotyEK7shUsgjtBwNk7O2oIGieerKaFEgaK cRB9P1DL8E2CmJ2atI0UewZKmCaxHtU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="LKYKTn/m"; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679566524; a=rsa-sha256; cv=none; b=Nl0nHknCdWa1L2qglD2iMEeDy84kB5QImSo5PPKga6Cf2RfA62no+xxVhA3f59aQlGzxKX Qv2/a6oa4o6/IWUhJAjPR2Yw0xjd7z4jaTT6Ey9f8RO0Vf3YQmsaorYDhU79hSSfey27Ev BDyVYJI7KDrVDGMGlWLk7X/ZMjh81Ss= Received: by mail-wm1-f49.google.com with SMTP id r19-20020a05600c459300b003eb3e2a5e7bso735461wmo.0 for ; Thu, 23 Mar 2023 03:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679566522; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FYs0HNDKIjrbcHM960jzzYGdPLX0yWmJ512l9ylAAsA=; b=LKYKTn/mAihd2Bc4LkHcL7PhZ42dOCwu8amQKMAtuqOVRW3CRd/8Z0qV1wzmwhVchw 4r9oaTWN6QA2gdI2/NID/KnImI2llCWGPHflnXNwo8UHDquvblu9Pq+gOOof7x+Thy2f BMAFndZctNaBWfo/pst6Kcl7aoJsRdM10aS6hUCzqdb41tPABOljDMbnj4kh2WYwtHhs VMEkmOGSy5PcykxTMW1tfW6lPFjJcrs6JtZBZRiO+iKfrKBvlE31K14xQp0qLTCnfTMP dfybgCDKTkDlk5oV4k45WWo4YsSYuRgJ0FdLeNDUBuOwl85n2av62ISun5IGNNgnJSmk Sixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679566522; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FYs0HNDKIjrbcHM960jzzYGdPLX0yWmJ512l9ylAAsA=; b=NM/eqAoVnBYaUdik2VED5giemNUxCHCw18US2yOv95OHFysNxHlnobMKTgTWWOpZsG pMnF3fYkjRyT3VWoakIzoNtti/0WT9JdhVBIOBAgSKsEkRnrKzRKqWRetJEkSHMAitx9 +itqkE5vT7CwI7vioxqWNNtnVxr2atP7I9B430BB7rsNSyWGRD5lLifRt2kIuJn2cRBN 4C5x/0gezEyL+wTpH/lb8U1CH9t/Jy2lykteUelzXGGtdgmzHp+Q5te/EkC3aHnALG/L uHs9QQJ+vfOkIHowEKhNJkAmgGpV3hJyRR+A0HnJNqj+yVOEY0fto1KD8Bn0V2Z6AT5z GrCw== X-Gm-Message-State: AO0yUKUxBA4Rr1h4gi38CR0dmw8FN8I/bSMY4S1l637oiIvryJNIR0KU MLOR1GB5yZTMFz7vb2GesWIv0vV0bBc= X-Google-Smtp-Source: AK7set+u3N9pK0uVUfLJoYX7FdNxrz5SxQIAIYF5d0P5xpI2bb78fwkUwtAVU91EarVqyF4a083v+w== X-Received: by 2002:a05:600c:3781:b0:3ee:5d1d:6c2d with SMTP id o1-20020a05600c378100b003ee5d1d6c2dmr1834876wmr.35.1679566522345; Thu, 23 Mar 2023 03:15:22 -0700 (PDT) Received: from lucifer.home (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.googlemail.com with ESMTPSA id f18-20020a05600c155200b003ede2c59a54sm1416952wmg.37.2023.03.23.03.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 03:15:21 -0700 (PDT) From: Lorenzo Stoakes To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton Cc: Baoquan He , Uladzislau Rezki , Matthew Wilcox , David Hildenbrand , Liu Shixin , Jiri Olsa , Jens Axboe , Alexander Viro , Lorenzo Stoakes Subject: [PATCH v8 0/4] convert read_kcore(), vread() to use iterators Date: Thu, 23 Mar 2023 10:15:15 +0000 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4DDD81C0011 X-Stat-Signature: ux4tdigi9byyc3guirwi3ai75o98rgfe X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679566524-95771 X-HE-Meta: U2FsdGVkX19/pLcJKzngMQAnolFqHVqIMUVdadw+OqA91NNO4NQ5G6lDVLHPEhRpe42kgXxvxETT9zzSezmX4qz+96ZI3PkcaaNmZhSdpSDfD8IZGYcDrG/OrxG9gVO2FKAfgyI/I1lKMj92pCKu7FdLeZc2KnREcQCx62gE00QxlNeUupBLrVb1GmaIJwMaYz6HzO3hldHas9MlALZo+ivTGlJ4n6IbfLOk/J7Rrrzk/gJ4Uc+KdghVkGMeEXonGbwQAIpXKp2EQDJ46uqaUuKUZLd6Q27RMdhtMhwq35ySMETKKDDF01hCkazusGbH/AGWgIpznLfb6mC9fDyzgDjiwIg6UUPaUW1/up4radaGhvmI0arQVdTN0O6/6sbw25QrRHLHtg3N/2wzCrfJKGJmjcFBM/lK8YwcV9/YpguNHKyaDCD/Vz7bUU8xoSjYt37xnMXF8uyVNpxkfjnA+IId+7TqNLxD8teIiC1zN523sqzyjWXFtO6H2TvjD2ln3iFRCzRHiWAEmPNRwvaxVkMRSO72dRyx7gLFz6lNFPn8HIVytYpyrVLnRgGAnFlwliOBnIHIFCGtUrT5BTXZONCTCMI9r9jYkS/DJE2oWbA1x1NXssXKbDkVWM/PGvtR3IFWLzDJqgh0MiXlvfuTAdUEq5aHpNo+ITidgc5A66FpdsBFUP0CC/QG4ZKWnwGpTJp2w/kM9af6L/pXKsfitdZexwbY5ti01HD0TqYfCWIl2Er06TwhHxDJDbhbQL6yjLUy9xX75AL6liBTD/Jfaye+59m9tLJKObGNM7Kr1hNQHFxpyBFwOjsGgSKTHmHqP06JRINB1tKLS87cFaJXf+cc4M1FYQMqsu6VXfeTHUdRM/RcVWRk5pKOR2Y8e238HYHRgWsXIvmPO6WK9JgMk84oW/kosi9ob9IptBwDrNb2rhg2Eecrr2ZR7hrcKB7wC3r4eOE+7rjHk5m+vuG KXWfa+iq Oi06igRwi84oy5loH/Uv7YGRjrM25KSuI6sz0BmgHmq1f2E1zq5blo7sSNhv0eyEL9QUrroe07As4DtuOUv/K0lPy7rO7Pl6nUb8V/AUxZVWV17bG3q0aF/SN6GJ30gJPI9ahJQKvUL5ggT9rBXfhXdZao1K44xABdlVrty+VIRo7gwHEMcgbEgLqmCln7euXoNPMjEO71sA7GRYzbK46MaqViZwSsjjKHNAeN9DuGSGTQ799686x7RSbp5I1ZKy6sLtw2Z3f4BtQmg3lgv5XCuZjU/H2F/PAt0UVjLiIphZCKPkEu0Ukso/G1xOdS/Z+Etw1YanQCVAduG7UasyZnYdC9WeBBqi0gNPmwIqpyTXsAS9wwun6dS/c6jGgmap7nKaSJed4Of0Pv42JeOODdmcg3NBtG9G5SG9ByrmKLlhvgI6v++nfqdCLGBT8xgTDkyJS2/9c9F3Sj1hfDpHyF6UIG9J6logD907DoZVMNml2ODwi6OsKCQkdzmByj4MUMy0rO9KlCPza+RFgHi2z2QVNAFafW9iTMyF4mVzwGIpQWEh332Iwf3wkE2PdoiqVDZyHPRnzxhS+BxH/V3RzLAVXTQknNmsR9OXs212zJ2l/SVY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: While reviewing Baoquan's recent changes to permit vread() access to vm_map_ram regions of vmalloc allocations, Willy pointed out [1] that it would be nice to refactor vread() as a whole, since its only user is read_kcore() and the existing form of vread() necessitates the use of a bounce buffer. This patch series does exactly that, as well as adjusting how we read the kernel text section to avoid the use of a bounce buffer in this case as well. This has been tested against the test case which motivated Baoquan's changes in the first place [2] which continues to function correctly, as do the vmalloc self tests. [1] https://lore.kernel.org/all/Y8WfDSRkc%2FOHP3oD@casper.infradead.org/ [2] https://lore.kernel.org/all/87ilk6gos2.fsf@oracle.com/T/#u v8: - Make zero_iter() static. v7: - Keep trying to fault in memory until the vmalloc read operation completes. https://lore.kernel.org/all/cover.1679511146.git.lstoakes@gmail.com/ v6: - Correct copy_page_to_iter_nofault() to handle -EFAULT case correctly. https://lore.kernel.org/all/cover.1679496827.git.lstoakes@gmail.com/ v5: - Do not rename fpos to ppos in read_kcore_iter() to avoid churn. - Fix incorrect commit messages after prior revisions altered the approach. - Replace copy_page_to_iter_atomic() with copy_page_to_iter_nofault() and adjust it to be able to handle compound pages. This uses copy_to_user_nofault() which ensures page faults are disabled during copy which kmap_local_page() was not doing. - Only try to fault in pages if we are unable to copy in the first place and try only once to avoid any risk of spinning. - Do not zero memory in aligned_vread_iter() if we couldn't copy it. - Fix mistake in zeroing missing or unpopulated blocks in vmap_ram_vread_iter(). https://lore.kernel.org/linux-mm/cover.1679494218.git.lstoakes@gmail.com/ v4: - Fixup mistake in email client which orphaned patch emails from the cover letter. https://lore.kernel.org/all/cover.1679431886.git.lstoakes@gmail.com v3: - Revert introduction of mutex/rwsem in vmalloc - Introduce copy_page_to_iter_atomic() iovec function - Update vread_iter() and descendent functions to use only this - Fault in user pages before calling vread_iter() - Use const char* in vread_iter() and descendent functions - Updated commit messages based on feedback - Extend vread functions to always check how many bytes we could copy. If at any stage we are unable to copy/zero, abort and return the number of bytes we did copy. https://lore.kernel.org/all/cover.1679354384.git.lstoakes@gmail.com/ v2: - Fix ordering of vread_iter() parameters - Fix nommu vread() -> vread_iter() https://lore.kernel.org/all/cover.1679209395.git.lstoakes@gmail.com/ v1: https://lore.kernel.org/all/cover.1679183626.git.lstoakes@gmail.com/ Lorenzo Stoakes (4): fs/proc/kcore: avoid bounce buffer for ktext data fs/proc/kcore: convert read_kcore() to read_kcore_iter() iov_iter: add copy_page_to_iter_nofault() mm: vmalloc: convert vread() to vread_iter() fs/proc/kcore.c | 85 +++++++-------- include/linux/uio.h | 2 + include/linux/vmalloc.h | 3 +- lib/iov_iter.c | 48 +++++++++ mm/nommu.c | 10 +- mm/vmalloc.c | 234 +++++++++++++++++++++++++--------------- 6 files changed, 243 insertions(+), 139 deletions(-) -- 2.39.2