From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: [RFC PATCH 0/2] mm: update mips to use do_mmap(), make mmap_region() internal
Date: Thu, 12 Dec 2024 15:36:45 +0000 [thread overview]
Message-ID: <cover.1734017293.git.lorenzo.stoakes@oracle.com> (raw)
Currently the only user of mmap_region() outside of the memory management
code is the MIPS VDSO implementation.
This uses mmap_region() to map a 'delay slot emulation page' at the top of
the stack which is read-only and executable.
This mapping requires that an already-acquired mmap write lock is utilised
and that uffd and populate logic is ignored. This rules out vm_mmap(),
however do_mmap() fits the bill.
Adapt this code to use do_mmap() and then once done, make mmap_region()
internal and userland testable, and avoid any other uses of mmap_region(),
which is absolutely and strictly an internal mm function which bypasses a
great number of checks and logic.
REVIEWERS NOTES:
Thomas - I lack the hardware or set up to test this beyond a simple
cross-compilation test, so I need some input from you MIPS guys as to
whether this is workable.
I've therefore sent this as an RFC so we can be sure this is suitable!
Please could you check to make sure this change is OK and I haven't missed
anything?
Thanks!
Lorenzo Stoakes (2):
mips: vdso: prefer do_mmap() to mmap_region()
mm: make mmap_region() internal
arch/mips/kernel/vdso.c | 10 +++--
include/linux/mm.h | 3 --
mm/mmap.c | 34 -----------------
mm/vma.c | 36 +++++++++++++++++-
mm/vma.h | 6 +--
tools/testing/vma/vma_internal.h | 65 ++++++++++++++++++++++++++++++++
6 files changed, 109 insertions(+), 45 deletions(-)
--
2.47.1
next reply other threads:[~2024-12-12 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 15:36 Lorenzo Stoakes [this message]
2024-12-12 15:36 ` [RFC PATCH 1/2] mips: vdso: prefer do_mmap() to mmap_region() Lorenzo Stoakes
2024-12-12 15:36 ` [RFC PATCH 2/2] mm: make mmap_region() internal Lorenzo Stoakes
2024-12-12 15:45 ` Matthew Wilcox
2024-12-12 16:48 ` Lorenzo Stoakes
2024-12-17 8:23 ` [RFC PATCH 0/2] mm: update mips to use do_mmap(), " Thomas Bogendoerfer
2024-12-17 14:11 ` Liam R. Howlett
2025-01-02 11:46 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1734017293.git.lorenzo.stoakes@oracle.com \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox