From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
kamezawa.hiroyu@jp.fujitsu.com, cesarb@cesarb.net,
emunson@mgebm.net, penberg@kernel.org, namhyung@gmail.com,
lucas.demarchi@profusion.mobi, aarcange@redhat.com,
tj@kernel.org, vapier@gentoo.org, jkosina@suse.cz,
rientjes@google.com
Subject: RE: [PATCH 2/4] frontswap: using vzalloc instead of vmalloc
Date: Thu, 4 Aug 2011 19:45:42 -0700 (PDT) [thread overview]
Message-ID: <d0584e86-34f6-46cc-a78e-c1e31ed7cb9f@default> (raw)
In-Reply-To: <CAA_GA1f8B9uPszGecYd=DiuAOCqo0AXkFca_=5jEGRczGia5ZA@mail.gmail.com>
> > I am fairly sure that the failed allocation is handled gracefully
> > through the remainder of the frontswap code, but will re-audit to
> > confirm. A warning might be nice though.
>
> There is a place i think maybe have problem.
> function __frontswap_flush_area() in file frontswap.c called
> memset(sis->frontswap_map, .., ..);
> But if frontswap_map allocation fail there is a null pointer access ?
Good catch!
I'll fix that when I submit a frontswap update in a few days.
Thanks,
Dan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-05 2:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 3:09 [PATCH 1/4] page cgroup: using vzalloc instead of vmalloc Bob Liu
2011-08-04 3:09 ` [PATCH 2/4] frontswap: " Bob Liu
2011-08-04 3:09 ` [PATCH 3/4] sparse: using kzalloc to clean up code Bob Liu
2011-08-04 3:09 ` [PATCH 4/4] percpu: rename pcpu_mem_alloc to pcpu_mem_zalloc Bob Liu
2011-08-04 6:13 ` Pekka Enberg
2011-08-04 8:09 ` Michal Hocko
2011-08-04 9:04 ` Tejun Heo
2011-08-04 6:10 ` [PATCH 3/4] sparse: using kzalloc to clean up code Pekka Enberg
2011-08-04 6:55 ` Bob Liu
2011-08-04 7:22 ` Johannes Weiner
2011-08-04 7:26 ` Johannes Weiner
2011-08-04 7:37 ` Pekka Enberg
2011-08-04 8:07 ` Michal Hocko
2011-08-04 7:57 ` [PATCH 2/4] frontswap: using vzalloc instead of vmalloc Michal Hocko
2011-08-04 8:14 ` Johannes Weiner
2011-08-04 9:00 ` Michal Hocko
2011-08-04 16:47 ` Dan Magenheimer
2011-08-05 2:36 ` Bob Liu
2011-08-05 2:45 ` Dan Magenheimer [this message]
2011-08-05 2:57 ` Bob Liu
2011-08-05 18:13 ` Dan Magenheimer
2011-08-06 3:59 ` Bob Liu
2011-08-04 6:02 ` [PATCH 1/4] page cgroup: " Pekka Enberg
2011-08-04 7:23 ` Johannes Weiner
2011-08-04 7:53 ` Michal Hocko
2011-08-08 0:56 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0584e86-34f6-46cc-a78e-c1e31ed7cb9f@default \
--to=dan.magenheimer@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cesarb@cesarb.net \
--cc=emunson@mgebm.net \
--cc=hannes@cmpxchg.org \
--cc=jkosina@suse.cz \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
--cc=mhocko@suse.cz \
--cc=namhyung@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).