From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE733C77B60 for ; Wed, 29 Mar 2023 23:34:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 853D36B0075; Wed, 29 Mar 2023 19:34:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 803A76B0078; Wed, 29 Mar 2023 19:34:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67D996B007B; Wed, 29 Mar 2023 19:34:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 56BAD6B0075 for ; Wed, 29 Mar 2023 19:34:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 377F3C0E82 for ; Wed, 29 Mar 2023 23:34:36 +0000 (UTC) X-FDA: 80623542552.09.AD572C4 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf12.hostedemail.com (Postfix) with ESMTP id C4E384000F for ; Wed, 29 Mar 2023 23:34:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=lwdid+Fi; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=fltjWhcT; spf=pass (imf12.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VYikRWiObQ/nCMrSuiZpHFYbFGp2QW9DKg2Cx0mjylw=; b=hhoSBpG0tSmckdoHLbb551IK/qrL6pb4hvjNQkkDMnJVaQxTLf4gGutWIDdGvWMGsdYJW/ TZ4Fp4EtnWUaLV7RLN6bHtEDSmQvpDjbCXTY9oqAPOXNYM/rBxy+ZtEumGr1N0sgoY1hsR dMyB1Nwf5aPhuKHxOmL3hNomrS1HBR4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=lwdid+Fi; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=fltjWhcT; spf=pass (imf12.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132874; a=rsa-sha256; cv=none; b=C1FUvHCiC7qc+Co7tEmypWrkOd3WCP7/0lFBkCxsSvWkjyh0AlcNg4MLkm8P6VLKDrqE6u GKg2D53b7/EV5uyTZhF44a5joOCYiW94rkC3vz0holTtiDG6OTQG9WbkeLk7ZzFostsmjj 2/qMxz72fCbkcVE9NyaIVkf2sTyKhqg= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132873; x=1711668873; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Ma+GEPR39SMifngZ8BJHd5lgwaD86YsRlpp+x2qXieU=; b=lwdid+FiNYyqZTBUUcKMs08bK/2Mk8EyPErScaNSbSjbS++QrrEfotk3 8+j+yfehgqXd18fEw437dxEfrvWOKXrbn5IscTOBIBjyBnFSnLg2DEYeQ 9NZ8ABAscBHInvGCcrFxr6OJivTwC7BkL7rofM4yqr9AvtfI3PwV4m5/H OQvy/KMGz5iRy1uDt3oLqj4PlyALLyRqL8oDGQd4oY6y+GkRy8YlZcOgK eNbBPvWRGPvx5iE9JEH0w7kU3CemNuibXSbtvlgdd5gS26KBZcd5b1qyP omHTK7MAL+6r4FTSiN4HNx2e2yBjScyPJN4Dr+oS6MQVMI+boc9GJIN2J w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226648287" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:34:32 +0800 IronPort-SDR: Fie5UJtSPJq4Mz6Z3t9zKFPCVpkcupm/JO09uICc9n5BrRinyotUS7Hs1rxbhOhdmCwZXie3v4 8Ari61ZWEEdme/uzD5VCeqYuQL0/rifMJzLCogMSkXrRf9q1Vivt5cQEJJmcdnF3RsVYjsZErZ PUvdpMMkqO9HeFS+Md5QZbJDmgsr1Xjhc8O4pPX0VauucTKuasKA+UFaylHFomjph/zmDjxbSX U6tt/hgeNHuyvIYw772a5JY1ziPIIpNIB1yJqbuUYjcQD8+91ixFUQ4NqQ6f7vHK+kqofCGfzC izs= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:45:00 -0700 IronPort-SDR: rICqYEBeaq7Uc7guQgproFmNRbYetSnIGMVMGsWWXDOY1GTzAihJ+pRe4P0QsggsDi/V2f0Iou /cWmigOCAIg/frA4IvL31+FaePBvydc9ojlgbOAPD1EmjiCpXpq5uhLGe4cmn4SJhVPpggr29T d8tUvaUM3TJ9lynMwRdrGFoua6I9tB0TxpgWGMAp9cHXZ6AKgbW9kTP9w0Noe6SBkq/UaQzveX Vya1pT/yeaW9JtASYgAY4U9INVUMAcDfOIAQfmycNt5v45vqY/GKT6ZFZ5QSBvTbwvsw0eYN4s 5f4= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:34:32 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2vW6XcVz1RtW6 for ; Wed, 29 Mar 2023 16:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132870; x=1682724871; bh=Ma+GEPR39SMifngZ8BJHd5lgwaD86YsRlpp +x2qXieU=; b=fltjWhcTro3tBLErFz/FZKkzG2DRnrFpnpGJoq06RhvP/J7AK4O 7Y13aBEddFYPLh9qRwO0kXfog8r+uI+ZEpj3mepNN45RU6pAx2fur9TCfUY6gJI1 6dh+CAboV3J8Z+TMCQcResD4WNAFsgSD75rA+uDcCBgSl2pXfdspEqVu2G3lBX+d yOF3uiVoBgS9RXQiGvI0lrLCKxFf7VBP4RZM/qK3Hpc10swa4bYr8meiIO5g+tR2 jNxUg/dF7XPNmm0sq2Anptg6+bujSCGgAr6I2EsRid+qpoqMwnWUw/TZET6FvW7R EFsv1nA6Q5z1Oldh2VB7ChRoWKk1ezNKX7Q== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Zkj76AOJMcGu for ; Wed, 29 Mar 2023 16:34:30 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2vS0ZGvz1RtVm; Wed, 29 Mar 2023 16:34:27 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:34:27 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 10/19] jfs: logmgr: use __bio_add_page to add single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <902f83de56c67b333959d8b8b4cf37a25414e927.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <902f83de56c67b333959d8b8b4cf37a25414e927.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: of4gbeo7i5j48quu5he1bnmjghushriq X-Rspamd-Queue-Id: C4E384000F X-HE-Tag: 1680132873-28997 X-HE-Meta: U2FsdGVkX183eIPRTDMbv7TGvnZpX5H9r4aAivVq4ZgoZVMGLQXCnR9rA/H+yf42Z249R+xQdCtyp/c0C6hnDGg3mOA5Ex5cJNM2vpj4oo2gZyBD8S0yrWUBeGlj1Qy0+rEVmKGcUqfTvY38G72PDHT9BFdqsUmH3HA1rJeFX7D01vKKXxdTCnVZyln4rvb+OM0l7FPUNeqJ3fJw0hL0Rx/Z16bCtvGRINWWrC5VYk1J8aS5ULZBEBJI2Y56IPrWguvfepP28ZU3SWmX1x+1lg3jpkvgArK4jC8JhMPy5NjPrAPC/ktGzlCzZGrOZF5XlE7hzpv+pu9P48U5DpJzMNCyvji7XLXfJ9ByMb47U8QiebPEYavF2ae7hOgGvUNDd6U//Ome5vr9r0x6w7+VpZDUqPYoT6xMbQxRTtLm43UXDdgCAb+MOogzhKNB3WVbZGzpCIMwVM6iL8CpuEELSXAxLdRtSD+o05QkJCbri8p17l2VmRc7tqPd4FDSQmYFTXejOYI899uvyOLILodwUMKXKYYxfMD7NaX+P+1E3Q7lFPdpvEXNZ7/+ze8+aiU1p+DFZyrs/2g5sth9zeCxduurGXIB+JYCadfJG3LeeSCCFZEfXxB6q0kXKpJvC8dx7JhEs2yXZ/KUTTmkVypJ/8KuQg4LEU012L+11inkjq2WE8fE/FG1sbhV0eIqSmot4BdaLmB5+iLgJL75/8odNkMDX6cAtnm8tAEjALvSNs0ADieWo967Luil9VJGPCkqH1L4Nkq8qt43tLQyslvTxLJJ09uvhAHiD5ldCVmrL2n2v44wjnnxNQ4VJyKTi9073QkFyQQ+bmplCWG3KAlvMZ3T+ec8XGnXVQ2HKeNaf2JiBQ+a9u3xUo2rergxnjMGxX30dC6bcMouswa+rFoFpa4gQ8jE1o4m1bhmB6B4IfzWco5m4UDfs4aLlMJSj23Wqdxzd/X04wNIEH9Olcx FM316MBC Ey7QcKKyqmuRmgdDOihHI/nK1MQPe2uYrnSGReJePcq1rlHbEznOxU7pOE5To6o+udlvnSXhGoOzLNSFwZ0p6rbEEiC4h6WhRUErbH/4Ptq142ovOECLP8p7SIFFv3JWuZMe7jm05XrnxvCb7yGrQPZGKxN63kK5zNmqCiXEnOrIh2EblrK/LY1sIcTlmh2u/BLeK6pXvDHvk+bfk57KQlwfMwdVejtQW77q7AvtUw+oVEpso4i+ZO/GC8RYO3tuodJOveDvOME1btinzS0DqdXulO/tEmdWXhuBpUCTwiC3KEjB1zr6imnpcooIp7nA8ou/2y3Ar1Rra2SwEnJb8GCPq1aeEpmr0tMc9sQRsyEKv1169Qo8R+Xm0UMlBJOODx4VIJVGpeJzkzo6hodGTR8RFN3fU9oFugBuoaGINb+5YN4qc1zy2onmD6A1l1DC5xzkz2gUS2cOapJO4x2JeH51JeutzEBxGPh/dFDYdup6f80UN7uuApJdoi8KhzhuVrZ1jmpP5r/FrzNpd0cfGsuz22XAkPGA3Y4QOdLWkqhESCjpRk4mQydCKC5jtvuxPeGJS9YdSKUE1Wzn00jhdfp34Y9wHpAAPcssQQFwNp8J4BbrnxlVTFRRrG2YAjwkAe3HJBz72KpHUm1WZEPcqHQj+nEkaX0DC64vckyF4/tlw0HYFjNXuqEkwYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The JFS IO code uses bio_add_page() to add a page to a newly created bio. > bio_add_page() can fail, but the return value is never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research