From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8059EC3DA6E for ; Fri, 5 Jan 2024 15:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0D66B02EE; Fri, 5 Jan 2024 10:45:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 849A36B02EF; Fri, 5 Jan 2024 10:45:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64EE08D0019; Fri, 5 Jan 2024 10:45:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4EB166B02EE for ; Fri, 5 Jan 2024 10:45:21 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 26412120525 for ; Fri, 5 Jan 2024 15:45:21 +0000 (UTC) X-FDA: 81645681642.23.B067748 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id BA608160012 for ; Fri, 5 Jan 2024 15:45:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YnEAgl1X; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704469518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3w/rFZuEOTHz+qbpgqXvHJOQrhcOEmLTb0+OLq3f2pw=; b=lZXRqCwqYQeDzxbmtEPnHf6YqhIScyznW7ZGmIfvAN7wLsQW2bTaZcIvpDDXZtxMRCfqqt snCb34hypfTJkvmyMfz+sdePKBqrkxg1acEmVQs85uTrH9WF9ylDFyWH9OgWvaSnX+OpZ4 CMEI8IYDJduk4tznQwS9qBCbApXb1Kc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YnEAgl1X; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704469518; a=rsa-sha256; cv=none; b=6mayVxvI6nHZTPvCQkA0/JGB+LEpOtAz3dtQjpV/lLi4uyB5h7zmMnF8w+gHXCwiX6kVN6 amgjXjt6LMtH007FjPiwXJU702OZPOel5PLl6g3dOXKnPW2oltZQVBpKPZbJvdJaXAXJCW Cg+oN+m+sE5ymMrzGY0cBUJfEsRfZ6c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704469518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3w/rFZuEOTHz+qbpgqXvHJOQrhcOEmLTb0+OLq3f2pw=; b=YnEAgl1XdP3hI9komMRorkhsmfBHfG6q4ct/pEJjYXqFpIdcUTVVBj146nnB+p3Z15NuVc CR2XhVMEDYkCdU1l7SowVAPcOIgkKzEzQoeBuWwaQ/ycqhBEzTfUp2FEr7MHL+2MGrb5QF UbjlPB6UdG1MzSCc7zhMvfibiTnpbaY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-XYQnJFYfNMGtr_XRBUpioQ-1; Fri, 05 Jan 2024 10:45:16 -0500 X-MC-Unique: XYQnJFYfNMGtr_XRBUpioQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-336a56ff1e5so342706f8f.1 for ; Fri, 05 Jan 2024 07:45:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704469515; x=1705074315; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3w/rFZuEOTHz+qbpgqXvHJOQrhcOEmLTb0+OLq3f2pw=; b=RuwJQi8EMMqwDeIMeJB1fbEHRzAmo5e9yDnslhXG8ToHQGjDJnzUQNtOElP6qZ3EEb 6iG2vOJuDO6zOqq7jgy2RVOw+KAJcw+b61MYwmdIN7UH3fXT/A9A38yJoXO6DfvgDcP8 TYaN6zI1brSwv1y4mdl4t88pshjuAUCUcYbY+Kl5jobD6ubriusW2itgDC0JNzGSSmRM WWd3h9No+yMFnrPOm3oYSLe8KdUGoQyvipS7VsnpWJkyIis1ucxtjcNUjbDI2deBQvDq 3K8QJWtqSTxFJd0cl9ZrNXUNK+YbJ2Ke+DTbEoHcSJN/sIjMi/CiiQe8Xs2VLg4yEXg/ PXBw== X-Gm-Message-State: AOJu0YxcDzV0avTZi7iNn7xOvFiGawJdnbJdf2ulZH5bmX4O91NQTdR4 oIpwqNIkpEMTOvaUymehFOVKdL+Xtm+HE8mL1WCtL8PfQVor6cpm/WGK/5hYifcniSrrRN4LhEQ ktHVEehcbil/hOYHg4so= X-Received: by 2002:a05:600c:1384:b0:40d:8893:cede with SMTP id u4-20020a05600c138400b0040d8893cedemr1391731wmf.88.1704469515496; Fri, 05 Jan 2024 07:45:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+xAL0vO9ZW1vsQaRTfNLyZjoF6mL8cmKLgMcDEpbpdm1XnCJaIMM7rjBM3ijV+qKfOfDliw== X-Received: by 2002:a05:600c:1384:b0:40d:8893:cede with SMTP id u4-20020a05600c138400b0040d8893cedemr1391719wmf.88.1704469515079; Fri, 05 Jan 2024 07:45:15 -0800 (PST) Received: from ?IPV6:2003:cb:c705:fb00:4bb9:5362:8a63:a97d? (p200300cbc705fb004bb953628a63a97d.dip0.t-ipconnect.de. [2003:cb:c705:fb00:4bb9:5362:8a63:a97d]) by smtp.gmail.com with ESMTPSA id p7-20020a05600c468700b0040d30af488asm1940071wmo.40.2024.01.05.07.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 07:45:14 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 16:45:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING in __folio_rmap_sanity_checks To: "Yin, Fengwei" , Ryan Roberts , syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Matthew Wilcox References: <000000000000014174060e09316e@google.com> <3feecbd6-b3bd-440c-a4f9-2a7dba3ff8f1@intel.com> <36ace74a-1de7-4224-8bc1-7f487764f6e2@redhat.com> <8bc02927-a0f0-490a-a014-0e100d30ffe4@intel.com> <1eb61435-c89c-4ca1-b1b6-aa00b3478cd2@arm.com> <556f8a4f-c739-41e0-85ec-643a0b32a2ce@redhat.com> <58e2fe0f-b198-4248-9ead-fb5bf4f3edee@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <58e2fe0f-b198-4248-9ead-fb5bf4f3edee@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BA608160012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mmip3jq7mto3ys7b4hws4qizthihrgbg X-HE-Tag: 1704469518-777693 X-HE-Meta: U2FsdGVkX1/gWJTlkBSyRnpLCyQpL0aWMv6KIoLV0lZC6/c0BI4hWYDO7kt8eejDEjz57WtmKhkoyF8EGbv0/eqRGCIIVKTJrfUOJVYEZ8t9HFKunziAbCs8N8U2qjaL1huvNR+gh8ZPLlk+x9GRDDhndIG7uKOfKOVQtvbLk/J6kocu4UzfnsMpfGmA1dDk1Zc6+KvBlHLhbWqYLMy5Q6ezgtOvCBVXXOJU2o3RZuz7z36MaersH/co0mYu3Pkn985nD/5DC50XbvXq3+n7KVDublmPzYQR3P3ZEzUzqZf8F1euGmx/fULv/ZPEuGANCY2KPqfwRKnEHVaeMA7XMOrmHms2KCrw0u/Q8gBch/+pobYfjfGqaqmAWZ+7jm1BVvzAKnrtJyCfy6zZ4IfWMUqIbyerwHZ0xy2btlzXtXUCx5eZ70FHXXJMXMkjo37svYfonhLyRq91re59e4XIv7LnJQA/qv1rWf3Y6KkfyFa7IGHdG8uKXaYwy7RPxkqWWmoBjs6NQdIf8owZ7V2rDAZ6C13E0m9opRTlQ4nfCREn/Fz18ZB6P9gfammMGlRS3ddUTtA6/LaKa6PqQYWMLkFpd+u8tClh9bA0QDwZiH1V13mWcXvB1FDTbV6dhLTcoSsjyRUOhcu+ZbqVfyBK+nucOeNAFLh56jfbuOEu9txqaiVadummY+hUgI3SI9GUC6OEANazDX9+JKOU+b5NP9wVTIxzivJVIT7LGL3RZPjYiZKBRL2iH+/bq1U5jW50mdnwiY5WTzrW/9eSXM4HCNKW1fDWvTI0deH/WqsPU9DwNKerYzCkLnauvVd07o5l0Pt8VRH9f+IdAModoY82QOT0sQ1azgSpkMR2WhduSBKwrqpcDnzEkXaRjeYDRQ53JRPdvGOLwBzk3chneGAity2t+0nyn8cPDQcS0WWOsHR2dTpWl2ewN0ioIO8d22Jr0P/o9KN3/TwcRQAEQfo F8n8DgEW yamyoBO8dkAkB2xRNZu+zmW0zL6vgGFu4gBxxZNWzrSDv2wknvWclm/n2npOgr2Id37S3fcCxBJ9OWuzIhov65yR8+bZUItDd1dLWga156bGA8jtPMlfD07NOfKlmZ78NyjiGLukrAQlWvvSAkdHcPq/YDjjkWaCJMdp+FO6r11apaUHGcjwoz/0xSY5zV8ZKua0zP/6RcUNst9EH2RzNS8fsurANwsW+wUYr+NXBUw6vGJL2sOelXI3y1KAszXQK1y5wzyNOFUxnca7S/v6158lW3i4ofoP2+fH9OH8lm17GCO0AILQv7WazVatvfOX7S0mD2YFtHhhmV1YZv+yANUfEPfUXhBMjG0YqQj9qgsItTJYlroDdMXhuBenOVsrb0yXTslScuhjHNr5dVMz9F3NtoZAYi2U8+NrgX1NaGc4pAt3cYZKj/MSG39nP9FMSnZOO5ahofV9N6ycQ98iZGOOrSnu7vnSLSCqJgbHJN44Hp0GER3R1vRw0Y8txpWj4iLVbkOTHZ1PfIW+kSDxFXDWYd++fWsyHpdQz3nsCMRaHzUXo2Z2y2yrfooKwLbgV0yVPNUHxJJbO5/3CkE9kE7V1ceQHUDttzO3k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> vm_normal_page() works on these mappings, so we'd also have to skip rmap >> code when unmapping these pages etc. Maybe that's the whole reason we >> have the rmap handling here: to not special-case the unmap path. > > vm_insert_page() will set VM_MIXEDMAP and vm_normal_page() will skip > the page if CONFIG_ARCH_HAS_PTE_SPECIAL is enabled (it's enabled for > x86). So the unmap path will skip these kind of folios? I think we run into the if (likely(!pte_special(pte))) goto check_pfn; first and return these folios. That also matches the comment of vm_normal_page: "VM_MIXEDMAP mappings can likewise contain memory with or without ... _all_ pages with a struct page (that is, those where pfn_valid is true) are refcounted and considered normal pages by the VM." -- Cheers, David / dhildenb