From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A429C5AD49 for ; Tue, 3 Jun 2025 07:44:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 776306B03C5; Tue, 3 Jun 2025 03:44:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 727516B03C6; Tue, 3 Jun 2025 03:44:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D3D6B03C7; Tue, 3 Jun 2025 03:44:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4BFBB6B03C5 for ; Tue, 3 Jun 2025 03:44:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AF89C1607C3 for ; Tue, 3 Jun 2025 07:44:24 +0000 (UTC) X-FDA: 83513301648.17.E7FC26A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf07.hostedemail.com (Postfix) with ESMTP id EF2514000B for ; Tue, 3 Jun 2025 07:44:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mx2v9pM9; spf=none (imf07.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748936662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m2g0m9lNo/AUixY5X+NDXsr2+8Ch/gtrE4vjLL4NMb0=; b=NkeQv/FaHlzP5jpq6cwItB77w4z0bmCaPqDmEvGVwk7Hfp5SFuPnA+v0mlLOjVIwIt56aJ hUs4n1L2+jj0VzMnKCTAFW3jv58wJlcTEvwjjDZmig+o5oDjzvIa1YrH1dRfBm2lq1RQY4 k8bsqV8UZDRwMRGTd/LemkG1mJxpfBE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748936662; a=rsa-sha256; cv=none; b=Fw2xbkCVmINlwNBFpTwBs/T7yJ9Q8UE/kmWvW5ZLRfwC2OPVx6Mm/rVJ8iYvl5wxe0uInl XwGGOH4kLCJoae4fsWOTwt1iJXgregaS5/PMa157fqk6WtmtzyYVSBsLCTslw6d7x3a3ue MDvRZk/u3wrODARPVvaa+wGXE/TTOt0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mx2v9pM9; spf=none (imf07.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748936663; x=1780472663; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=UpRslWg9pkIdLUbErUepkqcrN/Ri7GcT0ZXvqzK9Dbg=; b=mx2v9pM9/bey/s6GzqJJoaMcVEsCAmszIgfQk9BRKPCZu1nFdVC5/wq8 AWfqr0zGOfDCPdo8I5OcLXE1KACB1KqzX/y/PPaSmFhASovSfKnYzjqM4 NkQ01rX/Kj9w7+iQWFXFUcE1WmGrbeuja1+u03O3yEb3/oyKBmEnfEvJ+ 8VC1r61qicIG2AR8qTlb8MuW7C+lmwwYisPZeGoWx1BYWUuPTD2Uwz+R1 fMtGAHaS76oeGbu/w3ajrqWuOYOai9J5kggL+aHNeI5/1g066v9lUhUhz 1dS7MqtAWTKGXkdLcFcVxhVKbpFjwSS/i7m+J0WxE5Y1EQ+3WKF1+Bumb A==; X-CSE-ConnectionGUID: Omuwta2RSmyLQtbdFwCAQQ== X-CSE-MsgGUID: qm173ty2QDi+0m1bCP4jYA== X-IronPort-AV: E=McAfee;i="6700,10204,11451"; a="50658933" X-IronPort-AV: E=Sophos;i="6.16,205,1744095600"; d="scan'208";a="50658933" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2025 00:44:21 -0700 X-CSE-ConnectionGUID: CjIy0pOCTVaGKVXeABbVtA== X-CSE-MsgGUID: u2fHNmR1SmipYHN6PBBHdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,205,1744095600"; d="scan'208";a="144670277" Received: from unknown (HELO [10.238.0.239]) ([10.238.0.239]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2025 00:43:59 -0700 Message-ID: Date: Tue, 3 Jun 2025 15:43:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 33/51] KVM: guest_memfd: Allocate and truncate from custom allocator To: Ackerley Tng Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com References: Content-Language: en-US From: Binbin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EF2514000B X-Stat-Signature: tethfmh8rhbwarikhppjqfj3k89xdzuj X-Rspam-User: X-HE-Tag: 1748936661-921869 X-HE-Meta: U2FsdGVkX1+GuhyVHVffOz93FNjjfOeWqcnrQikMQyUlPrMTlvPT0vyfc7dusnIjoYD1SR0pdF7xsb56POH7OLGMZcHAW7I+eLaWRUIkAQaNBBAFuxjAzLbUqQuYTVB92UvClhLzF3Q3CTcQE6Q55Sk6Qs1Oyih0DoaUkLi/moLQNZFbdfevcEDZyPFTxGX2DwbkONRtdCeHsgt6sL9knyyCsGgSP5F1a1bUEU0vOIv+95UHV56SZJfWJS53upMP+mfVpSZJtA9iFkh7aIl1rcDAlDmTdtCPZnOFfv7ANEr/TcoQQMFDRXB7DWpc1XEFAqRwGkTJSK9tQTDlgqKjrZKHp+zu1L3tP0PtsJ5CbG0d7MajphH108MO6GqOm7dsTOOzU/scuMmgXuULcSNnl17EC45yfn6hIc97FJYxywoPbYZ0pK8khbXkd+x8/PZvtVbHC1g1bXR9PS4JLc65pWj/yb73Kcem6glM/dibnKchAmxuNqM5XqxvnLaP40R1Ott6UVqpn391WL4aWtkq/e/TGpYqNWUX/qtUR7tPC4y8FjP28cxCedoV7O/HJf0AqB5+AuRaCVjLc9AkuI3aFH6DoeX/LAT3aXNh593ZbgpYVw1TCPfL1jTQwNjK0f4xuF3nwZRZwmWUGZllLR7PqqtTCktUdakpbgF/AbPi88bmRbyS5E+jja4zPjYTRr2VWK3h07rbPkW619B8E7U0Qa5fA0BVx8hZQf3Kx4BiLZdr2iNCExGFzBJot4f3v7gYF2yTrRzQKDLPVdY4Nihj/Ep0BJL/DvGY+q5QVPDCiMYiEm9ciHVpqLNByQq9bZ+CS3rlhjNTJupAXzCrCWzfF+rm8jPyi2BPMO2K9KIrVFSBFM1wdxRVFVfqNHM/nmKn92DOMuSyj0QAeXbfO222d5tQK2qTT28NHikhLIMPEfwvtZSKZea7g/mNs9u4Bgq4FKh4r6+AqjbJAfxkWHq b4i2nxJg HH2TbPQqKeI24W14iievg0OufvjL4YX1IKB86Eo6SUn6EeN/IZ46XhmnbVSayMs5uFK0Q1lsPsp/EH+0IyzeDsCfc50xsrfGy+zw1wC3dKWSPaqxz7ngCXfIhjXf94LuRNqxQdMgohhMLDYzcO0tVtMgPZF+zuGsardyE7CfA8LL4l9HNSymFEWEixVuxU3I6rTAtwNAdrVRLT4s3iZV35xCtNtIV5j7LKv6Alek47WcNcS5fM/pjH0hVGKOGVOi+lYr6UL9TRuZTX88O3uFEX8rFpasRxfajMcz7ovA8nzQZtvc9UWCjDeRuWII19w3NPRtU1OWPyhsUrism7rJlZIWWvZYNkJVxDsdd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/15/2025 7:42 AM, Ackerley Tng wrote: [...] > > list_for_each_entry(gmem, gmem_list, entry) > kvm_gmem_invalidate_end(gmem, start, end); > @@ -776,6 +879,16 @@ static long kvm_gmem_allocate(struct inode *inode, loff_t offset, loff_t len) > > start = offset >> PAGE_SHIFT; > end = (offset + len) >> PAGE_SHIFT; > + if (kvm_gmem_has_custom_allocator(inode)) { > + size_t nr_pages; > + void *p; > + > + p = kvm_gmem_allocator_private(inode); > + nr_pages = kvm_gmem_allocator_ops(inode)->nr_pages_in_folio(p); > + > + start = round_down(start, nr_pages); > + end = round_down(end, nr_pages); It's weird here. Should the end be round_up()? > + } > > r = 0; > for (index = start; index < end; ) { > [...]