From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Huang Ying <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH RFC 2/2] mm: Use pte markers for swap errors
Date: Tue, 25 Oct 2022 17:31:43 +0200 [thread overview]
Message-ID: <d0b8384b-6699-0485-1d39-afbf598a34e9@redhat.com> (raw)
In-Reply-To: <20221024204830.1342169-3-peterx@redhat.com>
On 24.10.22 22:48, Peter Xu wrote:
> PTE markers are ideal mechanism for things like SWP_SWAPIN_ERROR. Using a
> whole swap entry type for this purpose can be an overkill, especially if we
> already have PTE markers. Define a new bit for swapin error and replace it
> with pte markers. Then we can safely drop SWP_SWAPIN_ERROR and give one
> device slot back to swap.
>
> We used to have SWP_SWAPIN_ERROR taking the page pfn as part of the swap
> entry, but it's never used. Neither do I see how it can be useful because
> normally the swapin failure should not be caused by a bad page but bad swap
> device. Drop it alongside.
[...]
>
> -#define PTE_MARKER_UFFD_WP BIT(0)
> -#define PTE_MARKER_MASK (PTE_MARKER_UFFD_WP)
> +#define PTE_MARKER_UFFD_WP BIT(0)
> +#define PTE_MARKER_SWAP_ERROR BIT(1)
I'd suggest to keep the term SWAPIN. An error happened during swapin,
which is why the page is corrupted.
(I remember that we discussed naming details in the original series and
SWAPIN was the conclusion)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-10-25 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 20:48 [PATCH RFC 0/2] mm: Use pte marker for swapin errors Peter Xu
2022-10-24 20:48 ` [PATCH RFC 1/2] mm: Always compile in pte markers Peter Xu
2022-10-29 2:35 ` Miaohe Lin
2022-10-24 20:48 ` [PATCH RFC 2/2] mm: Use pte markers for swap errors Peter Xu
2022-10-25 15:31 ` David Hildenbrand [this message]
2022-10-25 15:44 ` Peter Xu
2022-10-29 2:49 ` Miaohe Lin
2022-10-25 3:01 ` [PATCH RFC 0/2] mm: Use pte marker for swapin errors Huang, Ying
2022-10-25 15:08 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b8384b-6699-0485-1d39-afbf598a34e9@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=peterx@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).