From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF45C38A2D for ; Tue, 25 Oct 2022 15:31:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C7948E0002; Tue, 25 Oct 2022 11:31:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4782A8E0001; Tue, 25 Oct 2022 11:31:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 340168E0002; Tue, 25 Oct 2022 11:31:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 256918E0001 for ; Tue, 25 Oct 2022 11:31:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9C58C0D88 for ; Tue, 25 Oct 2022 15:31:49 +0000 (UTC) X-FDA: 80059861938.22.6CCDBF3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id DC2F014001D for ; Tue, 25 Oct 2022 15:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666711908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ubJrAQo+otL1AZ9Abp0aYcF9mVXIW+a9k2CYvh8qVg=; b=GdjZ5+8DrNps+5w/7BlTWNtCZIimHRzNOeW0Qu+yfcJuJWS/IN8JtVb057fzFtsl5nr/wM kJrHszyvAlI5YUS3zvCtlTKNmurnLZs8N3fant2acir+XMx0MsIb006GNlkh0Ih7a2gNTy 8GYThJlOnag32EGC3e7kHwmcSlFpxeo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-225-OJbvFWziMx--N3JeVUuz8A-1; Tue, 25 Oct 2022 11:31:47 -0400 X-MC-Unique: OJbvFWziMx--N3JeVUuz8A-1 Received: by mail-wr1-f70.google.com with SMTP id e21-20020adfa455000000b002365c221b59so3871803wra.22 for ; Tue, 25 Oct 2022 08:31:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8ubJrAQo+otL1AZ9Abp0aYcF9mVXIW+a9k2CYvh8qVg=; b=kqPKm7g9jbdtwvMpZzIVaqlu/8U8Za91GSqOlF47EQuqX9BxdTXxwPkT6Cen+xXm3/ zYZ5ryfTWCOS5x2IUsFI3M6WCpHNCSMbTOUgEOZlnvoBXJbmdED8wFGp/uiZ8tdguLzE czfleCu7xAj8d3wpp0wrAk6tZtBI0IcIfj49CHt5/xcYkF7AGgQ1t76457L3CAE7GEsv jcguwlFfGrpuGNKOwYw+S3RwjOn0ZUB0VZK1yXj0TuuRtpIYsjXsoXN92Mr1uahHZVNU 7/s3ng4lL2C1gxQeD2UmXWf2HuqtK2B8W8xZVACSjYbkcNn42O+khtONGaOhitEG+bpL 3P2g== X-Gm-Message-State: ACrzQf2wqlEBHyxGvJu4x3t3aiJg2eN+YnnPRxjwrwIWFgcXlvqDD43O 64jfMzvga92TXJ8zLmAl80CY9yUT5DWBL8t+8piL3TH0K91gNgRt5kbu4XedpSD/UIHZDkA87dG Q3Yv98akxrFo= X-Received: by 2002:a05:600c:34cc:b0:3c6:fb65:24cc with SMTP id d12-20020a05600c34cc00b003c6fb6524ccmr27060404wmq.1.1666711905943; Tue, 25 Oct 2022 08:31:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4iTnlvYMQ4F2npklHfv1Ot93I/zcEUEDxI5AjUuriPL7zR9mOccMdvYem7JpMzTWpxt3ybFQ== X-Received: by 2002:a05:600c:34cc:b0:3c6:fb65:24cc with SMTP id d12-20020a05600c34cc00b003c6fb6524ccmr27060382wmq.1.1666711905674; Tue, 25 Oct 2022 08:31:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:d00:eae9:3af6:9999:7b63? (p200300cbc7190d00eae93af699997b63.dip0.t-ipconnect.de. [2003:cb:c719:d00:eae9:3af6:9999:7b63]) by smtp.gmail.com with ESMTPSA id k11-20020a056000004b00b0023657e1b97esm2972074wrx.11.2022.10.25.08.31.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 08:31:45 -0700 (PDT) Message-ID: Date: Tue, 25 Oct 2022 17:31:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH RFC 2/2] mm: Use pte markers for swap errors To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Huang Ying , Andrew Morton , HORIGUCHI NAOYA , Miaohe Lin , Andrea Arcangeli References: <20221024204830.1342169-1-peterx@redhat.com> <20221024204830.1342169-3-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221024204830.1342169-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666711909; a=rsa-sha256; cv=none; b=utEYdOtFsy4dqbWuv2fzmUt/wfClhkiS5Y0ByEs1Ji2+XXg1QiGPNcP/pZh+5wG+Q9nV7F gxnwrV+C7G0jmLb9Bqhi3gE43/XBfbWbHku77HzJRGVIWBQiMlMNgJJAFh+1rXDo5LTBtT RNsN3zOqxCd75AXzugQy0lX/ZGu2esU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GdjZ5+8D; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666711909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ubJrAQo+otL1AZ9Abp0aYcF9mVXIW+a9k2CYvh8qVg=; b=OPNb7pYrS4UBgHxxDF4OMVhufG1OsA+mkC2DOYX0eJM79NT5xieBYf46HVqLET0tF4+xcF 9w8k7AA/PuHYHMDhFLrtWGGtBk1U974iekXtPrLuRKi0CYKtpStj1Z85jnE1bsSXMvGHc4 MT8NkU91s2wbKgRdroHTU8h4uf4PzY8= X-Stat-Signature: na7fb866gnf3r53kwi6y9deo8f1wcdz7 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DC2F014001D Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GdjZ5+8D; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-HE-Tag: 1666711908-713126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.10.22 22:48, Peter Xu wrote: > PTE markers are ideal mechanism for things like SWP_SWAPIN_ERROR. Using a > whole swap entry type for this purpose can be an overkill, especially if we > already have PTE markers. Define a new bit for swapin error and replace it > with pte markers. Then we can safely drop SWP_SWAPIN_ERROR and give one > device slot back to swap. > > We used to have SWP_SWAPIN_ERROR taking the page pfn as part of the swap > entry, but it's never used. Neither do I see how it can be useful because > normally the swapin failure should not be caused by a bad page but bad swap > device. Drop it alongside. [...] > > -#define PTE_MARKER_UFFD_WP BIT(0) > -#define PTE_MARKER_MASK (PTE_MARKER_UFFD_WP) > +#define PTE_MARKER_UFFD_WP BIT(0) > +#define PTE_MARKER_SWAP_ERROR BIT(1) I'd suggest to keep the term SWAPIN. An error happened during swapin, which is why the page is corrupted. (I remember that we discussed naming details in the original series and SWAPIN was the conclusion) -- Thanks, David / dhildenb