From: osalvador@suse.de
To: Michal Hocko <mhocko@suse.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
owner-linux-mm@kvack.org
Subject: Re: [PATCH] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section()
Date: Tue, 27 Nov 2018 09:18:17 +0100 [thread overview]
Message-ID: <d0d9c37f888cbb3037761ad9be647bcc@suse.de> (raw)
In-Reply-To: <20181127080035.GO12455@dhcp22.suse.cz>
On 2018-11-27 09:00, Michal Hocko wrote:
> [I am mostly offline and will be so tomorrow as well]
>
> On Tue 27-11-18 08:52:14, osalvador@suse.de wrote:
> [...]
>> So, although removing the lock here is pretty straightforward, it does
>> not
>> really get us closer to that goal IMHO, if that is what we want to do
>> in the
>> end.
>
> But it doesn't get us further either, right? This patch shouldn't make
> any plan for range locking any worse. Both adding and removing a sparse
> section is pfn range defined unless I am missing something.
Yes, you are right, it should not have any impact.
It just felt like "we do already have the global lock, so let us stick
with that".
But the less unneeded locks we have in our way, the better.
Sorry for the confusion.
next prev parent reply other threads:[~2018-11-27 8:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 2:36 [PATCH] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() Wei Yang
2018-11-27 6:25 ` Michal Hocko
2018-11-27 7:17 ` Dave Hansen
2018-11-27 7:30 ` Michal Hocko
2018-11-27 7:52 ` osalvador
2018-11-27 8:00 ` Michal Hocko
2018-11-27 8:18 ` osalvador [this message]
2018-11-28 0:29 ` Wei Yang
2018-11-28 8:19 ` Oscar Salvador
2018-11-28 8:41 ` Wei Yang
2018-11-28 1:01 ` Wei Yang
2018-11-28 8:47 ` Wei Yang
2018-11-28 9:17 ` Wei Yang
2018-11-28 12:34 ` Michal Hocko
2018-11-28 9:12 ` [PATCH v2] " Wei Yang
2018-11-28 10:28 ` David Hildenbrand
2018-11-29 8:54 ` Michal Hocko
2018-11-29 9:29 ` Wei Yang
2018-11-29 15:53 ` [PATCH v3 1/2] " Wei Yang
2018-11-29 15:53 ` [PATCH v3 2/2] mm, sparse: pass nid instead of pgdat to sparse_add_one_section() Wei Yang
2018-11-29 16:01 ` David Hildenbrand
2018-11-30 1:22 ` Wei Yang
2018-11-30 9:20 ` David Hildenbrand
2018-11-29 17:15 ` Michal Hocko
2018-11-29 23:57 ` Wei Yang
2018-11-29 16:06 ` [PATCH v3 1/2] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() David Hildenbrand
2018-11-29 17:17 ` Michal Hocko
2018-11-30 4:28 ` Wei Yang
2018-11-30 9:19 ` David Hildenbrand
2018-11-30 9:52 ` Michal Hocko
2018-12-04 8:53 ` Wei Yang
2018-12-01 0:31 ` Wei Yang
2018-12-03 11:25 ` David Hildenbrand
2018-12-03 21:06 ` Wei Yang
2018-11-29 17:14 ` Michal Hocko
2018-12-04 8:56 ` [PATCH v4 " Wei Yang
2018-12-04 8:56 ` [PATCH v4 2/2] mm, sparse: pass nid instead of pgdat to sparse_add_one_section() Wei Yang
2018-12-04 9:24 ` [PATCH v4 1/2] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d9c37f888cbb3037761ad9be647bcc@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=owner-linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).