From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: peng8420.li@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org
Cc: osalvador@suse.de, jgg@ziepe.ca, jhubbard@nvidia.com,
peterx@redhat.com, linux-kernel@vger.kernel.org,
dan.j.williams@intel.com
Subject: Re: [PATCH 2/2] Fix the name of the source file for the "FOLL_WRITE" macro copy
Date: Fri, 14 Nov 2025 09:57:23 +0100 [thread overview]
Message-ID: <d0da951c-914c-482a-b5e9-93657b5f7a78@kernel.org> (raw)
In-Reply-To: <20251114085038.191031-2-peng8420.li@gmail.com>
On 14.11.25 09:50, peng8420.li@gmail.com wrote:
> From: "peng8420.li" <peng8420.li@gmail.com>
>
> The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it.
>
> Signed-off-by: peng8420.li <peng8420.li@gmail.com>
> ---
> tools/testing/selftests/mm/gup_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c
> index 75f7134d529d..9cdcd10d3f6a 100644
> --- a/tools/testing/selftests/mm/gup_test.c
> +++ b/tools/testing/selftests/mm/gup_test.c
> @@ -17,7 +17,7 @@
>
> #define MB (1UL << 20)
>
> -/* Just the flags we need, copied from mm.h: */
> +/* Just the flags we need, copied from mm_types.h: */
Can we just avoid the exact name and say "Just the flags we need, copied
from the kernel internals."
?
--
Cheers
David
next prev parent reply other threads:[~2025-11-14 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 8:50 [PATCH 1/2] Remove the "FOLL_TOUCH" test code from gup_test.c peng8420.li
2025-11-14 8:50 ` [PATCH 2/2] Fix the name of the source file for the "FOLL_WRITE" macro copy peng8420.li
2025-11-14 8:57 ` David Hildenbrand (Red Hat) [this message]
2025-11-14 9:08 ` peng li
2025-11-14 9:06 ` [PATCH 1/2] Remove the "FOLL_TOUCH" test code from gup_test.c David Hildenbrand (Red Hat)
2025-11-14 14:14 ` peng li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0da951c-914c-482a-b5e9-93657b5f7a78@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=peng8420.li@gmail.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox