Re: [PATCH v8] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB

[Mike Kravetz <mike.kravetz@oracle.com>]

On 11/3/21 3:58 AM, zhangyiru wrote:
> commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to
> SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012,
> but it is not deleted yet.
> 
> Mike says he still see that message in log files on occasion,
> so maybe we should preserve this warning.
> 
> Also remove hugetlbfs related user_shm_unlock in ipc/shm.c and remove
> the user_shm_unlock after out.
> 
> Signed-off-by: zhangyiru <zhangyiru3@huawei.com>
> ---
> Changelog:
>  v8: modify !CONFIG_HUGETLBFS version of hugetlb_file_setup()
>  v7: modify ucounts definition and remove the user_shm_unlock after out
>  v6: fix errors in v5 and remove hugetlbfs related user_shm_unlock in
> ipc/shm.c
>  v5: delete ucounts variable, and function calls that use ucounts in
> additon
>  v4: modify context information of obsolete
>  v3: modify warning message to obsolete
>  v2: preserve warning message
>  v1: remove mlock ulimit for SHM_HUGETLB
> ---
>  fs/hugetlbfs/inode.c    | 23 ++++++++---------------
>  include/linux/hugetlb.h |  6 ++----
>  ipc/shm.c               |  8 +-------
>  mm/memfd.c              |  4 +---
>  mm/mmap.c               |  3 +--
>  5 files changed, 13 insertions(+), 31 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

Andrew, the version you previously added to your tree (v4 I believe) has
an issue as reported by Hugh and should be replaced with this version.
Sorry!
-- 
Mike Kravetz