From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCE2C433EF for ; Wed, 3 Nov 2021 17:20:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DEAB6109F for ; Wed, 3 Nov 2021 17:20:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1DEAB6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A2175940007; Wed, 3 Nov 2021 13:20:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CECC6B0072; Wed, 3 Nov 2021 13:20:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821C5940007; Wed, 3 Nov 2021 13:20:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 712456B006C for ; Wed, 3 Nov 2021 13:20:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2AA948249980 for ; Wed, 3 Nov 2021 17:20:03 +0000 (UTC) X-FDA: 78768281886.03.918DDA4 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 71E8E9000163 for ; Wed, 3 Nov 2021 17:20:02 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A3GKJfH024009; Wed, 3 Nov 2021 17:19:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=UbtDcPYV5eexQ9uvea7dfl9VPCyOh2+HFsMx9PVkThU=; b=z+2dWyNSTq87Gd8ISWZgvn3KtDiIU32naoXvVOhj/WegHSODIDkflWGy+4eZQGoyLWD/ afdkIui/Y956cjTHsaVonGcUla+I9gh+au2vN97lpKlWBUt2FrbHg/QbwYIlVYU0rx31 jlf5U2lbfhzli/x9vK9Wvr7myW16aNC/iC9UikB2vkupyzOnpqQatrb+Lh9Mc+wh2Xdf cCIImKKjPK5FBVM/kuODSJCXul3s044QjNHIJ/bSxFiYDhcUK3CCC2OyDQQ7Y/JAv3ST 6eLUyrJ15U6MAAIRmBEa/eXVlb8B+bsKBG3wLvA1pEWcPPtZbhKyGwANQU83EdqQZYLp 1A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3c3mt5bk3m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Nov 2021 17:19:44 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1A3H5ge4170876; Wed, 3 Nov 2021 17:19:43 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2047.outbound.protection.outlook.com [104.47.74.47]) by aserp3030.oracle.com with ESMTP id 3c3pfxymcn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Nov 2021 17:19:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJVCDMzDEhDovzD6hHCUixH00i6T5FJMQX/Twv+ApQs3we4F3Ab9ppflVoYjXxeq67rHO5lw25MnyroUKxngAtDBA/HlovPlez5MwTyg9xnxA47Zj0HLj6esBP/rfdklHjkUmm0ONGHP2M0b8MK1kuhASD/DbXdiPiiYlTcdRhVxT1V/5xB6xS+vpTLeOWZ8nHvNwcUW6keW8IvTcTJ6XfpkdH/7ZoJGDdru6LKG0VJnp5XCvy86yjtb2HJHi1BAERvoYil7hRcB9P/0R7GyDcCMDtyWtljUNB+/DKKAudOHbbq6MMbYY3l6LiVOnByj0B7c5DcSw6aBrFEQXNJCDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbtDcPYV5eexQ9uvea7dfl9VPCyOh2+HFsMx9PVkThU=; b=RgmG3iojbIxTIh0lzc1idHlsmkug0IEm5WHfR/AKcFlbqzOt0wJR9+ll1MHzWZ7bQIzspkh1bezfKg1f3Md+FydcPrbJUZw2KXurzasAuj8Z/CN7WI44u8s80lGJ5R+Ywc3VFcCy7T6On5ng5eSnkeAbHzWwx71K7y9lNVJFoZ6HVLEePmLdMq4RLoZHqRBdz1OgpRXb9U5BZp0DRM4B+ow4WE9pEDWfbmJ+8SbXohAK12ErogcRqvGrMuAlXEuPqlgz9XkvgBMnLheoFyEqCjfnxbMZPUO0TlOUB3SYODJezPuCW4Edzm0OjAOtc1t3byVDwRDXCmzkxjeDiKZW3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UbtDcPYV5eexQ9uvea7dfl9VPCyOh2+HFsMx9PVkThU=; b=scDD5rRjz29IPUTQAobi6GfVGX+8yBjMQMuWQmnSotek1ahKlcNdun/h3Sv2WrwCj7fCSffYq9hIJQ7Z8iwqaranhx9Q9obw/SF1PsYDR03ChvDJz5a1YXf9gT7D1dZ1mvzbYNBhazAuq/lTciECfS7aUgp3VkBjXOqSfrunM3k= Received: from DM6PR10MB4201.namprd10.prod.outlook.com (2603:10b6:5:216::10) by DM6PR10MB4203.namprd10.prod.outlook.com (2603:10b6:5:219::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 3 Nov 2021 17:19:40 +0000 Received: from DM6PR10MB4201.namprd10.prod.outlook.com ([fe80::1d20:90b1:433c:15ab]) by DM6PR10MB4201.namprd10.prod.outlook.com ([fe80::1d20:90b1:433c:15ab%4]) with mapi id 15.20.4608.026; Wed, 3 Nov 2021 17:19:40 +0000 Subject: Re: [PATCH v8] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB To: zhangyiru , akpm@linux-foundation.org Cc: hughd@google.com, linux-mm@kvack.org, liusirui@huawei.com, liuzixian4@huawei.com, mhocko@suse.com, wuxu.wu@huawei.com References: <4d9194bf-e411-53d8-daa0-b12828d46ed6@oracle.com> <20211103105857.25041-1-zhangyiru3@huawei.com> From: Mike Kravetz Message-ID: Date: Wed, 3 Nov 2021 10:19:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: <20211103105857.25041-1-zhangyiru3@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P221CA0005.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::10) To DM6PR10MB4201.namprd10.prod.outlook.com (2603:10b6:5:216::10) MIME-Version: 1.0 Received: from [192.168.2.123] (50.38.35.18) by MW4P221CA0005.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 17:19:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 124fa679-3823-4187-1d66-08d99eee1e3d X-MS-TrafficTypeDiagnostic: DM6PR10MB4203: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:51; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +QajdmXQkTHXUDRF2Y+pg8+AErZg0qlTs5986p6dg58/C4HtnRNZ61wBoOZXagN1pPA3yFtMM+zpk0dWI+hWHfNTEtTFjuQfzsM7spyEVydKUzryI5YEM9dApLS/iBBPHyE+pFJDMAPFdZ5iHkRRHngocgpbT0XiY6sLk9JD9pRLf0eVabWCdsdHL7T35zejgm964Brr9CaKgUgWTP2fUDlwmzE429PtN4M2/zGXai2JxpSXq4uJr8z2Mqs49PwR0UCUOv223hmHgaiZ9jAFkgA/wU3cgxmWlUYbEKIkX4niabfbCAsmod7eQGSxNfFIuCSwdzeKIs3S2Nocou36i8AUGFg+/sBZ3J7KsC78BxULc0kWPLr78MAneppL3GFNG31iA7n46wT/1nI/AANxPJNZsXDju8teVP4964QTlIFI/gQxsKCoXQoPgkf1iGDYXX/9wr4otmJ2RCiHrnom6xkYqzwcmV/oTuA8w+8jAE7pPfRS4otKPAjoTvy+F8JffpJyLuLLQ7a2Tu0CTYe7bOnkVvnKAFPgks4fVwSYgzS/EaismPldCSkjbQ+Ew2rXtDWaR8U7H6jSElTKym5fX/am5H76SMnHMUku4BSzNraSnNHzlhWzf1WFJGapk26mBwOhuYqBZBcGs7yXv2+LP/0JrOYX5W4MfniJMisYQlMhJSukDPJbsM9+zEpWj2LdOlG6+L+3zU5Xo6bqtlxDXCdxz6ZWHIvBrmwgLmTJ6jsI/7y3w8b0Ddt/lwXSl86Tzmv/ys1ZWeVhJvv9THAPaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4201.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(31696002)(44832011)(956004)(66946007)(66476007)(6666004)(6486002)(66556008)(316002)(53546011)(508600001)(86362001)(8936002)(52116002)(5660300002)(16576012)(8676002)(186003)(36756003)(4326008)(26005)(2906002)(38350700002)(38100700002)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDV4d1FTeEpKb21FakZpckdDcnIvNFBNT0l6YXZBaG5WTVV1MFUycEIrSG5n?= =?utf-8?B?c3lKVGVxQTBKU1ZTcitSckM3bmUvT0xHcUpMYnJOQ3BDaWowNHdjWU0waGZO?= =?utf-8?B?dyt4VnZUc3NlSjlJYXhQQjFXUUQ5M1V3ZkRYN2NTVEZtWnJqRjJNZXdka0tT?= =?utf-8?B?RGNBNFBLL3I2VG9xMU5kZThOV0VpUjlqVEZzZVNUR00wRVQ5dHorWWEzK2Za?= =?utf-8?B?c0ZxbjhheUJGZ1JmWmdoaWdVRjVycVBFK251aXNZb2xsaWsrNWliRzdwUDBm?= =?utf-8?B?MGdubHNXd0dMUDZ1eG1oQUFMYW1HZG1FT1h0aDVDdXhGTHkvcjZFUjdZWGt4?= =?utf-8?B?Qkh3ZHpCdzNxNHkxK0hWNU5mRTljcWZwZlV2dkhaTHBoaEhKeUxvQnllWmsw?= =?utf-8?B?eUJvWXFBS2YyVnJKVytoc3hYNkJsb0ZKUk5DbmsyemdnNXZtWGJYOTBpTE1J?= =?utf-8?B?RG9oODhGVkpyTGxDdHV1M2dHbXVWU2hnTGFzL3NrVHVsWHV6RXRTZjRtVXhC?= =?utf-8?B?WlNROFNPS0pURzY3ZTBnM3FHRllqcGdvN0VoVnlXbjI4a05nZzUvUFZuUlVv?= =?utf-8?B?T0VLazJmdWFXZVovTWtCRW94NHF0MGQwdGpEWS9YL20zQUFnaG4zL2NBWHZJ?= =?utf-8?B?c1o4and6M21MOEhJMXUvc1ZoU01DMEQ4VHRJSEl4QlNXM0lWN0tOSkVaaXFi?= =?utf-8?B?NHA1bkIzUnhMTmJPb0lSMGRSWktXM2hySHlmS0NiS21Wak0zT3ZHNTJ6SXVh?= =?utf-8?B?Ui9LOUNzZ1REMnR1LzhhZ0JqZ3NOVitUdk9WSU50MktRNDdiT0hzN2t1TEZw?= =?utf-8?B?VjI2K1Z1VVdqSzdlU1Q4blJmSSttOVRRcGhnSXVIalVNVkZpUDhQZEtDT3dq?= =?utf-8?B?Z3pBK0p2b2tHUCtRTERtbURGa1dKZjF6MmVRcHcybVpsOWVJQVI3VVJCdDhE?= =?utf-8?B?RnNpODlrL1kyblJ0WVVvZ1prcm9BRERQUVF3VzdPS2NnY1dzUjVzQndWc0FM?= =?utf-8?B?MzNsRDVYM1dYbDZ0bklzbTRlbWJqM0ZGTzlYYXY5VFhDMmtCMWo5ZjAwVjhY?= =?utf-8?B?THU5Z25ITkFOSXYvNXZIRGlWYm9vUTBMU05IL0g1ZHZBTjRRUmY2N0I1Tzlm?= =?utf-8?B?ZFRoRDNCTS9QcFRxcE1DSzhXc1c3TWt1YWtWaGtSbWpqaUFVMkViMkU0NlMw?= =?utf-8?B?R25IMFVhclNpai9INzJEb2x3QkZzdkdGUHVjU0N5RGhKdXNJeFI0Q2tadVJB?= =?utf-8?B?WDBvVFZudEo5NExxQ3Y2cy9IY2l4UE83dkhJbVdINTBhRlcwWnRPWi92MGlP?= =?utf-8?B?U3V4VndoQlE1c2xWNDJRMWhacTVVYjB3WjRnRUhNNThDVDNLQlNxY0Z4WSt1?= =?utf-8?B?V3ErZitDQTl3WEFOcEdERWFhT3ByazFTQ01HM1lEdUhTeGYyV3hHTlNTdVlr?= =?utf-8?B?K0NFaktWODYxZ1pjSk9uZmwva3JKbFE4bTAwVHFEUnhFbGlSajVwY0plY241?= =?utf-8?B?MDA2TFhqNDF1bkFPcExqWkxZa2N0RG42UFdhZnU5MTN2ZjB3MDVjWXBZNGZ4?= =?utf-8?B?ZExBZUZjNERIeGtlUmV1djNFeU1ScGhRNUlsYS9VWTgvY0MrdXZqbW9Zc2FW?= =?utf-8?B?em9GbGxqeE1JTVV6VW1YeDZ0MWhqK2hMSk5Xd3VYYzNUakVpYzQrdVcycXlV?= =?utf-8?B?UWFrTDFHZFIyVEZQVUtqdzdBNHg0MHppRVVRdk96QVBUNFVFYVNrZU80em4w?= =?utf-8?B?b3owRzNqcmVJQ2pNMlJ3OTRIc0oyc21pVzMyS2ZkVEE0TVRGZzMvN2xQQWNY?= =?utf-8?B?R05McTdKMjNtbXdOandPM3V4Q2p2ejh6TElNNkFKSEVjUkRZTERuVWdkaU9Z?= =?utf-8?B?UE5XQjcyNzI2TFRFS1EzUGNmS0NHRElKMFR5QnRMMXpNczVWaThRNDZ3RytK?= =?utf-8?B?UG9nbG1USW9JOUkwVHRaaEZSUnRlWEQvbFpvY0N1dTFaVk1WblI1TkpGd21M?= =?utf-8?B?SlB5dmdzSXYwdno4ZE9pcVZNK1hqU0JJSEtpMnMvRjRiTCtBRWp0T2k5MkVJ?= =?utf-8?B?NGhJSnFDUzF0ZVdjYm05OGRzQUhmYWhCd1VWOUF6SWNLODNmQ2hIcGhRK2ZW?= =?utf-8?B?U2Z3YXU3ajdiVStmYVllWW5lNWxGeTYwMVVhYmhXMXhBUXBPVTNjUmNjUGIx?= =?utf-8?Q?0qqQ4i+atA3sFXtj4F1s1Jc=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 124fa679-3823-4187-1d66-08d99eee1e3d X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4201.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 17:19:40.2495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 78mAI45siqiMmFfkgNh/KRdDdxMbouRWT+q3X+7bchJoZ+2z/12RgC9s2z9u1DQCexlHsVP1ngHxejpDFNRWqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4203 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10157 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111030093 X-Proofpoint-ORIG-GUID: lZ1cqvPR2TtAVroht7Ms10SHhpEkHojM X-Proofpoint-GUID: lZ1cqvPR2TtAVroht7Ms10SHhpEkHojM X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 71E8E9000163 X-Stat-Signature: khkz89jiizecow59z4niht4hj56gwfrr Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=z+2dWyNS; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=scDD5rRj; spf=none (imf29.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-HE-Tag: 1635960002-311297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/3/21 3:58 AM, zhangyiru wrote: > commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to > SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012, > but it is not deleted yet. > > Mike says he still see that message in log files on occasion, > so maybe we should preserve this warning. > > Also remove hugetlbfs related user_shm_unlock in ipc/shm.c and remove > the user_shm_unlock after out. > > Signed-off-by: zhangyiru > --- > Changelog: > v8: modify !CONFIG_HUGETLBFS version of hugetlb_file_setup() > v7: modify ucounts definition and remove the user_shm_unlock after out > v6: fix errors in v5 and remove hugetlbfs related user_shm_unlock in > ipc/shm.c > v5: delete ucounts variable, and function calls that use ucounts in > additon > v4: modify context information of obsolete > v3: modify warning message to obsolete > v2: preserve warning message > v1: remove mlock ulimit for SHM_HUGETLB > --- > fs/hugetlbfs/inode.c | 23 ++++++++--------------- > include/linux/hugetlb.h | 6 ++---- > ipc/shm.c | 8 +------- > mm/memfd.c | 4 +--- > mm/mmap.c | 3 +-- > 5 files changed, 13 insertions(+), 31 deletions(-) Thanks, Reviewed-by: Mike Kravetz Andrew, the version you previously added to your tree (v4 I believe) has an issue as reported by Hugh and should be replaced with this version. Sorry! -- Mike Kravetz