From: Bodo Stroesser <bostroesser@gmail.com>
To: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>,
linux-mm@kvack.org, target-devel@vger.kernel.org,
linux-scsi@vger.kernel.org
Cc: linux-block@vger.kernel.org, xuyu@linux.alibaba.com
Subject: Re: [RFC 3/3] scsi: target: tcmu: Support zero copy
Date: Fri, 25 Mar 2022 10:06:57 +0100 [thread overview]
Message-ID: <d15369a8-7a98-1b1a-b950-40d78ed5e9ec@gmail.com> (raw)
In-Reply-To: <57da7e54-f582-3b10-52a9-5166adacf4e6@linux.alibaba.com>
On 23.03.22 15:33, Xiaoguang Wang wrote:
... snip ...
>> What happens if the tcmu device currently is not open / mapped?
> I'm not sure how it will happen.
> But we may check whether udev->vma has a valid value. If yes,
> it'll enter tcmu_cmd_zerocopy_map().
>
Yeah, but what I also wanted to suggest is, that if userspace maps
the uio device while zero copy cmds already being in the ring,
you have to iterate over those cmds and populate the mapping.
Bodo
next prev parent reply other threads:[~2022-03-25 9:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 9:55 [RFC 0/3] Add zero copy feature for tcmu Xiaoguang Wang
2022-03-18 9:55 ` [RFC 1/3] mm/memory.c: introduce vm_insert_page(s)_mkspecial Xiaoguang Wang
2022-03-23 16:45 ` Christoph Hellwig
2022-03-24 7:27 ` Xiaoguang Wang
2022-03-18 9:55 ` [RFC 2/3] mm: export zap_page_range() Xiaoguang Wang
2022-03-21 12:01 ` David Hildenbrand
2022-03-22 13:02 ` Xiaoguang Wang
2022-03-22 13:08 ` David Hildenbrand
2022-03-23 13:59 ` Xiaoguang Wang
2022-03-23 16:48 ` Christoph Hellwig
2022-03-23 16:47 ` Christoph Hellwig
2022-03-24 9:16 ` Ming Lei
2022-03-18 9:55 ` [RFC 3/3] scsi: target: tcmu: Support zero copy Xiaoguang Wang
2022-03-22 14:01 ` Bodo Stroesser
2022-03-23 14:33 ` Xiaoguang Wang
2022-03-25 9:06 ` Bodo Stroesser [this message]
2022-03-22 12:40 ` [RFC 0/3] Add zero copy feature for tcmu Bodo Stroesser
2022-03-22 13:17 ` Xiaoguang Wang
2022-03-22 14:05 ` Bodo Stroesser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d15369a8-7a98-1b1a-b950-40d78ed5e9ec@gmail.com \
--to=bostroesser@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=xiaoguang.wang@linux.alibaba.com \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).