From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A98C6FD1C for ; Wed, 22 Mar 2023 11:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FE4F6B007B; Wed, 22 Mar 2023 07:19:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3878F6B007D; Wed, 22 Mar 2023 07:19:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 228586B007E; Wed, 22 Mar 2023 07:19:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0C4EF6B007B for ; Wed, 22 Mar 2023 07:19:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D9BC01C5B37 for ; Wed, 22 Mar 2023 11:19:00 +0000 (UTC) X-FDA: 80596287240.08.8C2A1BC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id BED75180004 for ; Wed, 22 Mar 2023 11:18:58 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OAnggRhZ; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679483938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q4PBeFJVq5sXMm2kVcvHwookT+3r5JXG0gTDh8oEJNU=; b=Sb3uyYzd4S2ifBa13VJ3HPw5a+JUsodVHOimM6dkJ/rZdYVEnBYpkLBsQpOmTa1jM5K/RH Qhk6lx86jcPQTcr3IJ+EpqCdSDIJOUeCIgTjRp8jm2WzPV03sWspO6wUhAmm6CY7iyc73z bgbZRNLgJbKXLsFsgsle7/2vxCBdZHQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OAnggRhZ; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679483938; a=rsa-sha256; cv=none; b=F76rID4Mo8RlESILazPTlLUMA1248G0JrGpACXrX6PVgY1wGHbUXY9XvTDw8x4Gd0zgQCB ClWLVmZfnptvNLOnFLwq34kRmZliYoLQch99AWkY6MsMwIjP0Hbnn/7gFYXxwEnmlgXnWk OTU1G+qcxChjUHJP0CdGVCuQjaElLxc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679483937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q4PBeFJVq5sXMm2kVcvHwookT+3r5JXG0gTDh8oEJNU=; b=OAnggRhZWUz/8+ZektwMDgmcCAKxwSpCSgG/UFKt86RzyQlVGiqm1erQEVJVDIv2dqLq/y +Qc7OQr0cc3Qn58oECT3o1qvC+xTlRZK4Pn1a3xMIYHjeQ9J/roQgBwInMFoUlPQLhhhWY QGNn+BC04T75C4xNUgPiCtFrtcY2T2M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-X9ydb4iUOBmAMnqbsGmlWw-1; Wed, 22 Mar 2023 07:18:56 -0400 X-MC-Unique: X9ydb4iUOBmAMnqbsGmlWw-1 Received: by mail-wm1-f69.google.com with SMTP id n33-20020a05600c3ba100b003ee6335b6adso661748wms.3 for ; Wed, 22 Mar 2023 04:18:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679483935; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q4PBeFJVq5sXMm2kVcvHwookT+3r5JXG0gTDh8oEJNU=; b=JMG2LKsk4vtIgfYE16xtew3u6SJR0DQgUmDPcABx2jEzfNwqhSHmSH2NJHuXg9FWly FwSnddRW6fr+WS0BdEagOD/rCQFfbzLCQcl9o9fzmPpuwA+rXrKficF+zHBDKB8empmK ZbOHDvkK3zVFkfaGXQrDqtZS5za9MhdrKU2GVcf6JmVeOgoHBPlWPDFx94c8uxbtLz54 /Bj+KoxMWC4DnuH/O1OvmIte9DOzjDjQzVQc6rY9t7G9InjrTjWT5Hay7noVSerw0khr Mypr06QXPRasFtZnrbWjtZpI22Bmp2Zvh/N0uosAYWVkXIHwmcHIzJo5aBSjk1lnQFGt Y8BQ== X-Gm-Message-State: AO0yUKXid+0LjGxnqwn4nJlWfxjWDiLHOwAGXOK+D8+1lhLnDHPKmoDN YoXI/lFng3cQLrLy++PsOEQqnSaDjPpXE7TKRHBSrV/+yrnJsk90t+dOxUwt3qa8Hh4AXOKNOch dAP2S/lbjuRQ= X-Received: by 2002:adf:ebcf:0:b0:2cf:f35b:9aa2 with SMTP id v15-20020adfebcf000000b002cff35b9aa2mr5083030wrn.19.1679483935293; Wed, 22 Mar 2023 04:18:55 -0700 (PDT) X-Google-Smtp-Source: AK7set8NWBavpXfZJCtR0zWMvJ2tk+TF3CcC7KjKh7fqSTp3IiRzYiIqIqJFR2gpzL1SxrRhG0XTEw== X-Received: by 2002:adf:ebcf:0:b0:2cf:f35b:9aa2 with SMTP id v15-20020adfebcf000000b002cff35b9aa2mr5083014wrn.19.1679483934972; Wed, 22 Mar 2023 04:18:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:d00:ca74:d9ea:11e0:dfb? (p200300cbc7030d00ca74d9ea11e00dfb.dip0.t-ipconnect.de. [2003:cb:c703:d00:ca74:d9ea:11e0:dfb]) by smtp.gmail.com with ESMTPSA id k2-20020a5d6e82000000b002c55b0e6ef1sm13808154wrz.4.2023.03.22.04.18.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 04:18:54 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 12:18:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 08/14] mm: call {ptlock,pgtable}_cache_init() directly from mm_core_init() To: Mike Rapoport , Sergei Shtylyov Cc: Andrew Morton , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-9-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BED75180004 X-Stat-Signature: ui1tcm53d7ftks3akg33ujxcbaq4swx4 X-HE-Tag: 1679483938-92311 X-HE-Meta: U2FsdGVkX1/owkex/adjCNUs1pMAalvhDKyAwkWpkBhHqx2d1W6qGsYBd+zk/Nl3Zx+RIuNr60jnBjXkFc0a4S5zaFeNRfmi3q4MDSR2VC5eFgwvogJEKEPqWHNCCnMPHZbMW3DCYcDdtawYCK6ry3LnxOts71fyX5irWgbB9x1pHtUGc1LKyGDtG8lq6YJf2mDG6BeJZmT4L0MPRrBDl/uNSvQxqtfTOEQl5mq3ZdSTcQ1kHtP0YISnRBrmOxovNPjmr7VlUJMnw8Ozbq4n+PekL9N/WvZ9xFNKg+aZeAHyxH5vVZYb/xQO5ZKDhMrdeLL9YZcYQqiRpiKTLcL1+5MnflK9T8LoJdce9h6dn7pH1Z5kM9BT7F9y6vAKLdsBrrtWh0apWAKJAvv4BJ4HL6FjiLMNfRb+vUOkGnopRVhrMzqUEqdJuZrHWPJtVYmpUVnDzm9oOcOwQNWuojwzCCwVrAzq/WqcWSh++TBC66Xtr2slWT+Zy8haSD35NiPt6LAqbsgQDHAdv7CQfPCy6/+mp+g3r5ibX3ZM5B8j6gwUZw44d/kY9D6e4cv8etCgX3zRd3Gv4sQuDa+3NfTAZk64TulZ0HfbkKkoO6SyCiT4wUc6wyWpl1nPEaFi5VXVrfQMIs56B+KPUf5A1U1sgjv+MHwhrs1lhkO+DJo2mTKDjac1AlYrH4jWLBrZDFaLMoQUsYC/kLedSMjKIflX0Jq24BNcFHQzLP4J6hZ6L4wyr8MHDmhvSr6PH+DViFFbxkKYE8gxO+dLK6nUn9kw73Q/9kVONIEqrSJFTJ3254BLVV7Sgg6aj+6aRFFKjDMFk+1YF05SBon0giqS7XnE2XqkYcqLPmqLIO/7xEfK7jHIYSrMSVO91cibPpLk4lnH6NiKAu870AnE+gpleE8wtPLV6Kvq4QMHcmxyWmF4Hb/Gs6AZDckkT375I2q/McP7oaWGSZdjWRFWzYQhryE ufzPRzQv yem77G9QbYZeOZVijJEX4azu3dCnHRriBNj1mJBmg/2rTv7knnp7MORD2NVvSyEo/QDHWEonUZgnFPpq4gXTMgFk4F+9vkEXb47+XJ7K2x+7L/yPmt3zzup11j+OkNcborkb+toAgC+kXvD8MJfoFe6wDy7Q6wwnERRFKlQ8L7/Ob8G/kLEwYBvAiuBwgft4QUfUDI7ma67aV5r1ZCK4oNBAWSd6mIZktfHxUcqf7KMGNLK1ooM4x8AU/RfxZOECK/i2TpJIpcnQXxMbqrrL58msQJthP0EtCRNiH6aJB1IdJHtUJRTCUS/GTNa+p9rWeeUaZNCcprkozJ1nR780AvRYbJSBoojk1YwsEnIpHud93VSWFYmo5SedCCY3UYZY2srCbCkQC+efpJwb4/y7+Q62E6DvGtp1aeK8Vj3/2VFdsoS0U6OrWvtgMe+r1B8k0zaLiHYlyVCAx/DrCUN0xpVZlDYaQ4Q7AwFw5ZxVzE8F1wWSroUYaNdqOpi4i0P7xt1iS+S8cs/CJy3f/sR4i54LMstYJsz97WFVFnTfAuP7VLNAj0OcC202U2QW04wqPOjJPj+vlDN5a6GB5KiipHJH8ZEdy8vxbctPw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.03.23 11:08, Mike Rapoport wrote: > On Wed, Mar 22, 2023 at 12:06:18PM +0300, Sergei Shtylyov wrote: >> On 3/21/23 8:05 PM, Mike Rapoport wrote: >> >>> From: "Mike Rapoport (IBM)" >>> >>> and drop pgtable_init() as it has no real value and it's name is >> >> Its name. > > oops :) > > Andrew, can you replace this patch with the updated version, please? > > From 52420723c9bfa84aa48f666330e96f9e5b2f3248 Mon Sep 17 00:00:00 2001 > From: "Mike Rapoport (IBM)" > Date: Sat, 18 Mar 2023 13:55:28 +0200 > Subject: [PATCH v3] mm: call {ptlock,pgtable}_cache_init() directly from > mm_core_init() > > and drop pgtable_init() as it has no real value and its name is > misleading. > > Signed-off-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 6 ------ > mm/mm_init.c | 3 ++- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2d7f095136fc..c3c67d8bc833 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2782,12 +2782,6 @@ static inline bool ptlock_init(struct page *page) { return true; } > static inline void ptlock_free(struct page *page) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > -static inline void pgtable_init(void) > -{ > - ptlock_cache_init(); > - pgtable_cache_init(); > -} > - > static inline bool pgtable_pte_page_ctor(struct page *page) > { > if (!ptlock_init(page)) > diff --git a/mm/mm_init.c b/mm/mm_init.c > index bba73f1fb277..f1475413394d 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2584,7 +2584,8 @@ void __init mm_core_init(void) > */ > page_ext_init_flatmem_late(); > kmemleak_init(); > - pgtable_init(); > + ptlock_cache_init(); > + pgtable_cache_init(); > debug_objects_mem_init(); > vmalloc_init(); > /* If no deferred init page_ext now, as vmap is fully initialized */ Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb