From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B61BC2BD09 for ; Mon, 1 Jul 2024 08:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C60366B0089; Mon, 1 Jul 2024 04:23:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0FCC6B008C; Mon, 1 Jul 2024 04:23:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFEC16B0092; Mon, 1 Jul 2024 04:23:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 90C656B0089 for ; Mon, 1 Jul 2024 04:23:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1291DC0BE7 for ; Mon, 1 Jul 2024 08:23:00 +0000 (UTC) X-FDA: 82290493320.22.133CEA2 Received: from out0-211.mail.aliyun.com (out0-211.mail.aliyun.com [140.205.0.211]) by imf06.hostedemail.com (Postfix) with ESMTP id 79CE4180007 for ; Mon, 1 Jul 2024 08:22:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=luALwVVY; spf=pass (imf06.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.211 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719822150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vGhjO9uIjc37ou1f7D8tf/WdHUzM0CCNY36XPbaqCkA=; b=KH5tcTHXOaagugWEDVpuO74hSKJWSSbYIj5PIYneWbuHwTMSr95MOU/eQMfittB+Oi3Uqw VRZNnk76UjmmfGmJpWTdMr8BNAUEEKuxc/wiB4FnRCVuLMYtlUuVoykLpXjHv7vXVZwybT cdjPAy65cTg8/0hdEMhBRRQYGlFXMKo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=luALwVVY; spf=pass (imf06.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.211 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719822150; a=rsa-sha256; cv=none; b=r6VaATjl4DKYM5PPyF4enCd3gzVX2FeWeSQvSq5hc/CJtfYMx4y/WsHLaeDz3FEWuuN0qP +CkAwWYsBQ/uFQS4rg6r7P8683bEXaYY/LVygPNX1UkdNQZz/WO7fN4tdiisJWgDYULjMN sh0d3+JMH/btEk7bqKT2WPM8Q0qyshE= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1719822173; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=vGhjO9uIjc37ou1f7D8tf/WdHUzM0CCNY36XPbaqCkA=; b=luALwVVYsr2RO3rGpFUPmM5fUOCWzqj5YIwXzrL5RUcAbSY9cs0ssGuBE9Xbg/k9rRqvOirWqflvYCElAxFVBc/EgSbHYJkfW7ZggU6joJ1OiCzNUnPs0eWqO2Eb+7VDlOO7a/Cz0ut4i+OICyz2iboHTZXHQFA10EUyTufCDdA= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033068157007;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---.YE88zYj_1719822171; Received: from 30.13.185.168(mailfrom:libang.li@antgroup.com fp:SMTPD_---.YE88zYj_1719822171) by smtp.aliyun-inc.com; Mon, 01 Jul 2024 16:22:51 +0800 Message-ID: Date: Mon, 01 Jul 2024 16:22:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: David Hildenbrand , Baolin Wang , hughd@google.com, akpm@linux-foundation.org Cc: ryan.roberts@arm.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song <21cnbao@gmail.com> References: <20240628104926.34209-1-libang.li@antgroup.com> <2972d75a-ab26-4da7-88fa-81bed955cf52@redhat.com> Content-Language: en-US From: "Bang Li" In-Reply-To: <2972d75a-ab26-4da7-88fa-81bed955cf52@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 79CE4180007 X-Stat-Signature: 4byyzim16jkdn7m5i837wcqqa9drqfud X-Rspam-User: X-HE-Tag: 1719822176-994568 X-HE-Meta: U2FsdGVkX19tQuzyLF4RQIIgFoBwZvFRuEdX8xMdAJd/TZnB9AIqqs92sgbKFMlGUyW4lu2k1LK2f4a1b+9MKAMr3+GXRaLAe/fyYb432Klxz/3+cjVBjUIMUsLWYajwVnfXKbHVfzL32vuM8dCLd6/1Ht4QV6BXnHRCSz1x1DUGBylQyMe3/thzZuhR1Hb/BqVnlDGm3iMpYr/al0MZxK5P0Z7hYJbHp+iM2JBJ3tLYcwyR5PPSl7tAL+g3F8r21n0X00EWl0m9X62ps3Wlg7P1aGJHUsU2YAFFfj71NWJ4q2kDQuXeAyWmGlkGNPMYYTia+3OzBz86VFQg3+fdP65MnF3nAhcaX5UDW9EbwagVhrFAQ3ntt+iEUYrBKLIS56+QTFd7ZeGKcJQcA+YLbzhNeEcZU+oIgOEtC9/MdcY4QTQNtxCn/hqn9g5NRcJgL3GqgeMvj7e/P8x9BA61u2pwvJXrDpFVLlMVr7G6p4DuiHDPmhnAUsGbevDJdG8N7XtoF0ndDZijShHOTeVFzmlsxbWzUocA6hrtiM3DZ6RZ9iqo40AJo72HyDx/931wZGxTF+BRn6uLyjibFcz5t+V8EhqsV6gtdD8PsMLR2QmNLKnYV5DmXXVVYS0J6HYy/Vm4qeUqXJd6A5YvPnLs0C6ySansQMBZLpFJLfShFaz0E317sGSmCLPBWcGc7FSw7BkX7R4CiVqh3xyt3YD4fBd7ttnD9qm46RMu+8aG4dRLqCCpAfzZwOyIgiG5WocLMb0qjls6vi36TgpSporwp79Xv7Zw6g05HW7yTMRHDQeI1HopEg7NuCOz/rU2uuoHcvXeOH7Ag8K6V6okkRWRthAbBZVQxWRjcbjEj02IC9B+ZyK1B2/Fk/FImetn4lALWUkVr2SUuBEe/4gz8ktUjr+tMuDP20BCELpx8rNr5lQs9Vw7j3b1aZISb3jUlaDx0e9FJkwTVl7dAQRTroq wb1NNlwm 8yZi5YFn9kZn/RfotfRM8rUHNEqV9wRjY4Jlkdym5mq1n+NCHoUv1DVUa8DQatoib9+dgxpSZVQfkvg7RtZ9VkpJdn74LoYM6WKArqm7wj6KCxtxmsgu1DkOeaa36FlY7+N9m327wrnsUfs+VzVr4uQ3Z5IxcsxrxyuvMXDJR/bGVp9WvsQhbRmPsXMYJNvBapCrZ+zHscFgYZ2wLvNp0sS4opIUscTDUVbjJKY5Mbh6OzkRdlg6XcdwpNmwk1WUIfSyQH4sNhNJnMhmFmczxwLheFVMJX8EHDQOFxQR6rMyGrgUf73hRY4iViuFA6EJHLV9OluswolyOAGrboSSCJP8asoHEqkVR+k06 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On 2024/7/1 14:55, David Hildenbrand wrote: > On 01.07.24 08:47, Baolin Wang wrote: >> CC Barry. >> >> On 2024/6/28 18:49, Bang Li wrote: >>> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >>> anonymous shmem"), we can configure different policies through >>> the multi-size THP sysfs interface for anonymous shmem. But >>> currently "THPeligible" indicates only whether the mapping is >>> eligible for allocating THP-pages as well as the THP is PMD >>> mappable or not for anonymous shmem, we need to support semantics >>> for mTHP with anonymous shmem similar to those for mTHP with >>> anonymous memory. >> >> I did not see a consensus that "THP*" related statistics should contain >> mTHP in previous discussion [1]. >> >> In addition, if we all agree that "THPeligible" should include mTHP >> statistics, you should update the corresponding documentation to keep >> consistency. >> >> [1] >> https://lore.kernel.org/linux-mm/202406262300.iAURISyJ-lkp@intel.com/T/#md7a77056110cebcc2a9b3cd7e4a8d682667f6ba5 >> > > Fortunately, documentation (Documentation/filesystems/proc.rst) says: > > "THPeligible" indicates whether the mapping is eligible for allocating > naturally aligned THP pages of any currently enabled size. 1 if true, 0 > otherwise." > > So that documentation is already pretty clear (we just have to make sure > the other ones are properly documented, for example as raised in reply > to [1]). > Thanks for the clarification. Thanks, Bang