From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54648C433B4 for ; Thu, 13 May 2021 19:57:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6048611C9 for ; Thu, 13 May 2021 19:57:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6048611C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B5196B0036; Thu, 13 May 2021 15:57:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 465BE6B006E; Thu, 13 May 2021 15:57:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DFA06B0070; Thu, 13 May 2021 15:57:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id F0B1C6B0036 for ; Thu, 13 May 2021 15:57:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7E494180442FC for ; Thu, 13 May 2021 19:57:04 +0000 (UTC) X-FDA: 78137266368.10.50F73FC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 9B619A00039A for ; Thu, 13 May 2021 19:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=9ZAZ+z881JDgTJzeQAm+Bs/QG0gxkchxMNdqqahoJwQ=; b=ZRIwz8JsMo8S7kk7JJ2nYXyVn8 i2CmwCoP+e+egCGimcWStyryMxR1DwYJifPYyMcUlVx721k9SSkIDIMItviFvzwcVkkthACsC1QtG maatHXBOERsuuLf62eHRpCIhDw9XI3fXHpqJOCWVbbQWqC1jR74Nnm+LP4sMnhl+4M395djjm2Xj1 2NtwFYxdxD8zBcHtxyRn5U2iU6pgmZG2zsyQdlVRfFEaRxkp6InoHMMXAtCR1rKqkBZMl2I4WF2uM KJH1oX6/hZ2l9jWAl8BXd7ahfQcZ8hSlmNLwMpCTupGwj8ZbBi2vUg6EVYomPDOFMVgl6+BhGGLZ2 GEqAIkXQ==; Received: from c-73-157-219-8.hsd1.or.comcast.net ([73.157.219.8] helo=[10.0.0.253]) by bombadil.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lhHS9-00BUYB-13; Thu, 13 May 2021 19:57:01 +0000 Subject: Re: [PATCH] x86: Define only {pud/pmd}_{set/clear}_huge when usefull To: Christophe Leroy , Andrew Morton , Nicholas Piggin , Mike Kravetz , Mike Rapoport Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linux-mm@kvack.org References: <7fbf1b6bc3e15c07c24fa45278d57064f14c896b.1620930415.git.christophe.leroy@csgroup.eu> From: Randy Dunlap Message-ID: Date: Thu, 13 May 2021 12:56:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <7fbf1b6bc3e15c07c24fa45278d57064f14c896b.1620930415.git.christophe.leroy@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9B619A00039A Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZRIwz8Js; spf=none (imf15.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 55x4d7u4jg9744yjme65gomy1n14kjxw X-HE-Tag: 1620935823-359882 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/13/21 11:27 AM, Christophe Leroy wrote: > When PUD and/or PMD are folded, those functions are useless > and we have a stub in linux/pgtable.h > > Reported-by: Randy Dunlap > Signed-off-by: Christophe Leroy > --- > arch/x86/mm/pgtable.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) WorksForMe. Thanks. Acked-by: Randy Dunlap # build-tested -- ~Randy