From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C20AC433E0 for ; Wed, 12 Aug 2020 06:43:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F3CE20768 for ; Wed, 12 Aug 2020 06:43:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="f0rbBm9B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F3CE20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8319F8D0015; Wed, 12 Aug 2020 02:43:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2158D0001; Wed, 12 Aug 2020 02:43:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F7C38D0015; Wed, 12 Aug 2020 02:43:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 5B4A88D0001 for ; Wed, 12 Aug 2020 02:43:50 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 13D5A8248047 for ; Wed, 12 Aug 2020 06:43:50 +0000 (UTC) X-FDA: 77140976220.24.boy60_410d18e26fe9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id DC7B71A4A0 for ; Wed, 12 Aug 2020 06:43:49 +0000 (UTC) X-HE-Tag: boy60_410d18e26fe9 X-Filterd-Recvd-Size: 5317 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 06:43:49 +0000 (UTC) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07C6WjJ1170814; Wed, 12 Aug 2020 02:43:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=41NMuwmiUwCh/DJ0c8voSQKonpg6IHjOFHHggpKMA/s=; b=f0rbBm9BvMWLUmht2o9tbJy5qT8Tzb+rwhziZBIw4agMLbwlnvefoB0yZor31cGa8fwQ y9yvZilDokhjowDH0P/Azi1NxkcpPpL6BIwcbU6Y/JUDmomKDJ+5KoE8Fhud9NiOrdqe bnpk93nVGzMMcN1gZuAngh/9rIIh+fWrLay9pngAXFaGfCMy5qMq9CV8a8aJSHPVj/3L 1HBZlBzk9c6my/p08b/P1pYxV0VCYdyVeUTzcZoGe4QnK+g61NbKvAQsipf/tCp14qNC nq56SNoCTawSxXugB93EiwtzINQWnMjLn6aHn2OCMA0wzXi0djL3YmRLXCLP8gKrepQ7 wg== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 32t93s0fnu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Aug 2020 02:43:41 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07C6VWix013455; Wed, 12 Aug 2020 06:43:34 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 32skahc3sn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Aug 2020 06:43:34 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07C6hWgr25624866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Aug 2020 06:43:32 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB775A4040; Wed, 12 Aug 2020 06:43:31 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA032A4053; Wed, 12 Aug 2020 06:43:30 +0000 (GMT) Received: from [9.85.71.109] (unknown [9.85.71.109]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 12 Aug 2020 06:43:30 +0000 (GMT) Subject: Re: [PATCH 02/16] debug_vm_pgtable/ppc64: Avoid setting top bits in radom value To: Christophe Leroy , linux-mm@kvack.org, akpm@linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org, Anshuman Khandual References: <20200812063358.369514-1-aneesh.kumar@linux.ibm.com> <20200812063358.369514-2-aneesh.kumar@linux.ibm.com> <24b1e523-e87e-161b-3dc9-60bd11c8f461@csgroup.eu> From: "Aneesh Kumar K.V" Message-ID: Date: Wed, 12 Aug 2020 12:13:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24b1e523-e87e-161b-3dc9-60bd11c8f461@csgroup.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-11_19:2020-08-11,2020-08-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=980 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008120047 X-Rspamd-Queue-Id: DC7B71A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/12/20 12:10 PM, Christophe Leroy wrote: >=20 >=20 > Le 12/08/2020 =C3=A0 08:33, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> ppc64 use bit 62 to indicate a pte entry (_PAGE_PTE). Avoid setting=20 >> that bit in >> random value. >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> =C2=A0 mm/debug_vm_pgtable.c | 5 ++++- >> =C2=A0 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 086309fb9b6f..4c32063a8acf 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -45,9 +45,12 @@ >> =C2=A0=C2=A0 * pxx_clear() because of how dynamic page table folding w= orks on=20 >> s390. So >> =C2=A0=C2=A0 * while loading up the entries do not change the lower 4 = bits. It=20 >> does not >> =C2=A0=C2=A0 * have affect any other platform. >> + * >> + * Also avoid the 62nd bit on ppc64 that is used to mark a pte entry. >> =C2=A0=C2=A0 */ >> =C2=A0 #define S390_MASK_BITS=C2=A0=C2=A0=C2=A0 4 >> -#define RANDOM_ORVALUE=C2=A0=C2=A0=C2=A0 GENMASK(BITS_PER_LONG - 1, S= 390_MASK_BITS) >> +#define PPC_MASK_BITS=C2=A0=C2=A0=C2=A0 2 >> +#define RANDOM_ORVALUE=C2=A0=C2=A0=C2=A0 GENMASK(BITS_PER_LONG - 1 - = PPC_MASK_BITS,=20 >> S390_MASK_BITS) >=20 > Do you mean: >=20 > #define RANDOM_ORVALUE=C2=A0=C2=A0=C2=A0 GENMASK(BITS_PER_LONG - 1, PPC= _MASK_BITS |=20 > S390_MASK_BITS) IIUC GENMASK(hi, low) generate a mask from hi to low bits. Since i want=20 to avoid bit 62, I am forcing it to generate bits from (61, 4) -aneesh