From: David Hildenbrand <david@redhat.com>
To: Shivank Garg <shivankg@amd.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
fengwei.yin@intel.com, bharata@amd.com
Subject: Re: [PATCH V2 1/2] mm/khugepaged: clean up refcount check using folio_expected_ref_count()
Date: Sat, 24 May 2025 23:47:28 +0200 [thread overview]
Message-ID: <d1e9bfec-fdd1-4512-a115-6109d99cbb8a@redhat.com> (raw)
In-Reply-To: <20250523091432.17588-1-shivankg@amd.com>
On 23.05.25 11:14, Shivank Garg wrote:
> Use folio_expected_ref_count() instead of open-coded logic in
> is_refcount_suitable(). This avoids code duplication and improves
> clarity.
>
> Drop is_refcount_suitable() as it is no longer needed.
>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Shivank Garg <shivankg@amd.com>
> ---
Likely we should revert the patches, so we can have the fix in first.
So in this patch here, we would only convert the remaining 2 instances.
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-05-24 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 9:14 [PATCH V2 1/2] mm/khugepaged: clean up refcount check using folio_expected_ref_count() Shivank Garg
2025-05-23 9:14 ` [PATCH V2 2/2] mm/khugepaged: fix race with folio split/free using temporary reference Shivank Garg
2025-05-24 21:48 ` David Hildenbrand
2025-05-24 21:47 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1e9bfec-fdd1-4512-a115-6109d99cbb8a@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bharata@amd.com \
--cc=dev.jain@arm.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shivankg@amd.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).