From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3AB7C54F30 for ; Sat, 24 May 2025 21:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38BC66B0085; Sat, 24 May 2025 17:47:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 364086B0088; Sat, 24 May 2025 17:47:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 252926B0089; Sat, 24 May 2025 17:47:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 060DA6B0085 for ; Sat, 24 May 2025 17:47:36 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4BC33140DE7 for ; Sat, 24 May 2025 21:47:36 +0000 (UTC) X-FDA: 83479138512.13.921CD1B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id D23D5A0007 for ; Sat, 24 May 2025 21:47:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AkInsuGF; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748123254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dM59MTVE6zWH5ynZWQtAqKs0tQQzzUFXrHhL1ezegZQ=; b=u3Om1AsIKv1m/8jA7Mrms2xYKQAj1IehPKcPIoDgl/x4u+h9fdLQwHP5UqvQBAUVY7fq7h 9RxpxY08qESqo/vkluq5F5oP0Y4YEazydeYshQ9yAep6PJ0NcjWjM5PZOYnX5qdh0Sz7Op tP95A0ET67RcK6h54Ca0IO3aHMrheBU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AkInsuGF; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748123254; a=rsa-sha256; cv=none; b=vW1hqdjEq3baCgLyWob4rPgdPwchTZxnRylmv/1UbjjnqKTNlrBq7Q+Gfo6Gd09C4GN633 4WYZMqgAQdzoP+AFydUx2D5pf9GPqI3R2tS6Or5Edi/W8dT/T0O19jlAD+i+Si+W6RUerP 5IIrS+5i0XN7grl6k5D6Fi7WRd4IhNc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748123253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dM59MTVE6zWH5ynZWQtAqKs0tQQzzUFXrHhL1ezegZQ=; b=AkInsuGFh6jLo0rctBCwE6tRBzzuaC6jeyWT1ig3/GOZv0ZgrMw3/H6kLywhW0jMdtgnO5 oHkheJ0CAr4qor7fq2CEH9wRgfVuHHKBXGxCFB53xpAli5IQikLOz1gJoR2fSD+MYwJMa3 0Od9w6tBpySHoAfR+mfnE+4yW4VpbNg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-QI7nu9UTMYWp3vzYjqZGeg-1; Sat, 24 May 2025 17:47:31 -0400 X-MC-Unique: QI7nu9UTMYWp3vzYjqZGeg-1 X-Mimecast-MFC-AGG-ID: QI7nu9UTMYWp3vzYjqZGeg_1748123251 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso6851275e9.0 for ; Sat, 24 May 2025 14:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748123250; x=1748728050; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dM59MTVE6zWH5ynZWQtAqKs0tQQzzUFXrHhL1ezegZQ=; b=d+I8QFRUGSiO4qGjnmE6gP0yLL4GHhHwDNdOmi8i7y7IH2L5nC0qA868WrPGunFFwz tGBSQxUKBrHAYq5wjwFxZzBFBFtjcCcyPLjvZJTYcMAY55NRDhO3w9wx80KXaDwPh9lY rueh6NB6/QcY6Jt7ziBuWvD+yWiwhAiwVRcp6OfRCj9wWMaJZzDoDgyjZ8wHFDIG6M7b Nk15fI686oPAXHBGPVDX1LFz9e16oMUjsXnZlPgoonFzuM8iwDFKryL9Po3YnF01ptxl BoJQ7jA14WXorcDxMLTPUVHBSjiRCEML1NyVdcemzA/Bi0Str36Dc2ATy5RxwwkUjrsr srLA== X-Forwarded-Encrypted: i=1; AJvYcCVbA1QLMTH64gC73D/inWwElcDa+pm3c7fk+jDo3JaDFb4xTaQQyOjWXiJYFi5noLL4JWzj1gxXiw==@kvack.org X-Gm-Message-State: AOJu0YywVp9fzUzcYhEFHtEf/ZffbB0Iro/hA8iE+k9SvB+1JKRYHRD0 zH6ET+0IYmegEoYXlt1huyWTHYLcIzwj1w0XV5vraffosEMxF68UJdG6+aFDCjY98V7EmsHZ+C7 pg7oTtVc/g5GNuvWCYSXfY8iqd3eFbVPTMsXPfscbuvXYDe+slu9B X-Gm-Gg: ASbGncskKSV8vOuh09vtAC/ult/bYYghzKA3tEKANkJtYj2qPFHPIL2xx45prFCLRXS /TZCHOyUFzDE5Q8J+49jGnICiOLdbJwfCWbU7H7IxjtaEUs/xYIYguGZmIggXT4u6XWVq33r0VN icaO0b4pR/Vnv4n+sDaRRg7PYvB6yVneZuoIfxQ0vwBpAcEEsqKXRQF4AhvOouC6j9BeQrw+L8P HbjiQo4iLOfl5vD0MQttIOPni4oGEgyDvRVcUR16t6PJhWFUeRUqoxZmH5xjbcYlcktoO1Km+fM F0/tpSVSZeAhQZ8ntHozpiWMukBzCZr7TCFudTO6eVvdwDql5n9mNX4dy5f/Y+kp7+XaqW/3zD4 pk9SzXDPY8rxCL2zRDTSYM5XPnVmLTr6O6f+Q4rM= X-Received: by 2002:a05:600c:4e0c:b0:442:faa3:fadb with SMTP id 5b1f17b1804b1-44c917f3ea8mr40407745e9.2.1748123250726; Sat, 24 May 2025 14:47:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhz3ABReRg1KZhbwumFG4ihzFiAYNx8s5STm/vsx0UnxfxLXgm24q3SvEs+CVpeu6UeIy5kw== X-Received: by 2002:a05:600c:4e0c:b0:442:faa3:fadb with SMTP id 5b1f17b1804b1-44c917f3ea8mr40407655e9.2.1748123250374; Sat, 24 May 2025 14:47:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:b600:7d6d:5e38:70ec:12c6? (p200300d82f38b6007d6d5e3870ec12c6.dip0.t-ipconnect.de. [2003:d8:2f38:b600:7d6d:5e38:70ec:12c6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4aa2sm193477975e9.21.2025.05.24.14.47.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 May 2025 14:47:29 -0700 (PDT) Message-ID: Date: Sat, 24 May 2025 23:47:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/2] mm/khugepaged: clean up refcount check using folio_expected_ref_count() To: Shivank Garg , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, fengwei.yin@intel.com, bharata@amd.com References: <20250523091432.17588-1-shivankg@amd.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250523091432.17588-1-shivankg@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NHdqartJl5QDBRZ2esOb1FN4b3PH1f1G4MwlPgCwiaw_1748123251 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D23D5A0007 X-Stat-Signature: enocdnddsfnmh63stsho76jkpzp17i4b X-Rspam-User: X-HE-Tag: 1748123253-679013 X-HE-Meta: U2FsdGVkX18p0ljUw0EJQJkzvryRIEjN3HsKxQTo/WUXT3nC8cw6u4RRHxqPpvUhjbDpaNHMXHXGVN+98D9nsbevB8LTbUgvRxdIuyKJAB5hWn8IV8GAIVkw9vvvsS7Z3Dxn+szqpPaqsCGa8HoYQHNGKMoj3q9y7g2r1/SbNJFnG8fG39gUTRbst5SOn9jpY22JtPBJ0T0b/XlpOOphDCSKXJidUQNkJH15tWSlgTU4jy0zlXpBROG2ZYPJF/hPuHppW3H74NMBKo4OzRqp2Qky44dOX01H7htBYiyyw6Qd07A0KUy9o0UFF9O2YlazwwM4Nsz5XXtdDs/ucM0OFQSBJrLtQFxSl5U6ZCSmIQ7wSCcxQRg3ofnuS0cSMlaaV99nDberZ2eu173UCQGVY1LvXypB9pNxbdNNiqbGKfm/epaDsjcrHjgy22keq0Uackcd8ME+CdFL7VGSkGYNKfDAJkZRSx3REZkoIaXQewFYu7t/ozdoKoXgRIzXh/lmPI8aD9PR2l2dB+E3a8LHVPOPhJNb4HlXHsUU/I3It8pBXG6tIRurVhXjepKDPN3b4gLlZEqzZNACW69lKd3l7KzuJB5ZT7xx2ltRMY3NhgbSlFKMBJ2n4QlPAx0p8MVesuJG4R3gQ8LAsGZZAW/BqY9j+MD3w8xDQuX4JsT+cFCb93y5ujcFWbei5YOuO8poOzDCaAsQcqjmPIcIvGCSvfN02Fnp6lHqw9pL8rWY2v3EvQwrLI8+4m8Rm8rW8uz1zkjIMiY5fqbLV+bX5T5ln3sHSRfs+Va54TDXl7AvrfSWFuTjTnI9cLCSZalKEjv5uHCRMqsTZ4NSdASKd9jJ3LTXFMSeBkpgJ1ndmJiO9uP6kE2UXyOiGupjcw6P6H0CT2QNrTFFPHGLhBMp83YCMXkqS3Fq23R20lB5FfT/TJaoHvsk9/RGCkQrbn/5b2OfydgoYJ7rQRF82TVVyq/ 075D85ap 6MOfCSy+BqMhWvPHgY7dXqWb2Mi1jMNDPqx0uYsl5ErHHwkSNYCdQYAJ3+42pQNVKZvdXkBwvd413vLTL/M7vwU+V/IUyTxm12P+CT5/Zr2pcAMPCxUTp4snJnMFhU9MKeEYhyxd3EcnaKBUOgCS9XM/i9s82I0iSgwxZaAMRsOqXs7a4K2UAxnkboLtOH2LeqOdjn5Qpyb93QYlT7BZypvpEDJTAb9eTDS07Xh4Ubdg2zluqPnnwe3xAOCmoKf3emEXrADMkpdJpEZOPziuZ0uQXruLOJlCbDxOBUcV4LDCqYfAE0YXbzDj2A3r8qJ7JEDn3TjV409cKtiH7zwH44i2BkDzqtsSIC0hNOkJZwEwdCs+eQkFm7BWGEpGuUE8M7zxh40SByzEBy6HITRXB5b57SPouaRGSlLfRaF7NqYctuw4VUmu5A5AHTfDXLhC8QX236F9i6JjUGj/BOuv0Q+dvYiEsyfKZxQOE9vVfQhRbnHDSH3ogFgIM2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.05.25 11:14, Shivank Garg wrote: > Use folio_expected_ref_count() instead of open-coded logic in > is_refcount_suitable(). This avoids code duplication and improves > clarity. > > Drop is_refcount_suitable() as it is no longer needed. > > Suggested-by: David Hildenbrand > Signed-off-by: Shivank Garg > --- Likely we should revert the patches, so we can have the fix in first. So in this patch here, we would only convert the remaining 2 instances. Acked-by: David Hildenbrand -- Cheers, David / dhildenb