From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88697ECAAA1 for ; Fri, 9 Sep 2022 11:37:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22FC48D0003; Fri, 9 Sep 2022 07:37:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E10A8D0002; Fri, 9 Sep 2022 07:37:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0812E8D0003; Fri, 9 Sep 2022 07:37:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE0A58D0002 for ; Fri, 9 Sep 2022 07:37:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C2C3A1A0C28 for ; Fri, 9 Sep 2022 11:37:08 +0000 (UTC) X-FDA: 79892345736.17.02A9ABD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 684AC400D5 for ; Fri, 9 Sep 2022 11:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662723427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f81NbfEEf1+GjsVhdmRQYXxmtitfbsq8j6gFgnQBrqo=; b=TtDgxHXd3brGLgaMFn1BOc6ezvNHoOWJajVCrbPq48TNCgHajv2At5dw3Qfs/Etqhnxmxw azSwke5hBQwrfzijgOnmOdjkv0EEwUctDMmLjyRdLQaD34KBQzs8/AIIpUueqot26p7P+V cUYBx+QCTr/yhIpx6Z9eGsJTxwWff7s= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-244-jt4nImvTNHW13kZ6KCkAgQ-1; Fri, 09 Sep 2022 07:37:04 -0400 X-MC-Unique: jt4nImvTNHW13kZ6KCkAgQ-1 Received: by mail-wm1-f71.google.com with SMTP id j22-20020a05600c485600b003a5e4420552so2635044wmo.8 for ; Fri, 09 Sep 2022 04:37:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=f81NbfEEf1+GjsVhdmRQYXxmtitfbsq8j6gFgnQBrqo=; b=qQjLj8vZHlohr/smGsvSGPoGBYUEUvhgMUbvh7i/ZYmgG5cN2Wrp1Qb7RAgp2dXTCm gzellPRFoZdHr0ZCgYXLSPo10rulJRmxSrvDa3xqoVgQC4T3syt1y32p3fnq67PB/3qX yCkb16ajmYuFWEQmnwbXZ4eWITUnqyhxE3xOmmbUOv6WiLG+bqe3X85tECFOMIWWOLI8 zUOLIwPZHuImoCeqewlHORNLmCV5grE+fO7Kj2XJSJQA+WWaw9ME8vglo6NxLUqcCNaY +vjt1cXYaeC3BcFaTWbWfD/H/7aOwzxXICmg9c3BWaNerU5nL3ol2B/er8SnLrZjzfHT iZ3Q== X-Gm-Message-State: ACgBeo1mt6zMzSTqGE6pnTxuesthfkb/NHwKCBYwmcKSDe+P6JFM06ZN h2Egdb+BcnaiwMedvi6hFgO1tMNx9NYfcIhsSR4MTZsgeZBKydlDK7fYdYNS7sQc7bghVbvuoMP Eg7gwcrO8f1A= X-Received: by 2002:a05:600c:216:b0:3a6:60e1:2726 with SMTP id 22-20020a05600c021600b003a660e12726mr4956990wmi.182.1662723423142; Fri, 09 Sep 2022 04:37:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR4IC6GYPzJeHHs7qdQyJ8giBvMIBwMkEOoEec1/ZAwHrSN1UuFqOR70IDWzKzC+W6+sE9qpgA== X-Received: by 2002:a05:600c:216:b0:3a6:60e1:2726 with SMTP id 22-20020a05600c021600b003a660e12726mr4956973wmi.182.1662723422848; Fri, 09 Sep 2022 04:37:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id f10-20020a05600c4e8a00b003b31fc77407sm467994wmq.30.2022.09.09.04.37.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:37:02 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 13:37:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 14/16] mm/page_alloc: use costly_order in WARN_ON_ONCE_GFP() To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-15-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-15-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662723428; a=rsa-sha256; cv=none; b=WElwMQwVwUMufCXdetAH6CUdA9pw232LI2GYoA+iCppbrQ1b8pudy40kJByMRbkOONJGBH y4h1focx0Myr50i282iqHQvWCn6v7Je34Qp+sFVw2Tpv4BSAZ+XA6YG1MdOalQ4pab3Mqh yWcBu4aJa5d8gIBzoQ4BWHsJIWkQ0b8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TtDgxHXd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662723428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f81NbfEEf1+GjsVhdmRQYXxmtitfbsq8j6gFgnQBrqo=; b=28KGGMhsmsilQzb9KfM1AMKPC+LFUubvxMvLCfzQY2DujezKiIDA28E2dbYpz9BSw1NkSi WN975N+y4JOr8wHbfCV77Bs7nvxt9eZE1UCmOaXAGRpdrsHI7H6x/IyB6SqqOB+eCzTZ0/ BkZMTY1nFWs6cBG8g6Ks3fGVIvJmFb8= X-Stat-Signature: kwfcc6x1ijhgr9j31akmjdjdq6joyy98 X-Rspamd-Queue-Id: 684AC400D5 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TtDgxHXd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam12 X-HE-Tag: 1662723428-729094 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > There's no need to check whether order > PAGE_ALLOC_COSTLY_ORDER again. > Minor readability improvement. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 63ad25e86010..262e8972e019 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5272,7 +5272,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > * so that we can identify them and convert them to something > * else. > */ > - WARN_ON_ONCE_GFP(order > PAGE_ALLOC_COSTLY_ORDER, gfp_mask); > + WARN_ON_ONCE_GFP(costly_order, gfp_mask); > > /* > * Help non-failing allocations by giving them access to memory Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb