Re: [PATCH 7.2 v2 08/12] mm/huge_memory: remove folio split check for READ_ONLY_THP_FOR_FS

Zi Yan
2026-04-13T20:47:21Z

On 13 Apr 2026, at 16:41, Matthew Wilcox wrote:

> On Mon, Apr 13, 2026 at 03:20:26PM -0400, Zi Yan wrote:
>> + /* order-1 is not supported for anonymous THP. */
>
> It's also not supported for file folios, right? Or do we just skip
> adding order-1 file folios to the deferred split list? Either way,

order <= 1 folios are not added to deferred split list. See
deferred_split_folio().

IIUC, we have order-1 file folios but not order-1 anon folios.

> we need to correct _something_, whether it's the code or the comment.
>
>> + if (folio_test_anon(folio) && new_order == 1)
>> + return -EINVAL;

Best Regards,
Yan, Zi