From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861FAC021B1 for ; Thu, 20 Feb 2025 18:07:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8371280300; Thu, 20 Feb 2025 13:07:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E333C2802C1; Thu, 20 Feb 2025 13:07:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D216F280300; Thu, 20 Feb 2025 13:07:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B6AF52802C1 for ; Thu, 20 Feb 2025 13:07:00 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 434C11CCCF4 for ; Thu, 20 Feb 2025 18:07:00 +0000 (UTC) X-FDA: 83141104200.04.9917F77 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 09CD01A001E for ; Thu, 20 Feb 2025 18:06:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740074818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nP0mMHtTUB3tvdIXsfKBFWBuxEKru7wL1tKkcKgOFd4=; b=M6hog+FAoq6Q8lJBlhxQZVA/MbhYMzYZcOyeKIr+IvtoKYj6fLpQm+PmvXLIVWzagqBAvK iGqG0niPaRRuI+qLJUb87d8TEq6K60BDPyI5RYInM+G8kEWZIh4w1o81jCy6f+j5Kq5RN+ mosJS614NNoRy7d5QZzKGY3biFdnGJA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740074818; a=rsa-sha256; cv=none; b=dZephZ2+XWIeexie3xNSa7O1EaYDex4Yr+SVZEIQwRANjeNAO93Y9PeYtdO/zaKYdCKAuc RJ9aq6jbTTpmWmziaAcuAu9zqkSfFOqKOPDOfEWNCnYFExAsNPBCn0bY+pf7NeWwCV3l0o 7uVsru4mSc3+znEejrU/TsaEnRaiLSU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFB8216F3; Thu, 20 Feb 2025 10:07:14 -0800 (PST) Received: from [10.163.39.71] (unknown [10.163.39.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4F5D23F59E; Thu, 20 Feb 2025 10:06:54 -0800 (PST) Message-ID: Date: Thu, 20 Feb 2025 23:36:50 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available To: Brendan Jackman , Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> <20250220-mm-selftests-v1-3-9bbf57d64463@google.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250220-mm-selftests-v1-3-9bbf57d64463@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 09CD01A001E X-Rspamd-Server: rspam07 X-Stat-Signature: x1aoth38g9kuirqf1xwxd37nnjg7pm5k X-HE-Tag: 1740074817-335147 X-HE-Meta: U2FsdGVkX18sIhaPBsuDRVKTRJnmcsGEZ5BblhWhh5ff/GLU0x9+oewjHfEV+FYobwtUuf3S6H7JC2X/SI+tXf3S07nBEH5OU/opAjgZU9JJIUyBFIj9iHE4HehFeVDa9YFjM42UImCFWIgSKvndbxmaBjbTBRBJBkFrqR6OncnY0DuzyAKOeg8P7duqPZanyffs/jHqtcAKDKDiUGzteufwP9XbUkjukmO9+hK+QuYY4r3FbJGd21BwYDSz2Yie7R0kivydBmYne4Pto+Sgm40zpV1fQeNNGto7W8kZHm3vO3ZXVSDW2HdIsF5g7BI07Se0z6RWe+DblfJEz9g7aOqQhm+qobSNZ6IxyqD7i4xlVn49m8GE1pXOgjm8q+5BuunHvXJlxUQ44ZH7rAe2Nk/tQzClmKg/ErxteQXU6NriEqOuRo6bvkywLsyzCr6DuHn/hkxddfnrQvkbtzYek0/JVBLLbfYURnpuVbEpi/UCT+mPdJbnsIJOIiUDEEuYmqm0QkYaOAOEJv+FL2kvpmGhMNPMVIiMlX3wbrW0Bg4gzZ2xCgPdG+ZSRAqRh24QTt/PGql6SmmjiSlW86NEmJRF7i+MhwJeUz2J0E+QhVF2hQPtuaZZz7JJXn9CW58gkf8+8IuwuKXme/4obkz7DDKLtNvMrV691lhGkl9BHnsTVS1ZaV6yHHhJwx20weFXBo7dsJxc1+G9bLzR7qIJidHR+UrDHeNOELgGFASG9akc7ZCDC5jOolSxCcxyP1Dl85efLTj3hCjSnWNPvfnx3yikpStLzwknypDA1ysPBqf0VObjr//lbZbaBtqSPRRlqBeGPE0/du1I2V3ZLCaV7XgAd8PRVCF+DQeru6JX8a6dFfONW6BMxKCcrDNd28bdyAi1Z9GzxUDPlDXqoWPhWkTSNAjq1oHxMEzaaw2EldonQrbY1p1+snMgBmvHyybKyRUxRtbL+yeAB6dJp3m uhbwdmJK gm5vnrCKYgDR9W6qjOTmpITHJef5VArpWOqbWm9uMXV8K92olHE9Fj8hDMzeM33nhOTj522xOIKs5bH1xfpoLtSRGas7Q3zI1RGS8d8xqLZdYQJbIraRdpIyOJndcTjRBMC8zwldgE/WMfiXQ5BPtrCwdAO6R8YFbEWxG X-Bogosity: Ham, tests=bogofilter, spamicity=0.035949, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/02/25 8:33 pm, Brendan Jackman wrote: > It's pretty obvious that the test wouldn't work if you don't have the > feature enabled. But, it's still useful to SKIP instead of failing so > the reader can immediately tell that this is the reason why. > > Signed-off-by: Brendan Jackman > --- > tools/testing/selftests/mm/uffd-stress.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c > index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..db5366b4766e5bfa2d1150d2f3c2d32469a6e28b 100644 > --- a/tools/testing/selftests/mm/uffd-stress.c > +++ b/tools/testing/selftests/mm/uffd-stress.c > @@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type) > * feature. > */ > > - if (uffd_get_features(&features)) > - err("failed to get available features"); > + if (uffd_get_features(&features) && errno == ENOENT) > + ksft_exit_skip("failed to get avialable features (%d)\n", errno); > s/avialable/available > test_uffdio_wp = test_uffdio_wp && > (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); >