From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: kernel test robot <oliver.sang@intel.com>,
"Harry Yoo (Oracle)" <harry@kernel.org>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Hao Li <hao.li@linux.dev>,
linux-mm@kvack.org
Subject: Re: [linux-next:master] [mm, slab] 298cdbf5f7: will-it-scale.per_process_ops 6.3% regression
Date: Thu, 14 May 2026 18:02:59 +0200 [thread overview]
Message-ID: <d28b4a2f-501a-45dc-8589-acc41633e2e3@kernel.org> (raw)
In-Reply-To: <eda98e7b-67fd-4a36-9d39-3de26827599b@kernel.org>
On 5/14/26 18:00, Vlastimil Babka (SUSE) wrote:
> On 5/14/26 16:45, Vlastimil Babka (SUSE) wrote:
>> On 5/11/26 16:45, kernel test robot wrote:
>>>
>>>
>>> Hello,
>>>
>>> kernel test robot noticed a 6.3% regression of will-it-scale.per_process_ops on:
>>
>> Yay for an optimization that was supposed to have no tradeoffs :)
>
> Does this help? I don't expect much, but perhaps...
And a separate measurement with this on top of the previous one, plase?
It's just that __slab_free() would have been adding to tail so let's try it
too.
From 8fba1377797478a945d97ad6163021d95ac7665c Mon Sep 17 00:00:00 2001
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Date: Thu, 14 May 2026 18:00:52 +0200
Subject: [PATCH] mm, slab: ADD_TO_TAIL in __refill_objects_node
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 0cc6c88f11e3..35e574e94538 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -7193,7 +7193,7 @@ __refill_objects_node(struct kmem_cache *s, void **p, gfp_t gfp, unsigned int mi
list_for_each_entry_safe(slab, slab2, &pc.slabs, slab_list) {
list_del(&slab->slab_list);
- add_partial(n, slab, ADD_TO_HEAD);
+ add_partial(n, slab, ADD_TO_TAIL);
}
spin_unlock_irqrestore(&n->list_lock, flags);
--
2.54.0
prev parent reply other threads:[~2026-05-14 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 14:45 [linux-next:master] [mm, slab] 298cdbf5f7: will-it-scale.per_process_ops 6.3% regression kernel test robot
2026-05-14 14:45 ` Vlastimil Babka (SUSE)
2026-05-14 16:00 ` Vlastimil Babka (SUSE)
2026-05-14 16:02 ` Vlastimil Babka (SUSE) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d28b4a2f-501a-45dc-8589-acc41633e2e3@kernel.org \
--to=vbabka@kernel.org \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox