From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E5DC64ED8 for ; Mon, 27 Feb 2023 19:19:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6591E6B0071; Mon, 27 Feb 2023 14:19:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 609806B0075; Mon, 27 Feb 2023 14:19:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AA376B0078; Mon, 27 Feb 2023 14:19:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3B1016B0071 for ; Mon, 27 Feb 2023 14:19:24 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E96AAA85B7 for ; Mon, 27 Feb 2023 19:19:23 +0000 (UTC) X-FDA: 80514035406.29.8884735 Received: from mx0b-00190b01.pphosted.com (mx0b-00190b01.pphosted.com [67.231.157.127]) by imf10.hostedemail.com (Postfix) with ESMTP id 7889BC001F for ; Mon, 27 Feb 2023 19:19:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=akamai.com header.s=jan2016.eng header.b=WvAiqT2Y; spf=pass (imf10.hostedemail.com: domain of johunt@akamai.com designates 67.231.157.127 as permitted sender) smtp.mailfrom=johunt@akamai.com; dmarc=pass (policy=quarantine) header.from=akamai.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677525561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iNZObedCDsicuc2RfqyypFc9Ojp32ItF8uvq9uf+1Ek=; b=2Y0CyBcEjgYAP7g/4YCkOm4QSvU4EaAzA4Mmro6IHHEWSw2aos52qDph0MZgKAl93oVsI0 CMJa9UhsRss0RBf6HL0Xb+4QMBCjYlNzRFjiqf6Cr/ndBfC+/og1CJQq7tJQuLAHO/eWbk tTrsBqWs6V6bVlnDGpcBg5Spwb+u614= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=akamai.com header.s=jan2016.eng header.b=WvAiqT2Y; spf=pass (imf10.hostedemail.com: domain of johunt@akamai.com designates 67.231.157.127 as permitted sender) smtp.mailfrom=johunt@akamai.com; dmarc=pass (policy=quarantine) header.from=akamai.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677525561; a=rsa-sha256; cv=none; b=5hGwL9pakVvRMgrUVwDFdkYHGvftZcg6UIc/DiWESntssEZMOchrzYnYpo4jog8Ydpznzp jdkH/b9wJfkRZgFAAwhaF+lOjl2MWrooPAI7HoYSG2MTvG2e3teztn5AW1JyO7SkXkqdDW p2Eb80kwWyjrCvTduvmSVe2TkJB3dXw= Received: from pps.filterd (m0122330.ppops.net [127.0.0.1]) by mx0b-00190b01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31RFMoe7026665; Mon, 27 Feb 2023 19:19:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=jan2016.eng; bh=iNZObedCDsicuc2RfqyypFc9Ojp32ItF8uvq9uf+1Ek=; b=WvAiqT2YYSm7CmxLnsBGeKlqUNZ7D2YpLub1H+CE4PT3zun54zJx8BLXc1TYo5X2qyqm XbbW0CMP/DMmQR4Ph9zkpPQ/hgJE6bd2nnCFqwT68WVn/erj/7wKGxm298xDcU5PSzUk GxC+34OQkTgBI/LhS/0hFiLpA5/LnWvZYyVIGGKK+IYY4u7aSnq48bCNbzVO3MXEqokP szzi+ZhVsoPnsnNYpmvuqywDwv49jwmVvgsNGlm0MU2JfyFXMxGN0UBV2r2iAAP4QPzV 8SrGrM41wv5GUwqnHCUOdCSX09oWgVMFW0q69KrVhYIkui+MzosgxyXZbR06KnNY/jhI tg== Received: from prod-mail-ppoint1 (prod-mail-ppoint1.akamai.com [184.51.33.18] (may be forged)) by mx0b-00190b01.pphosted.com (PPS) with ESMTPS id 3nyav64t5t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Feb 2023 19:19:06 +0000 Received: from pps.filterd (prod-mail-ppoint1.akamai.com [127.0.0.1]) by prod-mail-ppoint1.akamai.com (8.17.1.19/8.17.1.19) with ESMTP id 31RFVMJ4028605; Mon, 27 Feb 2023 14:19:05 -0500 Received: from prod-mail-relay10.akamai.com ([172.27.118.251]) by prod-mail-ppoint1.akamai.com (PPS) with ESMTP id 3nyej3tmrt-1; Mon, 27 Feb 2023 14:19:04 -0500 Received: from [100.64.0.1] (prod-aoa-dallas2clt14.dfw02.corp.akamai.com [172.27.166.123]) by prod-mail-relay10.akamai.com (Postfix) with ESMTP id 0B27C544EA; Mon, 27 Feb 2023 19:19:00 +0000 (GMT) Message-ID: Date: Mon, 27 Feb 2023 11:19:00 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] psi: reduce min window size to 50ms Content-Language: en-US To: Suren Baghdasaryan , Michal Hocko Cc: Sudarshan Rajagopalan , David Hildenbrand , Johannes Weiner , Mike Rapoport , Oscar Salvador , Anshuman Khandual , mark.rutland@arm.com, will@kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Trilok Soni , Sukadev Bhattiprolu , Srivatsa Vaddagiri , Patrick Daly References: <15cd8816-b474-0535-d854-41982d3bbe5c@quicinc.com> <82406da2-799e-f0b4-bce0-7d47486030d4@quicinc.com> From: Josh Hunt In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-27_15,2023-02-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 mlxlogscore=741 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302270150 X-Proofpoint-ORIG-GUID: xJN1buAQh7I4_vaGy36yr7IrfGhVkiF3 X-Proofpoint-GUID: xJN1buAQh7I4_vaGy36yr7IrfGhVkiF3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-27_16,2023-02-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxlogscore=717 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 priorityscore=1501 clxscore=1011 adultscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302270152 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 44s97t8fdkaetjrnowwzndkipwcz6aej X-Rspamd-Queue-Id: 7889BC001F X-HE-Tag: 1677525561-155031 X-HE-Meta: U2FsdGVkX1/pDfZFhOFvKkc8uJfl5m9RJYWskIV9AthvkBiFvxqcd/qfIoUNtcRdUSqqS6F8aBesDWQU6bRB39GFRzJoB2PI0kDafnSsurxZKy0NebsZGvSez1TaePl/HfV7AJGoOkP/d53QAFyM0c1sK9gLx42jHthnpdrm+NNP+NFYsPkV5ba1WUMlfdHpqAUrQUjTjwRaj7NlnCCyxQO2uSGXoxT5clbBeSgei+S92GZuUS5nN1fAnJT28yHnZ/cepRWbYZeRNvi71B5fMchozX4zQr2s2M2ku/O6LtoJrSV0lJfjo4+26AIjJ9Zb24djMHSq9cRzCX0Y5z9rkjcncfzU7n4FHaHTwICaZ/QRo7OyhHhMzQja8C8EDewzsWZz6hARIglQL0sNLdrqYck35cFFPVBnLYem/Rw6QgIxOMIBNBhIzkEk5bSBQCwGGxugjEcEaL6sOwObSenePSiQFGX+vmkSRQ2OiPm37Unh50iKEj+iKNZDV7LrVMsF/+h0w6i1jzG3wkR1akDl9GStKpB4kvrBKHzl5qwuDQ/ebxSh9pzyxBhgA/Rt/e9O53UFNWzFFJ3KuUff/6S1wcmmHj5lAIDl50qBEgVtg5lz89XnjSGOlQPYGkAuDQ9UE7P348yuf7p8gZRkXQc+98Kes0bsz1A8M2Y6+eqETjbKTlxZGxvsnvnl70/Lj5Oio1G9rIqbGSTdz/PQNfjKTSt1ism6exxASWxph76/YEcDsaYu7+J3+5ypi1ulxvR2cg8PV6EVE+AcJJkc6AloMzSWSEQNnl6MvlLr7ml0o6K6s96WOFYJwiZ+1ddwAzYQ+GcdA+eZHXGsE8J41mvuJSQZ2J4L7ELzUfbGFnOaUj6LXpuU/AfAemgOzdYnWijjdy1W5NvhW2xRmFLWpIMOMh8v9P8KrTmj6+TlSTnxml8XNvvVeY/r88CmhTXMMXhFj4TsAdADgnXttKmIIlD 1eYOEHP3 nwTHbk3ciLeH+l5RiQlpaaZtlHmNxDoTgwq+AWvEwERv48RYoADB8aukEEo9NSLBvU2kuQ1/cQTdaNhd/9jllfAaDb0OPGJ9nGuCPWibZ9z70yGjLbwH6cKNZ6HuFGPdXIdSqc4ytDlFVlrOvAwqGa8Th/quYotyr1h+vAm+nF2m2kxcIiHuEfGomZegupY1GAA+K0d1F4FhKc3Nk/IcO4QSUSA5Rm58SYIZ896ZhSpN0F9hecWFGkh7aYHMHV+vIEO+lo7hNoqTjIvQJhBqZRJUkM3T3pTDwDuhYeD+O/vZYkwjs2WUtaO/HZTG6ND8hgdkrwSIfZ9JGl2vCu85ZJfZ9RDZoGgfKuOZ24BWNw9QVVjMJNlOeC3YWP9ERw6csjJhwiz1fKmqwzS70VVhz6Lt5QLKpLjBqShYUQT2jMS0b8M5DyKCJ+uk+QyLbtYX313+SFiAxXrNKipI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/27/23 9:49 AM, Suren Baghdasaryan wrote: > On Mon, Feb 27, 2023 at 5:34 AM Michal Hocko wrote: >> >> On Fri 24-02-23 13:07:57, Suren Baghdasaryan wrote: >>> On Fri, Feb 24, 2023 at 4:47 AM Michal Hocko wrote: >>>> >>>> On Tue 14-02-23 11:34:30, Suren Baghdasaryan wrote: >>>> [...] >>>>> Your suggestion to have this limit configurable sounds like obvious >>>>> solution. I would like to get some opinions from other maintainers. >>>>> Johannes, WDYT? CC'ing Michal to chime in as well since this is mostly >>>>> related to memory stalls. >>>> >>>> I do not think that making this configurable helps much. Many users will >>>> be bound to distribution config and also it would be hard to experiment >>>> with a recompile cycle every time. This seems just too impractical. >>>> >>>> Is there any reason why we shouldn't allow any timeout? Shorter >>>> timeouts could be restricted to a priviledged context to avoid an easy >>>> way to swamp system by too frequent polling. >>> >>> Hmm, ok. Maybe then we just ensure that only privileged users can set >>> triggers and remove the min limit (use a >0 check)? >> >> This could break existing userspace which is not privileged. I would >> just go with CAP_SYS_NICE or similar with small (sub min) timeouts. > > Yeah, that's what I meant. /proc/pressure/* files already check for > CAP_SYS_RESOURCE > (https://urldefense.com/v3/__https://elixir.bootlin.com/linux/latest/source/kernel/sched/psi.c*L1440__;Iw!!GjvTz_vk!WtI61poYlZk9kg5P1sX19RdYnUNGvBJRjnOpu8hL6IOZ_NKhuw2qZ_tAdNRwzZoQVlO4jEObYN6x$ ) > but per-cgroup pressure files do not have this check. I think the > original patch which added this check > (https://urldefense.com/v3/__https://lore.kernel.org/all/20210402025833.27599-1-johunt@akamai.com/__;!!GjvTz_vk!WtI61poYlZk9kg5P1sX19RdYnUNGvBJRjnOpu8hL6IOZ_NKhuw2qZ_tAdNRwzZoQVlO4jAVqIVDv$ ) > missed the cgroup ones. This should be easy to add but I wonder if > that was left that way intentionally. > > CC'ing the author. Josh, Johannes is that inconsistency between system > pressure files and cgroup-specific ones intentional? Can we change > them all to check for CAP_SYS_RESOURCE? No, this was just an oversight in the original patch at least from my end, and did not come up during code review. Fine with me to change them all to use CAP_SYS_RESOURCE. Josh > >> >>>> Btw. it seems that there is is only a limit on a single trigger per fd >>>> but no limits per user so it doesn't sound too hard to end up with too >>>> much polling even with a larger timeouts. To me it seems like we need to >>>> contain the polling thread to be bound by the cpu controller. >>> >>> Hmm. We have one "psimon" thread per cgroup (+1 system-level one) and >>> poll_min_period for each thread is chosen as the min() of polling >>> periods between triggers created in that group. So, a bad trigger that >>> causes overly aggressive polling and polling thread being throttled, >>> might affect other triggers in that cgroup. >> >> Yes, and why that would be a problem? > > If unprivileged processes are allowed to add new triggers then a > malicious process can add a bad trigger and affect other legit > processes. That sounds like a problem to me. > Thanks, > Suren. > >> -- >> Michal Hocko >> SUSE Labs