From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8DAAC433DB for ; Fri, 19 Mar 2021 19:24:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41FAC61962 for ; Fri, 19 Mar 2021 19:24:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41FAC61962 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C7BD66B006E; Fri, 19 Mar 2021 15:24:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2A806B0070; Fri, 19 Mar 2021 15:24:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACC686B0071; Fri, 19 Mar 2021 15:24:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 8EE236B006E for ; Fri, 19 Mar 2021 15:24:39 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 56A78AF80 for ; Fri, 19 Mar 2021 19:24:39 +0000 (UTC) X-FDA: 77937600678.38.D71AF46 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 2F60F900073D for ; Fri, 19 Mar 2021 19:24:11 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id o10so11670191lfb.9 for ; Fri, 19 Mar 2021 12:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vi3OhCV5xHRkQ6K9sU0vs2DTIjIbNhVBKwX3Itgewtw=; b=Y3anoUmzvmht5ZeuS0K6pBMLsHIyBTiT+FQokPOsvcNHziSdnJEQ8yslfdisJ5QOsa vXMDxQliBqYnos7M/g2MR9lXqjifBxNXgBdDr/irEv/ELG9pGPn0QuMbCATBToqI2iSj 5R0GdQfAr6f/2/47cD+v2zcedeKJA3tdhD+OyZQSCeq+Li6RyP/aljJGff2T0H9a1kNP y9f9BbBxCyR4JTz1ikuQ0zzOpICj6Q2vMRMmPdOUdVa31yjL7ybMAMkmP3O8+eAyNo/E BWAKNQcJqiI3n6Bhu8um3h/HiqARF9SKKJvlaf+44jk7ZT7BG115og8ZOrjkhRp5Y5Y0 0pmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vi3OhCV5xHRkQ6K9sU0vs2DTIjIbNhVBKwX3Itgewtw=; b=px28cC5jZRd+TXLSBAbJVyyCnZAfIzokWqCrjYZ+gH3aIyw/d/DeEHejemamdx3fjz 4hwp1ZxYnv4H476zOQJ9BVlK+VTgMLbFz0dR3PuyYKqSeDvZiCcY9hDX3cb9+l81jrPE S8ihknVv261O91s/IkUBKEqyEvEhDTiMhJq3+mP/ERz81aiyqQd5ts/61u/rI68rR07j iKLuXAZn8gISQS3UDOC8d4Yj+hEoAPxVpskDm+QrFrf8JqqoPlI89NCWs4MBIN6ul8J6 yBobkkOsWkGosZnmvphY0d+1mEDV46iCy//GwocS6eH4KMI3Njn4ioQX7/YrdIQoLrOV OsMw== X-Gm-Message-State: AOAM531L2BkGL37/z25FF3IOFakPDe27zeCddjeaG6K/b3OUH8o7umu9 od0uYhw+1DEZAL+9ozaNX/Y= X-Google-Smtp-Source: ABdhPJwoyZSYjPu1c0Oe6ptKGdXXh2aNrlgJjHcwn6gXUsZP2xz3qT6czKotdtD5qUipYg6HbRl99w== X-Received: by 2002:a19:40c7:: with SMTP id n190mr1689219lfa.378.1616181844579; Fri, 19 Mar 2021 12:24:04 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id m24sm717293lfq.184.2021.03.19.12.24.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 12:24:04 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Minchan Kim , Greg Kroah-Hartman Cc: Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <071c6681-f492-2c94-5686-30c30778f39d@gmail.com> <007c0317-8819-a6b8-fdff-c0b5899c4f51@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 19 Mar 2021 22:24:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: 8kagxhdte1zz65yqpipi99y4n1yxk358 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2F60F900073D Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mail-lf1-f51.google.com; client-ip=209.85.167.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616181851-653642 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 22:03, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Fri, Mar 19, 2021 at 09:48:11PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 21:21, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> On Fri, Mar 19, 2021 at 08:56:06PM +0300, Dmitry Osipenko wrote: >>>> 19.03.2021 19:30, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>> +static void cma_kobj_release(struct kobject *kobj) >>>>> +{ >>>>> + struct cma_kobject *cma_kobj =3D container_of(kobj, struct cma_ko= bject, kobj); >>>>> + >>>>> + kfree(cma_kobj); >>>>> +} >>>> >>>> Oh, wait.. I think this kfree wrong since cma_kobj belongs to the ar= ray. >>> >>> Oh, good spot. Let me use kzalloc. >>> >> >> Thinking a bit more about this.. it looks like actually it should be >> better to get back to the older variant of cma_stat, but allocate at t= he >> time of CMA initialization, rather than at the time of sysfs >> initialization. Then the cma_stat will be decoupled from the cma struc= t >=20 > IIRC, the problem was slab was not initiaized at CMA init point. > That's why I liked your suggestion. Alright, if CMA init time is a problem, then the recent variant should be okay. >> and cma_stat will be a self-contained object. >=20 > Yeah, self-contained is better but it's already weird to > have differnt lifetime for one object since CMA object > never die, technically. >=20 Indeed. I found the Greg's original argument and not sure that it's really worthwhile to worry about the copycats since this is not a driver's code.= . Maybe we could just add a clarifying comment for the kobj, telling why it's okay for CMA. Greg, doesn't it sound like a good compromise to you?