From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164B7C47088 for ; Mon, 5 Dec 2022 14:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63C4B8E0002; Mon, 5 Dec 2022 09:43:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C51D8E0001; Mon, 5 Dec 2022 09:43:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440B18E0002; Mon, 5 Dec 2022 09:43:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 344C68E0001 for ; Mon, 5 Dec 2022 09:43:01 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C65AE1A0120 for ; Mon, 5 Dec 2022 14:43:00 +0000 (UTC) X-FDA: 80208519720.24.1643944 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 6ADFA40014 for ; Mon, 5 Dec 2022 14:42:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WrIiSmH1; spf=pass (imf27.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670251379; a=rsa-sha256; cv=none; b=O6+Yqh4rLFMgMYXcqLgs6/PpgqqQVK3ynUfLn0Wzux4qc4vAMuxvx1D3vzXeggcjEtDLx9 6zxd/82UsFYSnfJCXPZb4igU1YhDEDVNX2qRsmg6u7zghP7c24/Zo8spBRAKrfrvWo7zmY YRhGZw4o506v7H3Zw4UzzKSi8cehr3A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WrIiSmH1; spf=pass (imf27.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670251379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eM4zhW3ULwVjqLAlsN3191N8vcp7iRGoi/osZC3zlYo=; b=KnhpxRzo07MoqkOcy77kPuaT7uL6jf8b70uRVtQxGsU5sUiw6eqxCbAK/J9JmpkpLi04qB +BJCVAiSTBDKfto3CIBXsutwFydgtkFpNw1u5Oh2DFTqGS/giKzlIJFQkqW89nH4X7vpQe wROzNiaPZniCjfATgkFNbCqFNwACRDo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670251378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eM4zhW3ULwVjqLAlsN3191N8vcp7iRGoi/osZC3zlYo=; b=WrIiSmH1DHo/meNCKlX4BtOGwEcOyPRzsFHy+qCuAiMigTHWklfAAJwBkjRImzK8wg6dXs UHpcsYAdmn6Ncdk9jgVsGhp5Lz8ycJ/SVZxEpAY642K5i7OPdX3ow7OTRldtw6Ff1Zt2DS 8Te2YZIx6HUjHbB2WrI/saTSGT/K4Wg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-658-Zo5apmxeNFeiMCoYMoPHoA-1; Mon, 05 Dec 2022 09:42:57 -0500 X-MC-Unique: Zo5apmxeNFeiMCoYMoPHoA-1 Received: by mail-ej1-f69.google.com with SMTP id ds15-20020a170907724f00b007c0abebc958so7470085ejc.2 for ; Mon, 05 Dec 2022 06:42:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:cc:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eM4zhW3ULwVjqLAlsN3191N8vcp7iRGoi/osZC3zlYo=; b=4xZFhwBjoAOBS1Qm1EZBHxNilpBZjdWx+j2lD7eU4QpBXfhf9iTf23DT6aNzUlTAzx eSL8gAYPQpcz+eCF9OQWa8e58/IW6pdx+xBptf5CjQQOJ1Oga6CeJyDW5MXknGgNJSm1 sRrewcLtADOWKtqcaFDuXGjgY5jqdAhIFFAHM4hYUkVBw1ScaaNI7WIOQoeoYjS9d/bO HzEhuUEBaizs9R9CJlP4eZ8uyYQCEYmKKW3jsPp35FckZgc5glQlJaJEbpXl5/LV7Tw1 t8lpuR9vHihxyM6aqMUp8px0KxZc7NAZ41cAMxSF2QFQu3gTdPAGsqrwwpb2btd8Lx+u sSzg== X-Gm-Message-State: ANoB5pnaOInAgPu4BHbENk8Qk072BMwM0eTKtBdOMAc34KSYWgV5mSM3 gFNu9NLwsR+kNrLyOxvYZHb89FaQeKzoYFkcJGfEAmLJI1LsWKBSW2nHnjwVsgeZ5VpyWP/XRnh /xIrC/Fv+97s= X-Received: by 2002:a17:906:8465:b0:7bd:7253:457a with SMTP id hx5-20020a170906846500b007bd7253457amr15827605ejc.81.1670251376355; Mon, 05 Dec 2022 06:42:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf4TpgWofZbiz5zOuXQYj4T4dx/JXh04G1jvnEp1n0hEwc1mGr5LlvNNsQnNzrMF3YDoEa/80A== X-Received: by 2002:a17:906:8465:b0:7bd:7253:457a with SMTP id hx5-20020a170906846500b007bd7253457amr15827594ejc.81.1670251376112; Mon, 05 Dec 2022 06:42:56 -0800 (PST) Received: from [192.168.41.200] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id ev24-20020a056402541800b0046ab2bd784csm6159784edb.64.2022.12.05.06.42.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 06:42:55 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Mon, 5 Dec 2022 15:42:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/24] netmem: Create new type To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas References: <20221130220803.3657490-1-willy@infradead.org> <20221130220803.3657490-2-willy@infradead.org> In-Reply-To: <20221130220803.3657490-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Spamd-Result: default: False [-2.89 / 9.00]; BAYES_HAM(-5.99)[99.98%]; SORBS_IRL_BL(3.00)[209.85.218.69:received]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[redhat.com:+]; DMARC_POLICY_ALLOW(0.00)[redhat.com,none]; RCPT_COUNT_FIVE(0.00)[6]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; R_DKIM_ALLOW(0.00)[redhat.com:s=mimecast20190719]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:170.10.133.0/24]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 6ADFA40014 X-Rspamd-Server: rspam01 X-Stat-Signature: 3y6mxufg3r38anzbjkpnqq7kzie1awie X-HE-Tag: 1670251379-245041 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30/11/2022 23.07, Matthew Wilcox (Oracle) wrote: > As part of simplifying struct page, create a new netmem type which > mirrors the page_pool members in struct page. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/net/page_pool.h | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index 813c93499f20..af6ff8c302a0 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -50,6 +50,47 @@ > PP_FLAG_DMA_SYNC_DEV |\ > PP_FLAG_PAGE_FRAG) > > +/* page_pool used by netstack */ Can we improve the comment, making in more clear that this netmem struct is mirroring/sharing/using part of struct page? My proposal: /* page_pool used by netstack mirrors/uses members in struct page */ > +struct netmem { > + unsigned long flags; /* Page flags */ > + /** > + * @pp_magic: magic value to avoid recycling non > + * page_pool allocated pages. > + */ > + unsigned long pp_magic; > + struct page_pool *pp; > + unsigned long _pp_mapping_pad; > + unsigned long dma_addr; > + union { > + /** > + * dma_addr_upper: might require a 64-bit > + * value on 32-bit architectures. > + */ > + unsigned long dma_addr_upper; > + /** > + * For frag page support, not supported in > + * 32-bit architectures with 64-bit DMA. > + */ > + atomic_long_t pp_frag_count; > + }; > + atomic_t _mapcount; > + atomic_t _refcount; > +}; > + > +#define NETMEM_MATCH(pg, nm) \ > + static_assert(offsetof(struct page, pg) == offsetof(struct netmem, nm)) > +NETMEM_MATCH(flags, flags); > +NETMEM_MATCH(lru, pp_magic); > +NETMEM_MATCH(pp, pp); > +NETMEM_MATCH(mapping, _pp_mapping_pad); > +NETMEM_MATCH(dma_addr, dma_addr); > +NETMEM_MATCH(dma_addr_upper, dma_addr_upper); > +NETMEM_MATCH(pp_frag_count, pp_frag_count); > +NETMEM_MATCH(_mapcount, _mapcount); > +NETMEM_MATCH(_refcount, _refcount); > +#undef NETMEM_MATCH > +static_assert(sizeof(struct netmem) <= sizeof(struct page)); > + > /* > * Fast allocation side cache array/stack > *