From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32FBFCEFC21 for ; Tue, 8 Oct 2024 15:02:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 812A16B008A; Tue, 8 Oct 2024 11:02:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C2056B008C; Tue, 8 Oct 2024 11:02:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68A4D6B0095; Tue, 8 Oct 2024 11:02:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A3566B008A for ; Tue, 8 Oct 2024 11:02:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0918416041F for ; Tue, 8 Oct 2024 15:02:42 +0000 (UTC) X-FDA: 82650751764.22.D0BB9EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 9741618003B for ; Tue, 8 Oct 2024 15:02:40 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PXkzSw2K; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728399626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0/3OUmyHj9egoKO3W+ad9PiM2e5i+z+vUsEoQ8af/vY=; b=UfbXhwycwtFmgnOsm2RhhjwhmTv2lyw8khYas0Z2QTQn8ktZ18Ao2OWMsuV4DeYMK0LuPW uNdi1q2vdt7DThcpbQdtqhMXFdGDv1XTwyPRdE5lqeQYcBPJGheQRak0Kv4VorVrHyjJ6b 2tv/cFqxJ3lNNNNlw95okLvB3G+t4No= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728399626; a=rsa-sha256; cv=none; b=Ndf92+2FCSZW5zQ0tnXneJNe1eoBLsHX3rSvBq+cKA4prc9fas27lPqEU9eIRnOwu0ZlfM l06J1m0ugVfUfvVEFuIQd4YyhhGuFHZVeoyHEhNk/FEkr5ZdefKKIN56ljPWJd2SxtsC6U 930Ugn/nuVja+6k26QFv9kPAXIWRzFg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PXkzSw2K; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728399759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0/3OUmyHj9egoKO3W+ad9PiM2e5i+z+vUsEoQ8af/vY=; b=PXkzSw2KJkZFYuKS6YpsUso2xYuNr++Yh+FbFp4KRV5kuk8fbzFe+bKC8kIN6yMbUZt+0J 63bpOuOK0rWzpa6e5nsvZU5qRdOjiC5ZyJgba4CXPKrpGZyXDpoyQVUD3w13iVm0kRN3J+ k7ej0MdXjZRRSDS5Dwx8LdtKoftnZ/Q= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-iMnGf-BDPhuzSHGVeWMRug-1; Tue, 08 Oct 2024 11:02:38 -0400 X-MC-Unique: iMnGf-BDPhuzSHGVeWMRug-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42f8ceb8783so25972045e9.1 for ; Tue, 08 Oct 2024 08:02:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728399757; x=1729004557; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0/3OUmyHj9egoKO3W+ad9PiM2e5i+z+vUsEoQ8af/vY=; b=NROMgQQzeDv9vW1aaudswrnMKwQarPkv07A1cz8aKMZ9cfx21m2qjupyU/a4yasSmG JcryhHWRCgS4OkNYin+WOlbmcmoU8r9KSA9X8eJFBwT0761AXlnF6pZzy43oKujEOFnF ku70Kbz19GukArzezREscY6bks/9yUyR9gEynLo+6K+koeEXNNwEfRUrPIzwyrtzwX+I 9XtCeXD5L7mQ3AvsbflTFH6TZlIPwhyZkgWc4ZXH9yrnTw6WB7l3UhLd+qf2R4XKIcgk 5UvblgT6L4LeFLJTKuh89MYJSt9S+uu/ln3n8hj2kVdQDzJFND05t63UKo/9J9Gwd195 V3OA== X-Forwarded-Encrypted: i=1; AJvYcCUw8OTT5slBMQ4YDjlqk2Iz33VVgCDwiMtYbfTBWxLlNQ+bEzxWQ6qx73AmgPf8Eku0QNUeeBiGcg==@kvack.org X-Gm-Message-State: AOJu0YxMiL8lMMntdM4IVg/gZ4AG9q27SsMtEz28biqe2BagA0f/OYaV wU/SjP1Pk6LtwMzHp3RE6ZABLzmPt3iPWkxinRYalkQouMEUv3W2NLuQ2cLjCJgztsC8W/ULOJn ePL93/I3dX+92hvQZ/dqK0LZtl7+UihnqF++psOEHq1aAaR+e X-Received: by 2002:a05:600c:1d05:b0:430:4db0:3fef with SMTP id 5b1f17b1804b1-4304db041b1mr21619765e9.15.1728399757067; Tue, 08 Oct 2024 08:02:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5KfWAEfo13d7LBkIzALwm5EMMzkC+qUYwK/+sE00fwCjhiq2WEKxm9BSVRHrra9a9n2gkyQ== X-Received: by 2002:a05:600c:1d05:b0:430:4db0:3fef with SMTP id 5b1f17b1804b1-4304db041b1mr21618565e9.15.1728399756152; Tue, 08 Oct 2024 08:02:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:c700:a76f:473d:d5cf:25a8? (p200300cbc72fc700a76f473dd5cf25a8.dip0.t-ipconnect.de. [2003:cb:c72f:c700:a76f:473d:d5cf:25a8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86a0a9c9sm129678865e9.3.2024.10.08.08.02.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 08:02:35 -0700 (PDT) Message-ID: Date: Tue, 8 Oct 2024 17:02:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] memory: extern memory_block_size_bytes and set_memory_block_size_order To: Gregory Price Cc: linux-cxl@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, terry.bowman@amd.com, lenb@kernel.org, dave.jiang@intel.com, ira.weiny@intel.com References: <20241008044355.4325-1-gourry@gourry.net> <20241008044355.4325-2-gourry@gourry.net> <039e8c87-c5da-4469-b10e-e57dd5662cff@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9741618003B X-Stat-Signature: aut386hppmz4m3tiawpx67j3rot5mom9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728399760-440084 X-HE-Meta: U2FsdGVkX19ipunhyod+6ayIHXwUDyD56NVki9mByEMCmJ10PoM0o1EsM8giknaGF8BrTCIP5wNsWmTjnm02LTWkxYf3AAn3NBfHewmIuRBHs9qgz6a6zFb+VI95wK13bAtiUutZyIyfGKEPFwx/0GbyoL6TJ2r8IgOBWftRKsXP0nZ4y5JoZ0ny797J/8GoGuS/fATWd6jQqkQogzEhR7ZWLNJqGxJXMlCDAV5FEgvdZMgSB4xbcmZpy15/+mPk5jjCJUhQsRL0N0AyTQMA0hyq18zBKQeU/vbmDwZmIqeEcHc1uu7qqFVjg4mNjlt+uPGqB1k441juZ3pg2yX2l3iqz0z4CI1qnpRTBLrbx8v8X/XhscwHsyoZa+8qfnfn5HupliubdtLGBIoT/hZeBeCPWzmy6bO4FaaUTCf+YQM8P2ztv+yV46Pi2xoA9C3vnzEuSkWmPNPWDKd7s/O0CAO4P1jMr2XcjmQNiNvFvM+xX5au0R1wVxG8cgCp9JHNtYr+nTJbNwU5QrUg3h/229DTQbX8OGf+OCB7SrRQeOcuIeR5Yy3XwcJRd92YHT8TghyhFOQlfM/DWBKFr3Y1r/PevlOBngE602eqrT+9LngAOgy9cgVH0uawiy1McLrHJKfbWwS+/7cduVAmbKlml+5iWz6pbfS7zfKOqZKo4oAGLOCTE9ZpYY297p8nWkDbszSxdbxYRa2yTAR4LuJ/KOAYMYiyofaLaVTgic6mDMYg6RXQMI0DKvcyyenv7qG/XPEPfknLGdrjAStuueQ4fLKx6y1Y1WT42l9i6kfca4Ymb3KI0QyKLhR46qwMf1HKUVRU8ooThCgtB0tyYIbXQfdG7297+e00u+RLvnR0OOIBWkN3yTL8twhw8XKCX75r6m+KRNyz4b785ynrKQT6Kh0LQdso54Se1KgeENNr0LTATwUbwWq2WbHz2nSVtmJVLzxOFCs19hwQJ4YnhOZ n/hsijbM hUn2TliI6e/4h0voyPFFc3kvpc98uhXFEOJbjdjwYzzkI+wY3jFDOHd9Bi+ManEpYt8i8M06AEpLOvvyQSPFBE4TUXYpS5CvQ+MeEH4NobW7a6wam8dCywfmEFEhCojOA+ZkozCTl35GGlh31ChQqHjSBoQ7SnkbKzldwbb9X8A6+5+07vcDp6sOtBsa9jGmi/QH1rmGP/BVYd+YN0jvdbKtqUtPgRWkgEOFCW/OZAXsPntDoSeBXh4mKW4O73hxf4am2m+cquMW6d1KKh1GiX7s/2KCpHO4PwVQ2ApZbk8EUdiiFZqUdMJSyujuXSV1n7uKa5XtQ1r83KVFF01+J01g0S7WN6TRvEB4vEpz4LCTSVOYr8wCSCZcVYg1KK48aI7KcGZkHwnFvBiQaZYwnccHPlPqQyI1Yr7BrUWJEfRfLN1Nw/W+H6Qp1gZ9cM6aXjjxIvjNCwnp9EswYAUBHYD7EH9dZz0Kk2zyEZPZzuhSRfG9lniEUiw2GQSqs8M5g5F5K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.10.24 16:51, Gregory Price wrote: > On Tue, Oct 08, 2024 at 04:03:37PM +0200, David Hildenbrand wrote: >> On 08.10.24 06:43, Gregory Price wrote: >>> On CXL systems, block alignment may be as small as 256MB, which may >>> require a resize of the block size during initialization. This is done >>> in the ACPI driver, so the resize function need to be made available. >>> >>> Presently, only x86 provides the functionality to resize memory >>> block sizes. Wire up a weak stub for set_memory_block_size_order, >>> similar to memory_block_size_bytes, that simply returns -ENODEV. >>> >>> Since set_memory_block_size_order is now extern, we also need to >>> drop the __init macro. >>> >>> Signed-off-by: Gregory Price >>> --- >>> arch/x86/mm/init_64.c | 2 +- >>> drivers/base/memory.c | 6 ++++++ >>> include/linux/memory.h | 4 ++-- >>> 3 files changed, 9 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c >>> index ff253648706f..6086f99449fa 100644 >>> --- a/arch/x86/mm/init_64.c >>> +++ b/arch/x86/mm/init_64.c >>> @@ -1424,7 +1424,7 @@ void mark_rodata_ro(void) >>> /* Adjustable memory block size */ >>> static unsigned long set_memory_block_size; >>> -int __init set_memory_block_size_order(unsigned int order) >>> +int set_memory_block_size_order(unsigned int order) >>> { >>> unsigned long size = 1UL << order; >>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >>> index 67858eeb92ed..f9045642f69e 100644 >>> --- a/drivers/base/memory.c >>> +++ b/drivers/base/memory.c >>> @@ -110,6 +110,12 @@ static void memory_block_release(struct device *dev) >>> kfree(mem); >>> } >>> +int __weak set_memory_block_size_order(unsigned int order) >>> +{ >>> + return -ENODEV; >>> +} >>> +EXPORT_SYMBOL_GPL(set_memory_block_size_order); >> >> I can understand what you are trying to achieve, but letting arbitrary >> modules mess with this sounds like a bad idea. >> > > I suppose the alternative is trying to scan the CEDT from inside each > machine, rather than the ACPI driver? Seems less maintainable. > > I don't entirely disagree with your comment. I hummed and hawwed over > externing this - hence the warning in the x86 machine. > > Open to better answers. Maybe an interface to add more restrictions on the maximum size might be better (instead of setting the size/order, you would impose another upper limit). Just imagine having various users of such an interface .. -- Cheers, David / dhildenb