From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01EBC433EF for ; Wed, 11 May 2022 16:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40BD58D0001; Wed, 11 May 2022 12:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BB096B0082; Wed, 11 May 2022 12:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 282628D0001; Wed, 11 May 2022 12:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 17EF96B0080 for ; Wed, 11 May 2022 12:31:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D622D2FC64 for ; Wed, 11 May 2022 16:31:05 +0000 (UTC) X-FDA: 79454001690.17.C59644C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 7C0F11400A6 for ; Wed, 11 May 2022 16:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652286664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwRUdIGOtIagk3/zZnpGlBztHUulW1Iopy3U8SZNQBg=; b=Gpas8XP23VfbrCSv08MQSlBIIB8ZVdpWuSGqreoR5AAGz3U86aqOxMR4hAH/1BDZzcqP17 dGqOwh9qL8qQvdoJ5kmDr6K5xdTwWkUrjjTIs8SAAgyCWmnzr2Ikol707C5MocIaF36QbF B+MkqFYHDpeU6bzXkCIUqesumF2g2TU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-674-dGDcGnKHOQKPuy-f2opW6A-1; Wed, 11 May 2022 12:31:03 -0400 X-MC-Unique: dGDcGnKHOQKPuy-f2opW6A-1 Received: by mail-wm1-f70.google.com with SMTP id e9-20020a05600c4e4900b00394779649b1so3063503wmq.3 for ; Wed, 11 May 2022 09:31:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=NwRUdIGOtIagk3/zZnpGlBztHUulW1Iopy3U8SZNQBg=; b=gv0yj2ofXuCn6MsiEODkASvhEiH9tDgfzhOoDxl97XRW4nZZzqVsWq29bHmQHQ/MDO QcHTiVJ4INP1rhM4CT/8mItl6O7M9Nom5E3kkKNZoJVmSgh+q9HNTra+hQtk6iu5Zbe8 CSS/HSf+jrel19tbcUIuRKqhlbmcGxcqfl+Xsg80f9ya0gSJ7N+wN02Q4DhQ6+VFR1kE d7Z9Yht/o7pcImiQzRw44JXwJj3VaY5qBjJq3EncEwMH1+f9YxwpT0cxvdTQNVRkv6vj FFkoVDANf3pxnnvDa6+2uF4GtD/U19R9/aDbw5rMUJL70RYOtGAMoMlmRYToG8xSEUzU DWnQ== X-Gm-Message-State: AOAM533mnmvFd5Oy7keocs0VrjaalYWFLhu4SnC2pzkyWleQCqamKzoF 8ugH3B5qs1It2QXXxHXb0tMfcyH96GKGh1Ya1YXmNHArL0CMLhTkSFKPYuaR36AMGYF6s0OAIqb T0A+kmWG77BU= X-Received: by 2002:a05:600c:3515:b0:394:8c7e:fbde with SMTP id h21-20020a05600c351500b003948c7efbdemr5660673wmq.165.1652286662418; Wed, 11 May 2022 09:31:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxBi1Dj04MlOukt9LYl4UqTJT36Sqbp84lQ3YdTyLI0xlWc6yJdnKpgzjmA8uHrQm9JnMgUw== X-Received: by 2002:a05:600c:3515:b0:394:8c7e:fbde with SMTP id h21-20020a05600c351500b003948c7efbdemr5660632wmq.165.1652286662173; Wed, 11 May 2022 09:31:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:700:2393:b0f4:ef08:bd51? (p200300cbc70107002393b0f4ef08bd51.dip0.t-ipconnect.de. [2003:cb:c701:700:2393:b0f4:ef08:bd51]) by smtp.gmail.com with ESMTPSA id o3-20020adfeac3000000b0020c66310845sm2016448wrn.55.2022.05.11.09.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 09:31:00 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 18:30:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v8 06/23] mm/shmem: Handle uffd-wp special pte in page fault handler To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Mike Kravetz , Nadav Amit , Matthew Wilcox , Mike Rapoport , Hugh Dickins , Jerome Glisse , "Kirill A . Shutemov" , Andrea Arcangeli , Andrew Morton , Axel Rasmussen , Alistair Popple References: <20220405014646.13522-1-peterx@redhat.com> <20220405014844.14239-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220405014844.14239-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7C0F11400A6 X-Stat-Signature: msw1q9s6z8mkaak4rn4ux7j36mejtkjr X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Gpas8XP2; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1652286662-829319 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +/* > + * This is actually a page-missing access, but with uffd-wp special pte > + * installed. It means this pte was wr-protected before being unmapped. > + */ > +static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf) > +{ > + /* > + * Just in case there're leftover special ptes even after the region > + * got unregistered - we can simply clear them. We can also do that > + * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp > + * ranges, but it should be more efficient to be done lazily here. > + */ > + if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma))) > + return pte_marker_clear(vmf); What would happen if we do a unregister followed by a register? IMHO we should start with a clean uffd-wp slate then. Your comment makes ma assume that we could receive stale WP events, which would be wrong? -- Thanks, David / dhildenb