From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F70C43460 for ; Mon, 19 Apr 2021 14:18:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC66E611CE for ; Mon, 19 Apr 2021 14:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC66E611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41EC56B006E; Mon, 19 Apr 2021 10:18:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE2B6B0070; Mon, 19 Apr 2021 10:18:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2481A6B0071; Mon, 19 Apr 2021 10:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 093A16B006E for ; Mon, 19 Apr 2021 10:18:44 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AEC45363E for ; Mon, 19 Apr 2021 14:18:43 +0000 (UTC) X-FDA: 78049322526.33.7B72142 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf18.hostedemail.com (Postfix) with ESMTP id DBDF3200026E for ; Mon, 19 Apr 2021 14:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618841922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o3UPUs10GkMYgieyL1I900CWEZM98DXwIwU3+JzhSRs=; b=PjFo8cNCofBk4nyVLDXH2++RscfcagyBPWEWx8MinSChdj1OfARI6n1lBW8BrAWy9gGUMp qfdRNyrLsLsOF+2EWPLiYO6xPtuH8Twf5KGCfhgS/bpBE8SOYKX794dWOFSuyK/DqsabGO /pSie2dnXsTxKKxe0t0nw0ZF88aihmk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-nDu6q824OUa0RL9QjoxOLA-1; Mon, 19 Apr 2021 10:18:40 -0400 X-MC-Unique: nDu6q824OUa0RL9QjoxOLA-1 Received: by mail-wm1-f69.google.com with SMTP id y7-20020a1c4b070000b02901357a988015so915674wma.5 for ; Mon, 19 Apr 2021 07:18:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=o3UPUs10GkMYgieyL1I900CWEZM98DXwIwU3+JzhSRs=; b=mOvfzEg7nFpGSjhfx1ijtR/uVpfGDBsQKvqacK6Jh7H8Me0cBmh/5JzwWXLxHtYVBv aclm8i9/QBu0xCwL6Dbu5sfyXdrAXmI7N2XoStQ8d8bHuW7eO15KzZvvtieQ6zby1p29 hOcJzBZX7mcOxcP9VAy3bKtjzJY3SgmlZBiOhEKsRycKOy8fV25f89TyjDqwxo6+M9MC VJn6rXoxxBMh4o/ASM7Mw3wRDgtRB8HxB0oPIIVx2dO6V/XuoyTS/vOSa+n849AoBd1M uaNc1wldT4bWrnMHw1m9RNeJEX7v9GhtE4hgVuNj8ZJHPP/YYDX0W7zeW1FfSCSGHXyn WEEg== X-Gm-Message-State: AOAM533boQArEl8TcSsjETcad6joE3uJiHi5UXt8b+V0b/SjinZAU6rt /7lXmGYcpItARNuRv2Ja380ZWLkmRRCSZYYDT330GpDsGsQmMknbW9/o6ST4XeWJ4YXA5OTATBW U6j87KAVpd5E= X-Received: by 2002:adf:d1cc:: with SMTP id b12mr15069251wrd.131.1618841919156; Mon, 19 Apr 2021 07:18:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP2SU3QIp/T87kn+Ro2PJ3N/yPo/rwVzL8ua9LA2gCUdGPt11NDG+C7Ere3+8ExxzUAEt74A== X-Received: by 2002:adf:d1cc:: with SMTP id b12mr15069226wrd.131.1618841918984; Mon, 19 Apr 2021 07:18:38 -0700 (PDT) Received: from [192.168.3.132] (p5b0c69b8.dip0.t-ipconnect.de. [91.12.105.184]) by smtp.gmail.com with ESMTPSA id x2sm25513946wrg.31.2021.04.19.07.18.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Apr 2021 07:18:38 -0700 (PDT) Subject: Re: [PATCH v5 1/3] kernel/resource: Allow region_intersects users to hold resource_lock To: Alistair Popple , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, dan.j.williams@intel.com, gregkh@linuxfoundation.org, jhubbard@nvidia.com, jglisse@redhat.com, bsingharora@gmail.com, smuchun@gmail.com References: <20210419070109.4780-1-apopple@nvidia.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 19 Apr 2021 16:18:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210419070109.4780-1-apopple@nvidia.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: j568fzcx15sosaa9eau9rt34sp5id3u6 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DBDF3200026E Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618841924-519080 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.04.21 09:01, Alistair Popple wrote: > Introduce a version of region_intersects() that can be called with the > resource_lock already held. This is used in a future fix to > __request_free_mem_region(). > > Signed-off-by: Alistair Popple > --- > kernel/resource.c | 52 ++++++++++++++++++++++++++++------------------- > 1 file changed, 31 insertions(+), 21 deletions(-) > > diff --git a/kernel/resource.c b/kernel/resource.c > index 627e61b0c124..736768587d2d 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -523,6 +523,34 @@ int __weak page_is_ram(unsigned long pfn) > } > EXPORT_SYMBOL_GPL(page_is_ram); > > +int __region_intersects(resource_size_t start, size_t size, unsigned long flags, > + unsigned long desc) > +{ > + struct resource res; I'd do struct resource res, *p; Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb