linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Georgi Djakov <djakov@kernel.org>
To: Sukadev Bhattiprolu <quic_sukadev@quicinc.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Rik van Riel <riel@surriel.com>, Roman Gushchin <guro@fb.com>,
	Vlastimil Babka <vbabka@suse.cz>, Joonsoo Kim <js1304@gmail.com>,
	Minchan Kim <minchan@kernel.org>,
	Chris Goldsworthy <quic_cgoldswo@quicinc.com>,
	Georgi Djakov <quic_c_gdjako@quicinc.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,page_alloc,cma: configurable CMA utilization
Date: Tue, 31 Jan 2023 16:26:06 +0200	[thread overview]
Message-ID: <d436ee82-4e3f-67a3-e825-a57d5f096e83@kernel.org> (raw)
In-Reply-To: <20230131071052.GB19285@hu-sbhattip-lv.qualcomm.com>

Hi Sukadev,

On 31.01.23 9:10, Sukadev Bhattiprolu wrote:
> 
> Commit 16867664936e ("mm,page_alloc,cma: conditionally prefer cma pageblocks for movable allocations")
> added support to use CMA pages when more than 50% of total free pages in
> the zone are free CMA pages.
> 
> However, with multiplatform kernels a single binary is used across different
> targets of varying memory sizes. A low memory target using one such kernel
> would incur allocation failures even when sufficient memory is available in
> the CMA region. On these targets we would want to utilize a higher percentage
> of the CMA region and reduce the allocation failures, even if it means that a
> subsequent cma_alloc() would take longer.
>  > Make the percentage of CMA utilization a configurable parameter to allow
> for such usecases.

The above makes sense to me. But it also needs to documented like the other
sysctl files in Documentation/admin-guide/sysctl/vm.rst

Thanks,
Georgi

> 
> Signed-off-by: Sukadev Bhattiprolu <quic_sukadev@quicinc.com>
> ---
> Note:	There was a mention about it being the last resort to making this
> 	percentage configurable (https://lkml.org/lkml/2020/3/12/751). But
> 	as explained above, multi-platform kernels for varying memory size
> 	targets would need this to be configurable.
> ---
>   include/linux/mm.h |  1 +
>   kernel/sysctl.c    |  8 ++++++++
>   mm/page_alloc.c    | 18 +++++++++++++++---
>   mm/util.c          |  2 ++
>   4 files changed, 26 insertions(+), 3 deletions(-)
> 


  parent reply	other threads:[~2023-01-31 14:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31  7:10 [PATCH] mm,page_alloc,cma: configurable CMA utilization Sukadev Bhattiprolu
2023-01-31  7:23 ` Anshuman Khandual
2023-01-31 14:26 ` Georgi Djakov [this message]
2023-01-31 18:10 ` Roman Gushchin
2023-01-31 20:10   ` Sukadev Bhattiprolu
2023-01-31 23:59     ` Roman Gushchin
2023-02-01  4:06       ` Chris Goldsworthy
2023-02-01 19:00         ` Roman Gushchin
2023-02-02 20:13           ` Sukadev Bhattiprolu
2023-02-04  0:04             ` Roman Gushchin
2023-02-01 23:47         ` Minchan Kim
2023-02-06  5:22           ` Chris Goldsworthy
2023-02-08 22:00             ` Minchan Kim
2024-01-05 23:46           ` Sukadev Bhattiprolu
2024-01-06  0:05             ` Roman Gushchin
2024-01-08 20:15               ` Sukadev Bhattiprolu
2024-01-09  2:59                 ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d436ee82-4e3f-67a3-e825-a57d5f096e83@kernel.org \
    --to=djakov@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=quic_c_gdjako@quicinc.com \
    --cc=quic_cgoldswo@quicinc.com \
    --cc=quic_sukadev@quicinc.com \
    --cc=riel@surriel.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).