Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: "Brendan Jackman" <jackmanb@google.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>, "Zi Yan" <ziy@nvidia.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Clark Williams" <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Waiman Long" <longman@redhat.com>,
	"Ridong Chen" <ridong.chen@linux.dev>,
	"Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>,
	"David Hildenbrand" <david@kernel.org>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	"Mike Rapoport" <rppt@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	sashiko-bot@kernel.org
Subject: Re: [PATCH v3 3/4] mm/page_alloc: fixup alloc_pages_nolock_noprof() comment
Date: Wed, 15 Jul 2026 15:17:15 +0200	[thread overview]
Message-ID: <d466b5bf-b423-497a-bd2a-affff25feaa4@kernel.org> (raw)
In-Reply-To: <20260715-spin-trylock-followup-v3-3-fc4d246f705d@google.com>

On 7/15/26 13:03, Brendan Jackman wrote:
> Update the comment to reflect the recent change to allow flags in
> gfp_nolock.
> 
> Reported-by: sashiko-bot@kernel.org
> Link: https://sashiko.dev/#/patchset/20260703-alloc-trylock-v5-0-c87b714e19d3%40google.com?part=6
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>

Reviewed-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>

> ---
>  mm/page_alloc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index c2da85e69a0f8..25a83a57aab66 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7983,7 +7983,8 @@ struct page *alloc_frozen_pages_nolock_noprof(gfp_t gfp_flags, int nid, unsigned
>  }
>  /**
>   * alloc_pages_nolock - opportunistic reentrant allocation from any context
> - * @gfp_flags: GFP flags. Only __GFP_ACCOUNT allowed.
> + * @gfp_flags: GFP flags. Only __GFP_ACCOUNT, plus some flags that get set
> + *             internally regardless (see %gfp_nolock) are allowed.
>   * @nid: node to allocate from
>   * @order: allocation order size
>   *
> 



  reply	other threads:[~2026-07-15 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 11:03 [PATCH v3 0/4] mm/page_alloc: couple of followups for recent cleanups Brendan Jackman
2026-07-15 11:03 ` [PATCH v3 1/4] mm/page_alloc: rename FPI_TRYLOCK -> FPI_NOLOCK Brendan Jackman
2026-07-15 13:14   ` Vlastimil Babka (SUSE)
2026-07-15 11:03 ` [PATCH v3 2/4] cgroup/cpuset: update some comments about the page allocator Brendan Jackman
2026-07-15 13:16   ` Vlastimil Babka (SUSE)
2026-07-15 11:03 ` [PATCH v3 3/4] mm/page_alloc: fixup alloc_pages_nolock_noprof() comment Brendan Jackman
2026-07-15 13:17   ` Vlastimil Babka (SUSE) [this message]
2026-07-15 11:03 ` [PATCH v3 4/4] mm/page_alloc: remove a couple of VM_BUG_ON()st Brendan Jackman
2026-07-15 13:25   ` Vlastimil Babka (SUSE)
2026-07-15 13:48     ` Brendan Jackman
2026-07-15 13:56       ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d466b5bf-b423-497a-bd2a-affff25feaa4@kernel.org \
    --to=vbabka@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=cgroups@vger.kernel.org \
    --cc=clrkwllms@kernel.org \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=ljs@kernel.org \
    --cc=longman@redhat.com \
    --cc=mhocko@suse.com \
    --cc=mkoutny@suse.com \
    --cc=ridong.chen@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox