From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 447F1606A332 for ; Mon, 16 Nov 2026 20:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=e91q/zjO Received: by kanga.kvack.org (Postfix) id 2256C6B05B1; Mon, 16 Nov 2026 15:16:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D60E6B05B2; Mon, 16 Nov 2026 15:16:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0774E6B05B3; Mon, 16 Nov 2026 15:16:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D8E436B05B1 for ; Mon, 16 Nov 2026 15:16:11 -0500 (EST) Received: from smtpin07.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6EF2B16021F for ; Mon, 16 Nov 2026 20:16:11 +0000 (UTC) X-FDA: 85442088942.07.07A38BA Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf09.hostedemail.com (Postfix) with ESMTP id 9CD71140005 for ; Mon, 16 Nov 2026 20:16:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="e91q/zjO"; spf=pass (imf09.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1794860169; b=2Q6GwKVE53qJkddGSLzD7HaWBHHSnxodQoMOme5wunOApCVDuKxcas/i4Qpz5awQ4PNG8Z 7T+LPDgkYxwvhwo9ji36TFfHp9FoiOW6/g6p4dvM88heVd1KeUGt7jvvDKFTDfygodMtRJ eEQrUVLXszUPTon+ikeGf+0IP9CB0ww= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="e91q/zjO"; spf=pass (imf09.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1794860169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nP2/A4kreMDxcG0ChilH5zyKMiflQw713CJUf+u0xOo=; b=n5YzScghBX1Ec7vUs0grObYPAewn1HgiOhoxRtKPm+FQmZuyYYpLm7jEY/LCBzAtsW5swR 09/big2eWttKwBsxTTMi0f/dwhwABBOsJYi3j9+H7SJ9YJO6+uYEpjHLZ9M/gO5yG7AfTQ Yz6BsI/xWVhQZ+Zh5ucf9Sk9c6igBOU= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BCAE743B9E; Mon, 16 Nov 2026 20:16:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D8901F000C4; Mon, 16 Nov 2026 20:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794860168; bh=nP2/A4kreMDxcG0ChilH5zyKMiflQw713CJUf+u0xOo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=e91q/zjOKL9q/uw7SxD7P7ZTugdBB+UjVeXZwDBA8rP/BBz54+FhWFY2qnooMzVWg oX84IokEF/q+TxpkmbU7qiM8zh6hxBTGVrRnh87SH/qv2wv73t0THwTWBdRowX9+AW RsgMhZw0A+ywGRj0DJFvpaHq6RCtWbqAcmzibI9A5TOIQWQadHYiu3HFc4ldrL80oc QVTzetfhI4ylCxsQROZuZt6AFLOVYngULhFF4XkkvJWtMCM7UKrYOC9vo4XfaKbqwF qfWjUYCzprpyX+YfuMV5cvu2RO7YeSZKHw0+Qs9kodUTW39ZT8Qjf3Cdi+TeTSWEsc el6L+IFlE/R9A== Message-ID: Date: Mon, 16 Nov 2026 21:15:56 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] userfaultfd: use anonymous memory for UFFDIO_ZEROPAGE on private file mappings To: Tal Zussman , Andrew Morton , Mike Rapoport , Peter Xu , James Houghton , Andrea Arcangeli , Suren Baghdasaryan , Balbir Singh , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Michal Hocko , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Muhammad Usama Anjum , Stephen Rothwell , Arnd Bergmann , Zi Yan , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Muchun Song , Oscar Salvador , =?UTF-8?Q?Miko=C5=82aj_Lenczewski?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org References: <20261116-uffd-state-fixes-v2-0-4397a0196479@columbia.edu> <20261116-uffd-state-fixes-v2-1-4397a0196479@columbia.edu> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261116-uffd-state-fixes-v2-1-4397a0196479@columbia.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9CD71140005 X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Stat-Signature: ckgyhbpntus687onwe79b3twnef9aghf X-Rspam-User: X-HE-Tag: 1794860169-359395 X-HE-Meta: U2FsdGVkX1/rLwk2adLmxxSFxCKAVFllnvVZERweNJAP9WpYlE9q/I0Qi7Zg5R4JWwEPyXXVbtWBQLpARXh+L6xDRef5a6xEuTQESSuG9ndXZkpJO5RI9/MgN4yg0lyzafTxLiVfWmOjY6fmsKgnhFiUXu3Amwfm88B01ybGe6mq2kJH70REj9SXnZbE90UnPz9qDgvUK0QP4V/hgo4Xw8iy9pa3ofFT6HedvGjPODlHtUy5kBDBZATH0YcBLHbGsRvTJcQnYGgzhQD3YII3GV4PysgygW116ZGm/iyl36meIFdCZbyYXrC4G7aUEJSdeH3GRAsurHsvXBeg1cA5CvetMMhES1g/LTBFkoYhVv4pnM47mMqo+NMa0+Nlni+nilSoULrjI5nOa3aAd8X+1mnwlBY/bMMUPAdO8xVPgCP9YkM5kLj1jC3Yczo9NhroyRPQZSyQnuZwRrKMgMRZ8M4v7Ice1GsWB0KwDYjQrTYhUz1ZJ1CvZZbI0UxMN+u5xqNVvXQhoPydl/XpnCU/S37EsQ73TVSBwsdP81Kyr1o3vWxS66/6c8nrNNM4MGthKlOAMYdhQnkOgc4b7ddcElWJVlutZrccHVIx8ObQXl+MFLWnUZqZhNSo3vZ/6vaetkLokka7eUUo4XX40qXzhSuaCk2NRjL0ha6HTJViqu86Lin8CokykftQplkq3PYGtLXr2nIZ/W+z+wwz2P8aOpmTcw3Bkeu3thDnKJoNh+ekUy1plV+g5Z62NqE0B+lV+JHP0FfhYihkEVfs4O07lJExwHOAx17jzoaon4sYfElR5qGlJ/vMeYvn5QjGYqYvdnr+hoVhAacr9vVL0AcNzSvB2RgRfG4PffhHJop0bHS+BRpIP+LQi7ERKLZ27v+dWMrTjvCt1Z0zNNzgPL287/SSBDRkqEXyU/2yYV86qMvhLA52+j9JU4K1K2SDCYibLD2+5X8BZL5aPGZRZh/ GTlT+X5W ShYJETceRl8x8RWgXjVetjVYcYhA+4+WBzDXQtEBwk5fMvIQrdvm49mGsJNSVLSLZCBvtJ5Fw/Jag5ylD6tdysnDReNSADqUyI5wqniBu8lIh5EBlT0VNyMuAPiZbkBaB8EuuZCn1ceYYc18iaKUELrHh0XZFNZZBRJ3V+ScwSbj1OYCU6Nz9UWc88E9k7ILUETGfVPJqatWeFM4b2/C2iY0qf/owBLcbxU4nZ6A3WSwv6SeDa14X6jJK5o/CyyzTLylgHGNPmB1EviBD6H+izdu96EpC886Szez0e279nOtrXIWEAo0qh1AqCw4kEeJGtKTzjfaOxWGTMzdjuv6ykBATgWyyJRRSuszsx7ryN+Y4/WQsrjAPXpvAIDNHqTjDmfyFjAUNZuhS7I3JfR9yk/sIOg== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/16/26 21:02, Tal Zussman wrote: > If the mm cannot map the shared zero page, UFFDIO_ZEROPAGE falls back to > mfill_atomic_pte_zeroed_folio(), which allocates a zeroed folio and > installs it through vma_uffd_ops(), no matter what kind of mapping it > is. An s390 KVM guest with storage keys or protected virtualization is > such an mm. > > For a MAP_PRIVATE shmem mapping, that adds the zeroed folio to the page > cache of the file. That is wrong: a private mapping must never modify > the file it maps, and the file might even be mapped from a read-only fd. > > The ioctl can also fail where it should succeed. A missing fault is only > delivered for a hole in the file, but UFFDIO_ZEROPAGE can be called on > an address that did not fault, or can race with a write to the file. If > the file has a page at that offset by then, inserting the zeroed folio > fails and the ioctl returns -EEXIST although nothing is mapped at the > destination address. > > What we want is what UFFDIO_ZEROPAGE does on a private mapping when the > shared zero page can be used, and what UFFDIO_COPY does: only check that > nothing is mapped at the destination address, map zeroed memory there, > and leave the page cache alone. The zeroed folio path did that before it > was moved to vm_uffd_ops. > > To fix it, pick the ops in the common folio path, as > mfill_atomic_pte_copy() did for UFFDIO_COPY: anon_uffd_ops for a private > mapping, the ops of the VMA otherwise. That makes > mfill_atomic_pte_copy() and mfill_atomic_pte_zeroed_folio() redundant, > so remove them and rename __mfill_atomic_pte() to > mfill_atomic_pte_folio(). > > UFFDIO_ZEROPAGE no longer modifies the file, and only fails with -EEXIST > if something is already mapped at the destination address. > > Fixes: f74991b4e383 ("shmem, userfaultfd: implement shmem uffd operations using vm_uffd_ops") > Cc: stable@vger.kernel.org > Acked-by: Lorenzo Stoakes (ARM) > Signed-off-by: Tal Zussman > --- Acked-by: David Hildenbrand (Arm) -- Cheers, David