From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8EAC27C76 for ; Sun, 22 Jan 2023 11:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D99236B0072; Sun, 22 Jan 2023 06:44:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D47EE6B0073; Sun, 22 Jan 2023 06:44:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE8576B0074; Sun, 22 Jan 2023 06:44:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF6D06B0072 for ; Sun, 22 Jan 2023 06:44:56 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 885ED1C5C9D for ; Sun, 22 Jan 2023 11:44:56 +0000 (UTC) X-FDA: 80382253392.01.39D00B9 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf26.hostedemail.com (Postfix) with ESMTP id 8E03514000C for ; Sun, 22 Jan 2023 11:44:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=K0ogjQy2; spf=pass (imf26.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.221.49 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674387894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9d3PHM1i18b1wVBT1Cbc8b3/F4tYcjxcOJc7IXM78Rc=; b=FBMkfKcbB39hKMAbKy5cYyC3Fmpfe3DcO0yAzUeo1yTrQrKWgap0p8FdPp/ys0gfXImE8M y7hzZJk8JxuPt4PN1xvdmy2TsXEgQH7d3y3HE63N6Ryfl0DctwlAvkvoF+2KxoTJi66lSe cTrsYAYgtupaK5+/qu54oL8cfEdy7/8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=K0ogjQy2; spf=pass (imf26.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.221.49 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674387894; a=rsa-sha256; cv=none; b=oe7UrW6qqNeIZen++uSwQUqlPTvWWkQTcXPFkxAgMsOxbI629qR8QEqwQBj95+gqMuzuGB UQkWJl4fDJF/8Qm+UkOoCRdI3Alro1CSNY3XzFjrxPUX1F4d0ry4yL2s0Z16HX/EJ5g02Z oCTBTeJBieKkaoCze9v2dtM79YStctM= Received: by mail-wr1-f49.google.com with SMTP id r9so8459629wrw.4 for ; Sun, 22 Jan 2023 03:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9d3PHM1i18b1wVBT1Cbc8b3/F4tYcjxcOJc7IXM78Rc=; b=K0ogjQy2dBIWpRyp2G9Qo7zgLe2LmkcCsc+/SJfNrUrZoMYVAXj6EBfqqAOZO90TQV 8dFrqB0UpP/FL5YLyW8DaYdSIo3BYZ6jWVhbXvikqhFRDlopOedRj2dISYn4JPdf7JlA KzsoTNkcC/dbTzg7fLyddp/61eGwSN2pamhISQfxDpHBGfDt3yL8nejAvTR/KmsWSzBc ZctPEB9rXXjRaaTZa8ZJCKpvyefetvL+86WKhHd1yI+EgTIvtBe9bo4ok2He/FWqHs64 qAR5wQT5taDHiDtKTbA0eAIGDoMBI78QD27Fart3ivhlaqTZYemt5SCMPsmsKsWIv5F1 gxSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9d3PHM1i18b1wVBT1Cbc8b3/F4tYcjxcOJc7IXM78Rc=; b=7LOR7lVaWbo8XOSZd39kZ7nvHQmV0G5qPC2nmIgup3cCDH1sS6jTdpl/y04kgxiLQ8 nQrkczEy9zpY+hMwnRxmzp5o3mbyKzrjHXG06XX0d+hK3n8Cf8w/8z91JJ/KjhNF57nR 0GbNB62EGFuoO84i/hedXl05gCYZW5Px82tX4LsqvF9BrTTLmbI9pjGnlnEr05QRdtm3 tlcdS3CEyOnpytlK09no0ehYggaFbpsIKKBOkkT8yvTOHc6NdtF02HDYqSD1uKahyBzv 98FKhvyazCj0CKmFz2kSpCUi/6p90lvY4gKjEkAoqFYi837Db8OZhXNmN7a04Bn9vLx5 kzgw== X-Gm-Message-State: AFqh2kpJuq/3PWU1LEKWUnstjeaNCG+GeFzfv7wOW0/RKGNg/S51XDPk f7+3xJeFe4HozMR8D67gkSI3Vg== X-Google-Smtp-Source: AMrXdXu83lehx7RbHAkRbhG1oMGJmZelEHb0lgNU+pigubgLCdZ9/atDxUOwXiCGtf72XF5Pmi0c8Q== X-Received: by 2002:a05:6000:1f14:b0:2bb:5adc:9f92 with SMTP id bv20-20020a0560001f1400b002bb5adc9f92mr18054855wrb.50.1674387892997; Sun, 22 Jan 2023 03:44:52 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r8-20020a056000014800b0027323b19ecesm2830431wrx.16.2023.01.22.03.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:44:52 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:44:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-3-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-3-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8E03514000C X-Stat-Signature: zftegb1fzj76abn58yhurxjf198yb4rm X-HE-Tag: 1674387894-657074 X-HE-Meta: U2FsdGVkX18NucJqya7gmhaVwaiJmGS9CwtgLRz8NtXYJOita+3DpwvBXc6yQpSGZDMCRiqWKY43vBA9EYt4GjbIrxd2b+mnkzhbVHzUltTKveSto8MxlBsg/yBuc5wnp70IwUboje/+OUB2+OvEG86Xy2lceyczEdOo2PFJU8SQo9GD5d9twCDxGU1U1zWyG4EjCYlwKACjbqJyZhaAeUbxP44b1HUiIaeb0oIQ+81FO+li9kNmu9TG+RXCQdWdBcS20g/YrAeQqokUsUaj0PNMpOVlXcLUSqn8v9ooAPMjsyfKRjp74Ke8K7mmDXrSS+PMzR8/4JgQYVUQOqDUWQ5xSdLah9v9MIB/Zp6xQA1KhOYzJ1TQlk1rQA3958KyzzCpZ1lPneoKFQj4yV+4BUNllYcXqnlfoAgShQdQCoVumEDEH6XnMqo2JSWxNr2yGvfSW/m9Kn2xbkXvyP7k+akVOYlW2cWOIH6MQkslQCTJchcb92Nt64Jepb3rACcJP4zrzod96ZYB12u85ucUVGqDlvAlMtrtSgOHNU68Lh/6+8fQbLmOs3GYPnJAY6E8lgvBG4tHdbCiVPiCN52CAIvD7fN1RvqLjB3fMu7o/CqjtZRzBcm2dd9vjIsEzY/XS9GxVgnPZCa5epUfkg0eivF1IrEZV6PV7yoRBg8O2WDDPsItstTs6pezLuvQo6gcuHUeXVQnb1iB338Kl1p37DzCw2tb1XpxYeOzP9eGUkkfglGyTnGsPZvyZeoBGQdT39voJeb3VE4gF74Qb+l42Vxxm63ykJ/FH82482Vib3CU5tWh2cFeFaZeELemjQZaTpy+J8V9jqMisq17P3/Q3YrMTT75bPTnttwuPrJMzgTht6OwACyxh73/TfUhNnE8wfN4CAmzXjpAyiYoXd9eWBvWc+cvk9XTb7K4DAc6ebQ5daXGVczzm89vubEn47dInH45IpyFvC5Knef/b7U gGj8mRR4 sZeKJtvpgkShXvL8NT2lnC8tZUXNGmSLyTXPFjiwGZW8qsMk/bkQbM5iLTvEQU6hoFMyF90WOSafqISdR2rTF4lUpX7D1E6OMS3X5B60J0bO1D8akBs/xCzphExF05rYrraGTAIADy1Iq+bTNweBj99Jznio5Wi/m4gqH3bE8EWMlJXU+hfCN5J8MWvQEfe7n5PSsPs4KWTP+tFUvEH0WHRUbZQSrqga8J5tcfI7ru1C2Rz9v4VsAhLzwgcRbhhvPLWtvYjJVA/LSLf9vXkhVSKLldTunGm6HYaMvfsiggmojh4OegruDuF3OR+FDXfG/D0flyCsMjnMMYItT6suxnLUkFfotg+I8sp4en3LUYoaPt8jZDX9pBuuewzgJsoMx1eQztMKvkDbLj50qORjKV+i5hHg0ZZShNFpaURXk7SX/d8AWVcAp2YafrI1aKveElQ4N50ahFm58tx72HmShpRCgYchB0G9iiBNFeSth0WkZkAhgHnTt0Avc24M7TPZs59TLMAhiHHjG60DNTHuQop1Hx7zDmHx9tK8LUhFgR11QrHs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Add documentation for `kalray,kv3-1-core-intc` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- > > Notes: > V1 -> V2: new patch > > .../kalray,kv3-1-core-intc.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > new file mode 100644 > index 000000000000..1e3d0593173a > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-core-intc# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray kv3-1 Core Interrupt Controller > + > +description: | > + The Kalray Core Interrupt Controller is tightly integrated in each kv3 core > + present in the Coolidge SoC. > + > + It provides the following features: > + - 32 independent interrupt sources > + - 2-bit configurable priority level > + - 2-bit configurable ownership level > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +properties: > + compatible: > + const: kalray,kv3-1-core-intc Blank line between each of these, > + "#interrupt-cells": > + const: 1 > + description: > + The IRQ number. > + reg: > + maxItems: 0 ??? No way... What's this? > + "kalray,intc-nr-irqs": Drop quotes. > + description: Number of irqs handled by the controller. Why this is variable per board? Why do you need it ? > + > +required: > + - compatible > + - "#interrupt-cells" > + - interrupt-controller missing additionalProperties: false This binding looks poor, like you started from something odd. Please don't. Take the newest reviewed binding or better example-schema and use it to build yours. This would solve several trivial mistakes and style issues. > + > +examples: > + - | > + intc: interrupt-controller { What's the IO address space? Best regards, Krzysztof