From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51ACEC71155 for ; Fri, 20 Jun 2025 08:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4D46B007B; Fri, 20 Jun 2025 04:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8F406B0089; Fri, 20 Jun 2025 04:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA52B6B008A; Fri, 20 Jun 2025 04:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A99096B007B for ; Fri, 20 Jun 2025 04:13:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 59963801CB for ; Fri, 20 Jun 2025 08:13:02 +0000 (UTC) X-FDA: 83575063404.22.F35CC16 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 7D0DD100002 for ; Fri, 20 Jun 2025 08:13:00 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750407180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sSpjV01Kg94xW3xAxbcCw1aM0iM0lGhdZIf1o9GXa98=; b=41tAw5UKFieWyxg/B80Ven1j7ZBQO8dL4N/iGYCvicTstaR3lw/COisOgHkGXbQmiCSD6Y lHFp0M4WZF+el68r15Eu5+gs6tFDqhTE764fBpdZq6mBykJAxT7/jz5F5IDwn/rgoPKxnG U2/ckHocg+qFZSkBKYF9HDeXxpdFkdQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750407180; a=rsa-sha256; cv=none; b=S7wtkx8fVo1msKeneixVHNLlUTqKS2FfGLmBxYqZ7Y8w6DogAxPXutKmtpHQtLoFW+OkPO nYcio2usE5Ujmgv/RJT6LDPzZXrzBdWAqg9Fzh9RODJwQhY61scl2SREEZ6kkKtp3/t8T0 4qhb5Tpzp7HWXAOsiphIgYJ9DxOaM48= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BE77176A; Fri, 20 Jun 2025 01:12:40 -0700 (PDT) Received: from [10.164.146.15] (J09HK2D2RT.blr.arm.com [10.164.146.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1382A3F66E; Fri, 20 Jun 2025 01:12:55 -0700 (PDT) Message-ID: Date: Fri, 20 Jun 2025 13:42:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t To: Matthew Wilcox Cc: linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 7D0DD100002 X-Stat-Signature: ibqhgf83xnjuf7qu7igmys914noqn6w9 X-HE-Tag: 1750407180-904403 X-HE-Meta: U2FsdGVkX1/TRfDdiuoaFsceyCW9IBY5ZZKWhQWtRatqWPI/1K1eLCILj2U+Mc+//DqJRkH+7ahNl8Qxric6NTujcO9tgVipLjiXUuuTw1uCNfCM0QFbyV75r1/voXS+puSn/gzR44IJbUh3YXh4ovS8C/lht45X0inanJZmXbqbvOrfrmywmcM9L4yJIsyupMUTmVKSFqR+BBA7BYKWyjmA66eFKlt/THSMfk+he1LyZLMT742k7FxaO2ZImsB2oZ6DcdFpTMho+C+EOwNQ6U/98ZIWxcpr9r4CxLzh1E6gmrk3twMeyH0WTudLj3WquC5yPz34Ynbzq9BH8orH/Ur2eEONhAhVOWYQGQE880PuioNlOJIJSwjs5yVnTh4f6HwiLJECcKQCPBt9ObLswYL/1gA/EGudkQlIXJ5lUJEtfH4RIbUrSnvxMzhq/9tWBKYu3jy8Vm/8BleBMSuBoWgBk0Y3ZRKEvn+FgbPGhmfDXTGMVEyXFp9VJ4eC2M1Kih3nJayPPUcChUA/cXe2tSB4KFV3TiY0KjGOXAMg8U/TEWnSCYhjkO9XFimCrLel6CjFtVEQTxIcW+Lf1gUQNHCW1w0o4SmQcgGOadbM9E2mmQrDQNA1J8tiNmUTNEYIMV/STWxMzoQrgLhInhIDs1209RGYuFLwazH3twEBt1jV3ZAr4Igv0FcsvkdHYzU76SQzrFU+IRNtSa3hORAQTg3W9WXC6cz9xQ6DPDBq6mEIeaoyY79+42hRam1UsfM34YVu8Fz0K1goPQsacNKhoi+tlevroAgb8/3PIySG2GpF8QNmh3wPy11G+nSQcujGVqpN2Mdfff+EgqwrYsrucP9EOeVWbhUia9NTSvvw4TcKXeBFOJ52zduS145bQta1ShK9bFZhVykjCDe7Sn6y9L17bzIbdCdOq6I91ZaUpyQer/1TSiems5H52d5jtzniBi6Mj9TeQrt3YXdCpxP c6xyRJKW 4CatV5TmF7KOoWSdt7VI75cllYFu8uf3BNFqOTGfyVp7hprS4SetnxuwDu1QpsE4wjZNu5JMIHSbFLBMs38QSo1aqUai01cQv+l+RXji/VfpnonyhMdchQKXhLJZsZ+xoPnYEOwjsmWxPijZ4UPWZ+msfOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19/06/25 6:56 PM, Matthew Wilcox wrote: > On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: >> +++ b/mm/memory.c >> @@ -522,9 +522,8 @@ static void print_bad_pte(struct vm_area_struct *vma, unsigned long addr, >> mapping = vma->vm_file ? vma->vm_file->f_mapping : NULL; >> index = linear_page_index(vma, addr); >> >> - pr_alert("BUG: Bad page map in process %s pte:%08llx pmd:%08llx\n", >> - current->comm, >> - (long long)pte_val(pte), (long long)pmd_val(*pmd)); >> + pr_alert("BUG: Bad page map in process %s pte:%ppte pmd:%ppte\n", >> + current->comm, &pte, pmd); > > Unfortunately, the one example you've converted shows why this is a bad > idea. You're passing a pmd_t pointer to a function which is assuming a > pte_t pointer. And a pmd_t and a pte_t are sometimes different sizes! > (eg sometimes one is 64 bit and the other 32 bit). As discussed on a separate thread, this might be addressed via separate printf formats for each page table level e.g %ppte, %ppmd, and %ppud etc. > > So no, NACK. >