From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3511CC3DA4A for ; Thu, 11 Jul 2024 21:20:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B16F36B00A9; Thu, 11 Jul 2024 17:20:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9FD16B00AA; Thu, 11 Jul 2024 17:20:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CBA76B00AB; Thu, 11 Jul 2024 17:20:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6BA216B00A9 for ; Thu, 11 Jul 2024 17:20:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0D787160819 for ; Thu, 11 Jul 2024 21:20:09 +0000 (UTC) X-FDA: 82328739738.10.5916BE8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id C9D7C1C001A for ; Thu, 11 Jul 2024 21:20:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LWcYVCkO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720732782; a=rsa-sha256; cv=none; b=fHGV6XYGcUwaV8RWz7eMPcbXitwQor8McnrPXE9T9wV6oqAQGWYPj/rZnHr6M/y062+k08 z5F0DIr9rkd4oEsmXumwmZqXBoCB8DCKRQ/q57sJXS076ydzNbsA4j53LyWbiIq/yAtcx1 Kfi+7fhpYFOuMqhFUQNW8AyiDJZDuk0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LWcYVCkO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720732782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1R1yPcxt1cOr41pbNJOBUSwJcEM1dnUiizIjVJ/tHtc=; b=upAiw6EV+Sf6XkF5y0YJHYfTxx2+eHEe4uMRJMKu42AxTGeipdB4WzIUXWgMKXCAgYLAen MIRqGTlE1D9PpoYjtk3PYVQhPgSJI1cH1HIVZZ107OO1b7c+aH9lt2gmqSw3BB2G/Aou1D u1RTqwlmoTHjxAJn3fGRJB4P43mrsgo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720732806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1R1yPcxt1cOr41pbNJOBUSwJcEM1dnUiizIjVJ/tHtc=; b=LWcYVCkOdbjbj4SGeJOPPbs/5FgskaPRWvF4Rsb5EqZ4BUomt+rFJAq6UhA15HogzEdK9L BiOE9ATI36Cov6xsVWQqhRsB7Fm8v0bAZKooepKKDkofdf+8zuIp/q/4kmp8JmHaEpVNZE hE0eAnpeUY8UAhYvHGxtgZouPwcM3Rw= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-xUdNMcCQNN-2xSnTv067zA-1; Thu, 11 Jul 2024 17:20:04 -0400 X-MC-Unique: xUdNMcCQNN-2xSnTv067zA-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1fb90d7a4c3so11084345ad.1 for ; Thu, 11 Jul 2024 14:20:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720732804; x=1721337604; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1R1yPcxt1cOr41pbNJOBUSwJcEM1dnUiizIjVJ/tHtc=; b=tvnoU9jGcK9LTfWdKqNpOZYldQPHeI8exjouwIc1OF5bYp1VPpFpIZ0Src2+Hm3LXr YhMn4FF2bYv8CXstcJH12rSzTOOaELbiKrUp6qqBN7bQP/QHBYynDWj1YKdQg7XaNLsH oeVMWWE7jQ0v8Mas5/Ezcm7mh8fX7CEHtCZ9W7TwuMIeQKscWvkbxRRtvZkXdUSb5dTY aMCLAsAN9wBvqdca1IVug8Juz5uq6prbN21POHp1exEkExtyI1IJvvbvtEwpfu++smG6 ll8Zh2bYVfT/5YqAHA7ZB0p+30vkhHL+fMJ8ZMXDSMS1tBVOfIT3E7zdGygU7MYTGV0b uvrw== X-Gm-Message-State: AOJu0YyYRutrbQ4/3m1s9A3pwNTZC8OtmPQxDkHpq2L/jTi8wp3LHwJQ YKNrcpmxPFtMh0WEwERyPhzKnh/YEW4jc62F1nQsjRNmw1IfWheNjRzxBqU6DNs4Wy2u9wpIIgs UGaaZgC+qki5mEZXpn4Bg/CjZdQgXnQPxJFG8vN8FC6nyOXU/ X-Received: by 2002:a17:902:f543:b0:1fb:8245:fdeb with SMTP id d9443c01a7336-1fbb6edcf36mr83894005ad.64.1720732803638; Thu, 11 Jul 2024 14:20:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqmBNbu5MxW663zusr5c2lW+jBsdXH71L3llH4HJXdtPO6lN6NnF6rpCsuyh9LpD31gVZ7pw== X-Received: by 2002:a17:902:f543:b0:1fb:8245:fdeb with SMTP id d9443c01a7336-1fbb6edcf36mr83893805ad.64.1720732803173; Thu, 11 Jul 2024 14:20:03 -0700 (PDT) Received: from [172.20.2.228] ([4.28.11.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a0fc62sm55034285ad.40.2024.07.11.14.20.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 14:20:02 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 23:20:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: Avoid PMD-size page cache if needed From: David Hildenbrand To: Matthew Wilcox , Gavin Shan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, william.kucharski@oracle.com, ryan.roberts@arm.com, shan.gavin@gmail.com References: <20240711104840.200573-1-gshan@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C9D7C1C001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dstpe16sn5exrhd8h3u8tqsrtzsh4rsa X-HE-Tag: 1720732806-524324 X-HE-Meta: U2FsdGVkX19+orHZRESAvvLAdRSy7nDefy0zYm3Eq3cyvRGjuU8fEYpY/fs5atQveOqdLk6jOJQcVlqLWoUBRS3oQ4FcWl6LAn0cw/chbTS6R3WO11gAX0wHABII5zMB77TzCW5EErhoAg8OsCaVnRn0YCqAIsBzMLIby1gdhTen6Kek+2DMVqgc/iVDQ1eB3SfYyKj7tNJG52wsfefjDKeIkQZJHO7ZYyJ8ok8l6/X+ETsTWi4UzPo5a+sLljaJOLGtYtvqGCNIARnEb45IyjDjo1Z4kKiQEDnrZ3nIGLP46Zli8h15SKg+sO4N6mMRjn2TJASzyU7LHXJNF5prGGfpQ5s9GPDgThn3ROWT4u/WeOAkhN3aWnSK60qmLSI0yjSl1NTHwFjBBPBuZyI1wg4LuQ6bJ8x1iUeIjIXLtKri/J4JIW7zkK4gDgTWufMGsYU7k4hinAlTFY6d0ffyMIMZxtouDPDgA69q0s/Pd9lwizeidTP2vKEVFlG6BQblp4Jb6WPcAmiWhVGVrLzIBJCG+/cBA99oGerWXwPj3Msj0Et8iozGq5Ao06o4bSFgGuFUCXByRoXKsETfvAzyPyY1DBlbSIEF9RY5ucjkbb47dea7G3LL3n4lQoS1S4Psq1NCv+LezerJsTlje0+cRTm2HtRx2FDKpdIeWuexkqW6tpdgao+BdE8enePlRBGKk6dCXCBDDf1/DsE5HGEM4jDfHxLizRjzMgwGN6nWR8N3YdJLNzhbCKpobrCTfD9otN0FREjamMSftZyVuV/omeQAZ6RzSguPH67r4Jxs3CSDNa1LS2eJJfLdkn5VJOEKO09wFEkd6AGhzUJfMBjkz3SFf/GbrcSyWLdO4pLXWe28mgg2mlmxrUYx47ZdGpySv3CjosjsJgzPRTmYcSYuXYSGNUu45lg1me9xUXMDMLg0cS3mcgQVdittfZ9AzMNlcMmi7PnMxBfA+L/HLGc Un2GW1i1 /zqNQcMFRqfABA4x39I7soROl3z8AQjUztm/Gid9zl8iH3qKCmY287MUlVWXUyBYhcwj0/KBLSugLoRQZuKNKBi/u24yHIX37266kKPDsAwwVpX1/XFfUezq6ZvrfSeVOG5P41daXVnfI6GoTyla+RM7+QSK3tggGuFWcGTucZBzho3S+HbnePNX6W4wxx/e1EaBbf3kcBBo6IJYLvTvVvvtbeBe5ihRILWGj7/JLcFVGb3CPBv5oI2wqC9tWTwJHraAmkEp4UEhzyeyAg12zXaTNGrtCXTnifSTodIEG5hy3uLThmnmTM1zCD7svKnwXHicNwc736pzpPkTYvblwGbTePDQOBwa4pUPRLnIBhrIvxh1id00XUpU9DyPvaoA0zYjlBDynOhN5fqm32/DtBxhi7fNCbXzZXse5/Sxk5i/f03ZoMWOQcFD5QfNbOSy6VMzHsUQsgBcdTJ4Mi+Quhgt44JZGhnYglez83WGyg6Kfa0uGE6H5kO/p2IgvEMLKrXZV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.24 23:03, David Hildenbrand wrote: > On 11.07.24 22:46, Matthew Wilcox wrote: >> On Thu, Jul 11, 2024 at 08:48:40PM +1000, Gavin Shan wrote: >>> +++ b/mm/huge_memory.c >>> @@ -136,7 +136,8 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, >>> >>> while (orders) { >>> addr = vma->vm_end - (PAGE_SIZE << order); >>> - if (thp_vma_suitable_order(vma, addr, order)) >>> + if (!(vma->vm_file && order > MAX_PAGECACHE_ORDER) && >>> + thp_vma_suitable_order(vma, addr, order)) >>> break; >> >> Why does 'orders' even contain potential orders that are larger than >> MAX_PAGECACHE_ORDER? >> >> We do this at the top: >> >> orders &= vma_is_anonymous(vma) ? >> THP_ORDERS_ALL_ANON : THP_ORDERS_ALL_FILE; >> >> include/linux/huge_mm.h:#define THP_ORDERS_ALL_FILE (BIT(PMD_ORDER) | BIT(PUD_ORDER)) >> >> ... and that seems very wrong. We support all kinds of orders for >> files, not just PMD order. We don't support PUD order at all. >> >> What the hell is going on here? > > yes, that's just absolutely confusing. I mentioned it to Ryan lately > that we should clean that up (I wanted to look into that, but am happy > if someone else can help). > > There should likely be different defines for > > DAX (PMD|PUD) > > SHMEM (PMD) -- but soon more. Not sure if we want separate ANON_SHMEM > for the time being. Hm. But shmem is already handles separately, so > maybe we can just ignore shmem here. Correction: of course <= MAX_PAGECACHE_ORDER But yeah, this needs cleanups -- Cheers, David / dhildenb