From: Mike Kravetz <mike.kravetz@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Hugh Dickins" <hughd@google.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Michal Hocko" <mhocko@kernel.org>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"David Herrmann" <dh.herrmann@gmail.com>,
"Khalid Aziz" <khalid.aziz@oracle.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 3/3] mm: restructure memfd code
Date: Mon, 9 Apr 2018 20:03:25 -0700 [thread overview]
Message-ID: <d5bfc82f-9331-fc0d-abbf-acc0a80b2c4c@oracle.com> (raw)
In-Reply-To: <20180410014153.GB31282@bombadil.infradead.org>
On 04/09/2018 06:41 PM, Matthew Wilcox wrote:
> On Mon, Apr 09, 2018 at 04:05:05PM -0700, Mike Kravetz wrote:
>> +/*
>> + * We need a tag: a new tag would expand every radix_tree_node by 8 bytes,
>> + * so reuse a tag which we firmly believe is never set or cleared on shmem.
>> + */
>> +#define SHMEM_TAG_PINNED PAGECACHE_TAG_TOWRITE
>
> Do we also firmly believe it's never used on hugetlbfs?
>
Yes. hugetlbfs is memory resident only with no writeback.
This comment and name should have been updated when hugetlbfs support was
added.
Also, ideally all the memfd related function names of the form shmem_* should
have been changed to memfd_* when hugetlbfs support was added. Some of them
were changed, but not all.
I can clean all this up. But, I would want to do it in patch 2 of the series.
That is where other cleanup such as this was done before code movement.
Will wait a little while for any additional comments before sending series
again.
--
Mike Kravetz
next prev parent reply other threads:[~2018-04-10 3:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 23:05 [PATCH v3 0/3] restructure memfd code Mike Kravetz
2018-04-09 23:05 ` [PATCH v3 1/3] mm/shmem: add __rcu annotations and properly deref radix entry Mike Kravetz
2018-04-09 23:05 ` [PATCH v3 2/3] mm/shmem: update file sealing comments and file checking Mike Kravetz
2018-04-10 16:54 ` Khalid Aziz
2018-04-10 23:51 ` Mike Kravetz
2018-04-09 23:05 ` [PATCH v3 3/3] mm: restructure memfd code Mike Kravetz
2018-04-10 1:41 ` Matthew Wilcox
2018-04-10 3:03 ` Mike Kravetz [this message]
2018-04-10 23:55 ` Mike Kravetz
2018-04-10 16:55 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5bfc82f-9331-fc0d-abbf-acc0a80b2c4c@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dh.herrmann@gmail.com \
--cc=hughd@google.com \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcandre.lureau@gmail.com \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).