From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE80E77188 for ; Wed, 8 Jan 2025 18:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B3A16B007B; Wed, 8 Jan 2025 13:04:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 364396B0083; Wed, 8 Jan 2025 13:04:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 204EA6B0085; Wed, 8 Jan 2025 13:04:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 007AE6B007B for ; Wed, 8 Jan 2025 13:04:15 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6DAAD80C45 for ; Wed, 8 Jan 2025 18:04:15 +0000 (UTC) X-FDA: 82985058870.08.59F7FB0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id E1344100021 for ; Wed, 8 Jan 2025 18:04:12 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ddx26eL9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2uR8swvh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=COZ04nYl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DapUm3vo; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736359453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kJOfqpteTkENd9oTA2jIYJFgnSCpujF1dC7mWHoM7sI=; b=DyIuGBdzYWgjXUiJDo8oDxLI0QETl6qOQX7ZZckQbBid01pze3kVWdpOfC+UrlKYMQ0okF UDI4gBjmU3qyR5EphpnoaZnrLR14rqRpzunDulGtSGSCHtvfNzb4G5Hwq8etmHy+0IeBKG x6io8Pupp+m8aL3dWcOmei1D5qDYYzs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ddx26eL9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2uR8swvh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=COZ04nYl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DapUm3vo; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736359453; a=rsa-sha256; cv=none; b=O0NgbG2CWo4ze594dZnPN+oHVyZCzLUMBvOWntkr66ht9dozyUp3ocftJBT+xgkahnjHZl jDq4spfbUuBIDBCUFeiRgS90N0m3ageM/KvJDcEm9cBI3B9PV/9CxcF6y3qWPTPMTkKEoS H7cILIxzBeRyNQg4dQy51HTU1bc2PQg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1663E1F385; Wed, 8 Jan 2025 18:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736359451; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kJOfqpteTkENd9oTA2jIYJFgnSCpujF1dC7mWHoM7sI=; b=ddx26eL9Xt2NKyQFNquTQusQlk/UocEW7qHr+aTeX17rzTmXUUWlkixkUDtR9Kq5CsQpDO euyx2mqPt2yFjXzs3gU3t6nKcGYHNHdMnrp7RNnSINc4SLK52rhgTsfqdeAAho4cWdBchS YnQ1dpr7ZnF6cprYB12gGpZNFKPt63k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736359451; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kJOfqpteTkENd9oTA2jIYJFgnSCpujF1dC7mWHoM7sI=; b=2uR8swvhwieg62K4QPJWx7Q3KwpIrXU/u7c1dNH30rgcdrLmD10cuRDxX3lAsu2gFyIdvR c5J1FKalLxEJ25Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736359450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kJOfqpteTkENd9oTA2jIYJFgnSCpujF1dC7mWHoM7sI=; b=COZ04nYlUEW8QCrUYosgMEM3M++JUKq2J1uL7ocLSUD9mYQC8pgON7BV0BXxDMG2QAfFb+ aihs9LjOpEsTiNqhf0ViBIB2LN5r9YMMzOa0qOzKWl6xdp/49fFp1kqjRp4STymMiyovN0 Bjup20MWHUm04RyHsFu+HyHsjJ0x1OQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736359450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kJOfqpteTkENd9oTA2jIYJFgnSCpujF1dC7mWHoM7sI=; b=DapUm3vonTatBRnHjFZ9oJPUXKneZbdvLzuQcL2Upvze0skmr/O3zyvTYUC7lCe/d/jjTs YDrgiOb8gSDlflAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C6FC31351A; Wed, 8 Jan 2025 18:04:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NnPSLxm+fmfNEAAAD6G6ig (envelope-from ); Wed, 08 Jan 2025 18:04:09 +0000 Message-ID: Date: Wed, 8 Jan 2025 19:04:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 14/17] mm: remove extra vma_numab_state_init() call Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-15-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241226170710.1159679-15-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam05 X-Stat-Signature: i3dm3hnw44o3fcwn65w986f3xns73mec X-Rspamd-Queue-Id: E1344100021 X-Rspam-User: X-HE-Tag: 1736359452-621197 X-HE-Meta: U2FsdGVkX192fdWDQfcdeCXAh20HZMHgWDltHeqgzu7CGMzbkTxuDDh+J/2NnxcQb944xvF4XdihuaWGfzfSSzwW9y/6FgVRoa6n5oQrqtUYRTqLgb59hp6rOtUKSmH/yOTBH3Aqcj7cMbo0/n2yTLaO0zLFmvWu3WGQmWNbMP5XYWRyxCzFVcA1rfLFvAczn0xJGZHjgM4MLlaJ/11AKb3FkJcZt5LbiT8cVVLI9sqLHS07bBAqhkFrUTBeLiVHBTRPPGuGQFfl2+GGiEYEesMI5hrSJznP83kNlyhBnR0OLGx5o30aPXaVGa0Zt+TIsSVSxcOTTAPBkWKfbaWSv94zebk3e4sN+c87nEkS7u7S8k8dd0y2m7EzyzIXS5phnctOwgWNQK5+WYnbC4pwQKk0pYKN5yWiaESfhvIEeUBthTN0NVKnspdEAhTtgSYBlcKFTaXIZEoywl3dY37UFhjusQaLURdtJ00wblBKWXBnCoai8McLn/odrDv5fL09vmCzS5Ml2zJgkLxqV3dYS/FLSa8OZypkpmZTn2EYV/kX2mV8eXmqW3uajei+EP4FzbeQbrSgAJowV/nwmvXHLmtKJtevdWVmfdTPH4ev4UjM1VuFjBcdEn7r3pWQ/PHwBJJogHvUJleqiubNDQHrbRNaBN+lAWhvGRzHiO/NsQQwIUAn3z+vncn1YbEjqUnvSXO08VZRFebDwnK+f6dVX75Hqrj9Wpc3+6Wh8LtAfwA0kAVLPv82IeUr+yfJFk7U6v+Kt4Z0GhI6X2/Zum8IkWMRJJIsE5aNUjO5mkHr9/tJgD05LQomDLcF0gMrsvZN3+KhZo6uoCk3PEyIYMCEPNP4r66uhviwVHM6PJsRs5iHIdIUoJf1UZGOc4dspgmuFJopU/yPAZEC5InZ7iYTnHS/DOMxdq3TfpcGwDPMl252wWSGOI2mBxyfqfe2651U/FouHsB1DQn1LGXTN1V OLjImwIG 5j3hZfe2WOGQZuTX456+6qCMtVnF7rfS53JSlvx4c92Le6kn2BBZPHLBaqmZQDWA3UuaVDsO6ZOS3ncwH6aobmq14E4kz/JCZIlLFMinXklQ9IeLdjEqWbQVw1y1Quc5V8LrMwkeU5cWsbnPJnAk0IVfP5SZlc/J/HMUPWOwAZjcPKt9sqWJjWRWFK5UepR5AfWe9TRQOiEK/NtRAHIscD7vm28HQNhTrxA/u59DQ80jDz8SknQMsat9Mc+8wP8wPZZmRkrJLrl9wa29lh9H6ERE+CrD7sihMqvoaf/J/+aTkuG+d4cbO5sAqP2kmu4Bxak5OhdiOf4MV5jzsIh++FHGgtVpqPXvQ2jdGsciLhHZfxA0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/26/24 18:07, Suren Baghdasaryan wrote: > vma_init() already memset's the whole vm_area_struct to 0, so there is > no need to an additional vma_numab_state_init(). > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka > --- > include/linux/mm.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 99f4720d7e51..40bbe815df11 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -947,7 +947,6 @@ static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm) > vma->vm_mm = mm; > vma->vm_ops = &vma_dummy_vm_ops; > INIT_LIST_HEAD(&vma->anon_vma_chain); > - vma_numab_state_init(vma); > vma_lockdep_init(vma); > vma_init_lock(vma, false); > }