From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB45C77B7C for ; Mon, 23 Jun 2025 15:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 943756B00B2; Mon, 23 Jun 2025 11:47:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91C406B00B4; Mon, 23 Jun 2025 11:47:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E3106B00B5; Mon, 23 Jun 2025 11:47:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6AD196B00B2 for ; Mon, 23 Jun 2025 11:47:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 16D5612162B for ; Mon, 23 Jun 2025 15:47:37 +0000 (UTC) X-FDA: 83587095354.28.7104C83 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id A6964C0012 for ; Mon, 23 Jun 2025 15:47:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VKx+jyuc; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750693654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GiAjHcBAXD9a3mz8FRd2NO1NhckLiGKv82XFpmw/3HY=; b=xB46UkSOOBoTeiGxCh0PLjleMMx936jWUcP1uzG5vJnIIQx4jFjmbwtjQzriAWNJE7PTKv L2VGKdRWUTzWz6Tpq0x9gSTjcja5vYjsI4az4mFs1kUuvvkah9i9IH91WZcAeNlpmy/xoH SPOMXuPsfMCfY/wV9omidkmsZon37lk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VKx+jyuc; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750693654; a=rsa-sha256; cv=none; b=edYQIJIIZo/tYAIzw+trLconbHH6N7CsKjfxfAN0dzkJfKzYyNpWjOnZ7QmuCXOcderWCe m8qS4b0fnkvN3duomZh4nGmxumDUYiiTVSpkzJHTT/a3v4kjMq45IYUPAJcGijaijtjtdS +4lM9oh4HJcLhVwYmoLIhM0o8udzs/o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750693653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GiAjHcBAXD9a3mz8FRd2NO1NhckLiGKv82XFpmw/3HY=; b=VKx+jyucExg7P+DJ1UKWK3Ecf29vwZBlbqYWzwpCuYiQxxBGsRD0e6cCkCs3tVZEHnd210 etdrH6gnRbEhQrmvhQ4PzuJ0AYW/7WT7fzPS1yIDSR+mFq0W6s+ldiqHLdt54IcSCa+c34 Z6ukWnu/vEYa4MeUjG2w4VktlG0aclI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-4mMQcW5mP6a51ArIJ1RxkA-1; Mon, 23 Jun 2025 11:47:31 -0400 X-MC-Unique: 4mMQcW5mP6a51ArIJ1RxkA-1 X-Mimecast-MFC-AGG-ID: 4mMQcW5mP6a51ArIJ1RxkA_1750693651 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a50816cc58so1825853f8f.3 for ; Mon, 23 Jun 2025 08:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750693651; x=1751298451; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GiAjHcBAXD9a3mz8FRd2NO1NhckLiGKv82XFpmw/3HY=; b=oyITfT7rKUWkaBFi0ZrlX4uG762H0T5rZuetl88Pk4X/53yBx45BapFz5TrhO97tLx 55GPLoOUDc9SMad8w7c6XuLvkPS9e6vA6oHYqnsDsbYTEygwG5S3dcdW9Wq7uAuU5/fy KEfE8F45H0MCM5PrnZ3ZqFQs3T6SSwOaukvAhGY2hIZc5V4nlaTK1JjiHjCgVk65lhgb HOk3izQeNOiFCldXl33XRaCOL8T8t9gvLfZvYl9yJjevuWD7jMmlKVLnWru9lP4JOnRr sXthOkn3tiU2pkITT5H8oE91mRpMkpS426qTok7EpGEiQlA5AYdgf/Nu9j5CBAr4xJCc CDJg== X-Forwarded-Encrypted: i=1; AJvYcCWrR/sYOisRzGNW2o5Kbx6ypq5FqWU8LDHnpGfSRH/PrCrukL2Zf1PVPBq6PUsG+bwIXTZWhv02gg==@kvack.org X-Gm-Message-State: AOJu0YxeGntHaQ1KkRk9dct0wFNgsRAr9eJnZGjbiIYBsay7u3QbW85D gdI7YrZ6qy8Bt7H2wpofxY5AlazIFFLVcgWifZKr6pjnt0pB4UFiGJ0B8EN9SjrkRFvIAPeelJj 400Ml9xBN9alYn3Z/dUmhUwhk8y6b1oQwBxzvh9/eZ8L9CwyYobv0 X-Gm-Gg: ASbGncu7xnIHlZ0uf6utXq1jozbLfIiHpejCVCF3mOWZCIhfR585w3fwewbLiFLjMAm cEDpAhmbam6GGezZ9ZbwybI7hOzXDJ970iPfPW4T5dzWsO4tCbF8zk+e8Oip8GpxavDEKyVPuGM +0jFxQj8fTq8epPCPLpt1wP5W+RzMTFSWWRGhMigmbb76H69VgJ5XwQMp3wU8xBXAI/hIVr+CiZ mvz6BF/wM/SUL3xv2JxYITjsoAtdj/z2idXwxacYFOVZTRDAgXSh7F0xRfgVshtK+eo9Y5wq0Yl SmHbASGOmV69cQlSRb3rdddR44kiQyOlqRjeo+q8ctaortqJQTXJEP1l6i0M822kS0zaz1yAKSe onnGSUkR3PbKmHZZGTEFfxpJAYrTm2Uzf1hUN9ibQSErDtH+8Hw== X-Received: by 2002:a05:6000:40da:b0:3a0:b308:8427 with SMTP id ffacd0b85a97d-3a6d13242f0mr9661370f8f.37.1750693650755; Mon, 23 Jun 2025 08:47:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBbzh6rLRiE5JaILdTM7jhp0Rp9pGuiB9PpXQvKHMRuXqyueW+S30S6ZgK14mTl9LJ6P93/g== X-Received: by 2002:a05:6000:40da:b0:3a0:b308:8427 with SMTP id ffacd0b85a97d-3a6d13242f0mr9661316f8f.37.1750693650228; Mon, 23 Jun 2025 08:47:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f1d91bsm9608094f8f.42.2025.06.23.08.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:47:28 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 17:47:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 16/29] mm: rename __PageMovable() to page_has_movable_ops() To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-17-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5DDq8Uygr79m3pVFQ_zcVip0kBY8-rGl4WFfWGb6O2c_1750693651 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: A6964C0012 X-Stat-Signature: ijnzc1ahaoyqthzoxryu85r99ciiy4hp X-HE-Tag: 1750693654-842446 X-HE-Meta: U2FsdGVkX1998qvPt0MIIDwrcfeQjRIwqp10ZcOupK9N93L6G2p6vz1LZ59K24VFwNRshxDpGu1IJdgrLNek3kR/3rBC8oPsQLWan/SFFzmqTlPP0X9TjvRyToF0jIkoWxJYQClslCqnvkK3yi0W9zMmhA2PzJa/tUC5oys+xoMTQQLSL1fuXzHzk6zJRp74bDHuDq1bNu4kvx5jxJZ+PE4k+6LjnEYhrUtgFAz4WEcVSknACj3kkzKdmS1/crGRCk+juR6hHgx3yNCKGV13YxO59SfP58T53qHIdpTUH/5aahl7Vz93oP8oFXAY9cJLSgfWOrgIqIj3QgDngowSCLfO0lYPLsVCsmx53W/MUM3/1jYjkMoHFU7Ym3YROdCBdU8ezuMer/9BawPutwVDrCO2JhVLR11LOQd0k7e8YH3DhTYG6rlhdsbrUUw67p1HtI33k6VjnG7FUYzHkv1PUgbpC7AD2xIpphTQbjbvel846riItGortJ0l7phyj5W4twF9qD+0zqUPOds1NuY9zlab8yk7sgAmXQ4Z9r76TDjK9FlZCfM/lhBpjsc5X/2c/lmZFYKS5SOaVxBjcf+jwgA3XibJXqhN1dzbWGm13qiv+frIkb9am607yYIGnDkaPv0nDbS6Hnb3g0GafjWGjKXyApVrw4E+/1tLToj5TroVLuO2PUpm+kh21n4Y6DfoJ7TlGhMP/Y35soOtIZoAwVolAXtUdVT8VIbe+jTVsE3dferHCkydAkq0eKQmIONkZXJhQSHGkOImKEu15v7Mzgz3JBXYrqyBCZxDMK7lbvMcjp7JVHxXTra3cg4PtWJ5DNqwqu9iDnVciCidffW+JRhRjVegYUJgziTkmtge2gUHxxoaKYmqCJUzuqtXaQfXGG9+qT0S2D0AADgIyV2bTDKlBTHTFPH6ihKFr1w/6CgXvipJKDijrNOiUnFV24BEIuEFw+jVfRUZMYhkA1V mdOsmaBq inU5NkF7wsdaaYMP4QIMEdOe9nsmgnmd3+yeiozPdVz5PsD7hecdFXrcqzhfcI9sZh2ZyM9Z7Dy/PQHVK7tWPenKNxbyrv9P1aQTo/INGe64eKGB0nGap4Kqfa+9k2CzfU5J5aXtRo//XsjXMILjg74T9oNusem3vE43oC5Sm96tR3HnTC/1TNHuDBLvU3h0JCFjJ6BCEJPmu3rZ+kTLJZaB7CxYINwO+/9cqeiDH387h6DDjsQKuPvio1HyFKyDsSm2RypkTXr9oZswMiSYwZh06z5J84qTPl51IFjs8lW+BJZmhJNDeXfv51bD6JEQyfPgYWERkXZdMrqdlyMTaUsMPh3A+e+wLFK5hngzIvRg5vEEtBkE1OZ/qRpe/dFxLGcsnLMF/28kHWtVzGFZ5JFW5OAlQ5TsGUfCotOshV9A9pVyhwGd6xJhfJBA/lsOxvrijk5xnTorCUcqdrdmbq+HpaP+lLQCrEL97LPm+ed1ex2qIQOPLnFC3iMc4JSExt5vCRyQ20nn1r5rMYo9vugcSsMdQmpMxeIjb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.25 22:37, Zi Yan wrote: > On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > >> Let's make it clearer that we are talking about movable_ops pages. >> >> Signed-off-by: David Hildenbrand >> --- >> include/linux/migrate.h | 2 +- >> include/linux/page-flags.h | 2 +- >> mm/compaction.c | 7 ++----- >> mm/memory-failure.c | 4 ++-- >> mm/memory_hotplug.c | 8 +++----- >> mm/migrate.c | 8 ++++---- >> mm/page_alloc.c | 2 +- >> mm/page_isolation.c | 10 +++++----- >> 8 files changed, 19 insertions(+), 24 deletions(-) >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index 204e89eac998f..c575778456f97 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -115,7 +115,7 @@ static inline void __SetPageMovable(struct page *page, >> static inline >> const struct movable_operations *page_movable_ops(struct page *page) >> { >> - VM_BUG_ON(!__PageMovable(page)); >> + VM_BUG_ON(!page_has_movable_ops(page)); >> >> return (const struct movable_operations *) >> ((unsigned long)page->mapping - PAGE_MAPPING_MOVABLE); >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index 4fe5ee67535b2..c67163b73c5ec 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -750,7 +750,7 @@ static __always_inline bool __folio_test_movable(const struct folio *folio) >> PAGE_MAPPING_MOVABLE; >> } >> >> -static __always_inline bool __PageMovable(const struct page *page) >> +static __always_inline bool page_has_movable_ops(const struct page *page) >> { >> return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) == >> PAGE_MAPPING_MOVABLE; >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 5c37373017014..f8b7c09e2e48c 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -1056,11 +1056,8 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, >> * Skip any other type of page >> */ >> if (!PageLRU(page)) { >> - /* >> - * __PageMovable can return false positive so we need >> - * to verify it under page_lock. >> - */ >> - if (unlikely(__PageMovable(page)) && >> + /* Isolation will grab the page lock. */ > > I feel that the removed comment should stay, since the current comment > makes no sense when I read it alone. Well, talking about the page lock is moot either way. The thing is, anything can change while we don't hold a page reference. So should we change the comment to /* isolation code will deal with any races. */ ... or drop it completely? > > In addition, why is __PageMovable() is renamed to page_has_movable_ops() but > __SetPageMovable() stays the same? page_has_movable_ops() and __SetPageMovable() > are functions for checking and setting PAGE_MAPPING_MOVABLE. The naming just > does not look symmetric. See follow-up commits where __SetPageMovable() is cleaned up. -- Cheers, David / dhildenb