From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46604C46CA1 for ; Mon, 18 Sep 2023 07:52:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A786B02AD; Mon, 18 Sep 2023 03:51:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B41BA6B02B0; Mon, 18 Sep 2023 03:51:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A31586B02B1; Mon, 18 Sep 2023 03:51:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 94AA86B02AD for ; Mon, 18 Sep 2023 03:51:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6DA1FA0C45 for ; Mon, 18 Sep 2023 07:51:59 +0000 (UTC) X-FDA: 81248949558.13.48E8711 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf15.hostedemail.com (Postfix) with ESMTP id BBEE4A000B for ; Mon, 18 Sep 2023 07:51:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=k7RMbAKz; spf=none (imf15.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695023517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z5UFI3bFvQBLi9G8wcKHj2Lpnoh/6I1bDYyfY36jzOo=; b=XYJUmmbDPBQaYnyewow7YJy+qmOCEMGYreeO6vH2oV7zp8hwsRgVJkdIRfIkF2a6+NhrHH Mx003vl+/H56xW1v2Gvwv+PLWtWMN5NKMZp/3qScb3f+t8uIcgPQTUOFTcmdF3Ifitsh0G BuktIw30cLSoGuvpCF1jGTscDKEv+w0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=k7RMbAKz; spf=none (imf15.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695023517; a=rsa-sha256; cv=none; b=n5GVDUSfjsK6tHzh7V+PdXypGYDTR6pWsN4nZpYMZIuomjpUlvA0NJTJJLUqKKk+J7Kzgn wszBJsVAjrPimZhdDH/qYDxOupgx4Fcs/bvzB7raxlWCbbLWThAMbV4F4pMp7c1/saM477 3c7FwfMg4KjPOvOvPyhjIS9EH7UPYws= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695023516; x=1726559516; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=F92rNU2upp1sAb9O/m30BxSQQfs05gdxlTOIwaluPho=; b=k7RMbAKzSTyJbggFavO0e+48tohPOL0tDOhCohW2+ZAvFwnYJjNld8lA hPueXNmhYEjKYtCQAHETrcTjBz1OpUXzscBT0prvYPDCxwmh/gM32QOi3 Ckd19u109SSOegVmPsSoaj5t36CdvYAdlpFubygmUPvkqatjKkIpWTZkU Hfsonn7hLti6G/TS5kak5bLcnUWcMoVtr9kG7VooHPXZU971SJm0L+0kB wB6zyRynY7U0HNVyrTSDNwcg/50BybUo1lY9NZVGq49YTq8UrQSk+3eZs Yd0wXqj1YSLRujyU5DmHX2HnS3iJHV2Fbmf6jrB4xgGEYAOzHJS+x+nid Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="382335532" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="382335532" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 00:51:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="811262156" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="811262156" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.238.8.84]) ([10.238.8.84]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 00:51:45 -0700 Message-ID: Date: Mon, 18 Sep 2023 15:51:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> From: Binbin Wu In-Reply-To: <20230914015531.1419405-12-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BBEE4A000B X-Rspam-User: X-Stat-Signature: 6dwuqkx7e14deqa5gbjinmaxbmmju6x4 X-Rspamd-Server: rspam01 X-HE-Tag: 1695023516-507158 X-HE-Meta: U2FsdGVkX19I+hCVMhxmRPw4Pwe+3jIFMb/ADNqcdjXQHntd/XZsAWDDR5mKX3ji7m0R8LLVtJgb+RaXt28rXkdkyn8m/au7+/3AosYjFSZiBguJ+0x37Cn3TltM/cdyJ+MHP/JLy9V/HaZA6CxUnAlIaHodnIvnv4gb8c473PfwvHQUEAAq0GGsE4JZhcEb2GiD6xtZqO5KTrIIq6cUtmbwH2vS+BDP7JtxAbjyZ0L5rdKr6vCZ0UOn0RXQZBpFsCLcJGJDJZoFBQkhX8b/i6Zr6mIJ00MenkTPAB7GaahiX+wPNck8r4b2SBdTk4kF97ibTUnq5V+XminauJIMLUudGgo+jcRCNAeM5gEEF6IH5JPnLOfTHqLUXGAylAHLApGX/jsuBkbQ1HrVS2dxH9hkgoaMBp/vfZ1YqBiDmUJgeJeU3gjt5Cc0qfT2uxizCczQRUxIWpKYTyd1KHWIl1ZRo+relLUkcgcF05urIZSveftchXwP8LXSzgDC0uqqKe8sV0oqBs25aqKc2ewd0U+Abu5A9AFbvifSGp5JQb+FFyu3VGHK88huoNZsO64y3iZQl31oWdsXogYCleqKkrk5uvViI6520/DXXgGmnt10Wk8s9oIgqYmUOs5uQJwqK5QPva/nZQEidHqPMca181ghhIi3Q6BnmLs/4BNt0i7wmoCsKQRjsgppj54+8sX4+KipyPQQFh/xWkHkiNe+t4n/bHof7dihPidEiGR7n9z4MXkE7vGA2it7C+A0uB5wqdzx6IQ4agrOjX5p+GtdLWLbrITa1CnBSGFDJUMP6xVbspjwF4+oXIACum1RfjEVAYVOyVE8ldelPjAXXBlLRWiYCQY5MQG44zZsPpzqaRCEX0bMTIGvZm3HFwGl+fYEYff5AHFma3C+AsEWgA1gHCqQKW2607lv25dySenIz193+D0ikQyjA046wxtY0Z6u5njIdSwuva+JQWd5un6 WHTrf4IS 3/ILD5/DX0xAqGcwbnsGjTtz7AnmdfhqYQC0taN7LQYrUDIrtuBr2iL9sM0Z73DNXtKvsuN7JTXPmyqb5+4Qk7UbK96irvWj7jdrNUe93xxdOMrist23h7G+O8XqmF2LV4VOdBIVN4CgdJ32q4yMrCRcsHZRRqmHjBm/EIUA63Wotu33P+Rv9Mq71mr7BWGobTw8Rm53uV2dSol8buGUUeZEQxPW591ZgV9OY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/14/2023 9:55 AM, Sean Christopherson wrote: > From: Chao Peng [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > +/* > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > + * matching @attrs. > + */ > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > + unsigned long attrs) > +{ > + XA_STATE(xas, &kvm->mem_attr_array, start); > + unsigned long index; > + bool has_attrs; > + void *entry; > + > + rcu_read_lock(); > + > + if (!attrs) { > + has_attrs = !xas_find(&xas, end); IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? > + goto out; > + } > + > + has_attrs = true; > + for (index = start; index < end; index++) { > + do { > + entry = xas_next(&xas); > + } while (xas_retry(&xas, entry)); > + > + if (xas.xa_index != index || xa_to_value(entry) != attrs) { > + has_attrs = false; > + break; > + } > + } > + > +out: > + rcu_read_unlock(); > + return has_attrs; > +} > + > [...]