From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2701C4345F for ; Mon, 6 May 2024 01:32:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52BD86B0083; Sun, 5 May 2024 21:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DB976B0085; Sun, 5 May 2024 21:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37BEA6B0087; Sun, 5 May 2024 21:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1AEE66B0083 for ; Sun, 5 May 2024 21:32:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7049180753 for ; Mon, 6 May 2024 01:32:49 +0000 (UTC) X-FDA: 82086246858.15.43528C8 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf21.hostedemail.com (Postfix) with ESMTP id EC34C1C000B for ; Mon, 6 May 2024 01:32:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714959167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iIur5Dqbz9cLudd9uKut9tYsuvKwVOrQtLb/L9h9wNo=; b=HxVr1tYBt9VHMtsQ9Ejo+IONRm6qr9yuvcLTqRuBT7w401T212IwZlonx7xTWpcMIvihet maD9uPmgwVeRJHvA2bLHTqWoR4+FfpPzFNn73Fva2dqLH8g1Dl/26f7e/f5he6LFR9vJeV LWinzNgB/3VLi9R6/1MZhrtRrcOoxKs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714959167; a=rsa-sha256; cv=none; b=ATbR2qmKM03lbwzJsHv7nHu6ew6Py9kB6OvxB0mQGEVI5J43FjXH6GLf03ugdvTamR/tnS sf4wLYcyAeUZPjixvK7cO+kmkkjrDyRjDMUfHVhxrUJsgTPI6KHlnRpqYNElMBXnBNuwv9 /5DUrfkedWrATjdJaKPvKC5o4Ux+CVo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VXkRh34S0z4f3n6c for ; Mon, 6 May 2024 09:32:32 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 2D1FD1A0572 for ; Mon, 6 May 2024 09:32:42 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgB3fG45MzhmoWpmMA--.42545S2; Mon, 06 May 2024 09:32:42 +0800 (CST) Subject: Re: [PATCH 02/10] writeback: add general function domain_dirty_avail to calculate dirty and avail of domain To: Tejun Heo Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240429034738.138609-1-shikemeng@huaweicloud.com> <20240429034738.138609-3-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: Date: Mon, 6 May 2024 09:32:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgB3fG45MzhmoWpmMA--.42545S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Zr4xXw13JFyUXrWUXF43ZFb_yoW8JF4kpF 4UtanI9FWkta9rXr1fWr48W3yav3yfWFW5t34vk3sFvr4xuF4DGr93u34rCw1S9r4kJwna kFsrXw4FvF48CFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUk0b4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv 6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUOyCJDUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EC34C1C000B X-Stat-Signature: ns5cr7ufarzroupqxtooh5hqwhurgau3 X-Rspam-User: X-HE-Tag: 1714959166-258836 X-HE-Meta: U2FsdGVkX192KCv1XAJkhPqkELO4Wa1w0r0+Ud4l2Gn3ftFqcsQAgrchXjKW2DA272PWqhAaj1zZDXVVGYP49aRfcTujw+QT3apJ1TTY/5zeEdrehryzSQzKjEcV70bSSMMbJKJjFA8zIFlZOp4Ce3zFro7rI4FjpGsIXOj9pArUvV0bfMaxUeYJ8yUo5l2HWp+beptjzoXtKf+zTVOift4p94rI4vt9YFY8xil2kRHlTm1PLSnVTOGzxOWLj4cr7ciq+ZZqk1WvhN+xgh/G+wElhxNsGS02Ax8QaPgiEujlsNdJjSJ5Sd0Bo85B0Un1DMj1WVbtUyMuSb8+XydkMF9w/4kEw9UsY4Yxi3aKd5LSmkrcAnN8PZxkXMOoCsM5YRyrytKOOXxOrn2QHIPitxkUJUmeBcRVJjaocE/U08aHM1TgPU62DHO3Qvj4J8SQw1QKXglPJkqzC/Spb3c3jxeFNtL3nwW2eew2lWmvS6T3RSWc5K7XHQ9Z1YJxHNV17Nl1YTXocno9vVrBlH2NhjmUlU8jYCY3BE/TaJP8/9x3hq5sszWkrBMtEHp/h4S9CGvnLlYEhNgoJbS599kaOVjK/I6/TV2MsLpyD+9xQUovAH05SEWkx6lWSyKf00UJVdNV7AelPZpaQi0syPFuhtaOxao+mV/4FR5RZ3oUag98GWyK7nVqZd/Wseaq2UXfOqb74FnnC5BnBf6X7ldQBs6CnkNyaQ3uUksZcnr/CfbsZdU1/u/4S6IRmnaLpTPKOcFiAi+DlICEiwHASPyeFL5Yxm4MgWkz34+kW2oOMMBwgfInJ2Z4PpMFeN89fBQSPzyyz/GJIZFZ6lRgiBc9GLW15lUFuGPWGLMOGxLNtqi4NIUVB+RofUh1m0yQOPDXfeo798pcmGhUxflL73rfgQT8kTxxusUnEhw3MKzbC9CmaYie8zu7zPNR3qtkgQdwtIQqepNIcIsRnHmmigr KrsoVVC4 sE/KZk3mxrjEkpF7NGC/i863Ep3D8K7WqrFHDz44ejPYk8JxcGSq96TXdeNyK6yZRWN2/gmW6835f/UMi1rN+iJMhIgkgAvsRFBt+DvFP9LD5Jpk1BgsT7IzH83jfGJVvXD7sjozNcgvNmzTwegmBV/m7ZlY5UJ23Me1mqEvhu6oKGflA824bIlbWFHSin+UmLnkrldvjHhrjmywChSamMZRPaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 5/2/2024 12:49 AM, Tejun Heo wrote: > Hello, > > On Mon, Apr 29, 2024 at 11:47:30AM +0800, Kemeng Shi wrote: >> +/* >> + * Dirty background will ignore pages being written as we're trying to >> + * decide whether to put more under writeback. >> + */ >> +static void domain_dirty_avail(struct dirty_throttle_control *dtc, bool bg) > > I wonder whether it'd be better if the bool arg is flipped to something like > `bool include_writeback` so that it's clear what the difference is between Sure, I rename 'bool bg' to 'bool include_writeback'. > the two. Also, do global_domain_dirty_avail() and wb_domain_dirty_avail() > have to be separate functions? They seem trivial enough to include into the > body of domain_dirty_avail(). Are they used directly elsewhere? I will fold global_domain_dirty_avail() and wb_domain_dirty_avail() and just use domain_dirty_avail. > >> +{ >> + struct dirty_throttle_control *gdtc = mdtc_gdtc(dtc); >> + >> + if (gdtc) > > I know this test is used elsewhere but it isn't the most intuitive. Would it > make sense to add dtc_is_global() (or dtc_is_gdtc()) helper instead? Will add helper dtc_is_global(). Thanks. Kemeng > >> + wb_domain_dirty_avail(dtc, bg); >> + else >> + global_domain_dirty_avail(dtc, bg); >> +} > > Thanks. >