From: "Yanjun.Zhu" <yanjun.zhu@linux.dev>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Simon Horman <horms@kernel.org>,
kexec mailing list <kexec@lists.infradead.org>,
linux-mm <linux-mm@kvack.org>, Alexander Graf <graf@amazon.com>,
Mike Rapoport <rppt@kernel.org>,
Changyuan Lyu <changyuanl@google.com>,
akpm@linux-foundation.org, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH 1/1] kexec: Use %pe format specifier for error pointer printing
Date: Fri, 31 Oct 2025 14:00:55 -0700 [thread overview]
Message-ID: <d710a4fb-adba-4d95-99db-a2d1176bdeaf@linux.dev> (raw)
In-Reply-To: <CA+CK2bD+_QFWx-+3sTW5f-C2tKG+bU1Fzk2bUP39UGuGouPRVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
On 10/31/25 1:18 PM, Pasha Tatashin wrote:
> Sure. Will include it
Thanks a lot. Appreciate your helps.
Yanjun.Zhu
>
> On Fri, Oct 31, 2025, 4:09 PM Yanjun.Zhu <yanjun.zhu@linux.dev> wrote:
>
> Hi, Pasha
>
> I noticed that you are moving |kexec_handover.c| from the
> |kernel/| directory to |kernel/liveupdate/|.
>
> Several developers suggested that I resend my patch after your
> patch series is merged upstream.
> Therefore, I’d like to ask if you could include my patch in your
> series. This would help avoid extra work on my side to resend the
> commit later.
>
> Thanks,
>
> Yanjun.Zhu
>
> On 10/21/25 2:41 AM, Simon Horman wrote:
>> On Thu, Oct 16, 2025 at 08:03:20PM +0000, Zhu Yanjun wrote:
>>> Make pr_xxx() call to use the %pe format specifier instead of %d.
>>> The %pe specifier prints a symbolic error string (e.g., -ENOMEM,
>>> -EINVAL) when given an error pointer created with ERR_PTR(err).
>>>
>>> This change enhances the clarity and diagnostic value of the error
>>> message by showing a descriptive error name rather than a numeric
>>> error code.
>>>
>>> Signed-off-by: Zhu Yanjun<yanjun.zhu@linux.dev> <mailto:yanjun.zhu@linux.dev>
>> Thanks,
>>
>> This looks good to me, even though I note that this file
>> has moved in linux-next.
>>
>> Reviewed-by: Simon Horman<horms@kernel.org> <mailto:horms@kernel.org>
>
[-- Attachment #2: Type: text/html, Size: 2915 bytes --]
next prev parent reply other threads:[~2025-10-31 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 20:03 [PATCH 1/1] kexec: Use %pe format specifier for error pointer printing Zhu Yanjun
2025-10-21 9:41 ` Simon Horman
2025-10-21 13:56 ` Zhu Yanjun
2025-10-21 22:42 ` yanjun.zhu
2025-10-31 20:09 ` Yanjun.Zhu
2025-10-31 20:18 ` Pasha Tatashin
2025-10-31 21:00 ` Yanjun.Zhu [this message]
2025-11-01 13:49 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d710a4fb-adba-4d95-99db-a2d1176bdeaf@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=changyuanl@google.com \
--cc=graf@amazon.com \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).