From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB53C3DA5D for ; Mon, 22 Jul 2024 13:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 994766B007B; Mon, 22 Jul 2024 09:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 942416B0083; Mon, 22 Jul 2024 09:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 809CA6B0085; Mon, 22 Jul 2024 09:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5E2DD6B007B for ; Mon, 22 Jul 2024 09:23:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A1F21A1707 for ; Mon, 22 Jul 2024 13:23:57 +0000 (UTC) X-FDA: 82367456514.07.8D6B7E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 5CB3D40017 for ; Mon, 22 Jul 2024 13:23:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=USfhdc9X; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721654574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F04SlJJullNum8McQISmIMasrmkoqWbSgpnIQ4Kl30c=; b=EBseumSJ0tHJyjbJvkyCmU+YieRYWcmiDpQR7Cy/SiaLsyaqtRSfcEqXGt7XTx+Dda8QLp SthIDRT9aRA8+OL556IxQAJLxGWTTW7JEfoTXSM7Wr3G/W4zlID5Jld8TBAi1QBz9yfob5 a0vmp3Eao9hoj+aqmwd3xGgRYiXm8xs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=USfhdc9X; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721654574; a=rsa-sha256; cv=none; b=UzSCWlHwkzQfIpIeSwhHNIAmdHVD4B0bDP5HfTDKyRWxc2dfOsAiCPEqAkJXs71dS3gJbX 8x73qZX32AhqTG5glg6Hj2qovVkLzDjgYh1eB8cVnEtqU9BJGgHsyjQph6miBBOdSazeXs 20wz8nmSjmP2QRx4EWyPVtmqcvhDJD4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721654634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F04SlJJullNum8McQISmIMasrmkoqWbSgpnIQ4Kl30c=; b=USfhdc9Xrc08OkrYYxeqmZ07120un6JzuYth6FFNF5nsIMjaBOPK2TIxl7sz9q9Kae3iNa JiO1A8HwbUD5yJ0mPkhLFq6/7yH3DtemfaJLU9Xtgvw6XLD1A5f7gcT008gq2ET0HMqHui 1CMrWDAGChLC1llGSB+5nVE61amIaf8= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-LXr7sG3wNZWmbuneHkLO5g-1; Mon, 22 Jul 2024 09:23:52 -0400 X-MC-Unique: LXr7sG3wNZWmbuneHkLO5g-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ef311ad4bcso7917591fa.0 for ; Mon, 22 Jul 2024 06:23:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721654631; x=1722259431; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=F04SlJJullNum8McQISmIMasrmkoqWbSgpnIQ4Kl30c=; b=Xybx3Gj8rRwG13vzxxQUeOclx9+K+qKy4Lql/Q+0EzCQluAAYP15MpqwEng1iB5alK kQWbYUM3ojSJV0Sw6c5EAhLqNa5+/v66mVMh2RAGunR+SGVQMTMW9ckMAZ6vecpHuEdI LC1R3Skm05nzSFqF6em16/crxdtLr8eQCPErdB33HOjjYm1m0KUPWa4T1J1zOgM6Ugbf z9L0sT/ZY/dgIh76w3QBj3IlP9/MIAoRW4FX6uwv636by4kbbzQJgDkpoFytVM3p5Akj yCmOHvnUYE57QPOO7sW3PvTCzfA4O+SnLvpOf2Q48CImqCrKZ0pD4SNSSc04aszHGqT9 7aeg== X-Forwarded-Encrypted: i=1; AJvYcCWDRvnD3aRYIL2WztqHxHWLFY92EtSrIVnOKvh1EQ/NcdhI/ol1cbCmFfRiUDtb1bdiFvf7rT4GUEXsi1Z5YrFRbhg= X-Gm-Message-State: AOJu0Yw0juUY22A8vHs9Zqi4NN+OsOqwULE2xdYH7w5/okBpqqWhsbDQ gAu5pvlPQIoPq3nJgyz1BH56fhMn6nKD9s5V6DcPq+pKMz+wMUjg5T3gGjShLEuRQmtt66st7ZH BZOAzWAaxZecA7e8mFAkjPMjYKECbPodwL/8jACUvXw3PqoH4 X-Received: by 2002:a05:651c:549:b0:2ef:32fb:6c4c with SMTP id 38308e7fff4ca-2ef32fb6e8amr16007231fa.45.1721654631392; Mon, 22 Jul 2024 06:23:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEF13w93G+v9yeNkY4YBGT7gLSuiziqPRuuS1m69zlHFC9lAE12YwZlXWoUjUjGKiLsM8iP/Q== X-Received: by 2002:a05:651c:549:b0:2ef:32fb:6c4c with SMTP id 38308e7fff4ca-2ef32fb6e8amr16007011fa.45.1721654630880; Mon, 22 Jul 2024 06:23:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c727:7000:c050:e303:f8a7:6ed9? (p200300cbc7277000c050e303f8a76ed9.dip0.t-ipconnect.de. [2003:cb:c727:7000:c050:e303:f8a7:6ed9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787ed572sm8472272f8f.110.2024.07.22.06.23.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jul 2024 06:23:50 -0700 (PDT) Message-ID: Date: Mon, 22 Jul 2024 15:23:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] BUG: Bad page map (8) To: Hillf Danton Cc: syzbot , hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Matthew Wilcox , Vivek Kasireddy References: <20240720050219.1813-1-hdanton@sina.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240720050219.1813-1-hdanton@sina.com> X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5CB3D40017 X-Stat-Signature: eggxfcmq64u8yxji3938k97m76yh4ta1 X-Rspam-User: X-HE-Tag: 1721654635-930568 X-HE-Meta: U2FsdGVkX1+UavXKw95CmxDCj3nZL+vxcSXuVOExKPmUKAl8PwYO7eji/BUZw2iwX2S3IWpwJtjwH11UhYxYN7hPly0BcGasfvBms/uoZaTNPuyEtpeDgjFuXAmGDypm0zlmh2+Cuk0wYhnNlf/ZuzRSdXjW06sFYrgt1Axuq7cOusxiUxikw4AxhQawWQesKqUM8XdUA5E08sAKIKJIvloFFLHtUVysLDrGywaSCZaVqiSa90aJtAujxTmFlpaM623gt7xAUuHsWWrvxbwR6haMzfPaIOFjqm2GgpgJ0NYdJysjL2qS0XIszE4rLF9H1bf6wD05SqLotSJON4LAdYe09aORVx/cTZxAQMb5c1W3tOgNB/VLBkalib2Zw++on3gTD81VnMc1vNmuHl+1wSO1KJybXGwPvhzmdb7iHcM7oh/Nt2SkOMhE8jP42nd2wQqj5tNA/SBo/GyGmJ534YmYoa6Rhz8o1fgeDlUAsV90CfNEuGAj4R8uYOebdcKbiff3aQM5gSkSztKbegTfg4JNBp/kKGBCeUJl2NW0r0sTUfO2jgveTrRJXBKTcDkyT7LaX4DBATOBmIlxqGpgH8uEoLWTpjrvm3T2onw1qi5fOc1YYG4xzNTs3dJ2kgeeRLlRnKwv9iiLlKi+GH7/2nIzoN8Ecs2FDRnbKZ+Kaqm++OSaGBDVYwiJThd/hIjsjrsq0oiVCKHvm2LehvAGeJ4GqmiGv2gXqiJOnfHY2VIf9vcSwYbGBE2qarCxtG2Q3CVE2IAGPACnS3ufDM1HzrizdZVrNgQRsfpFV7nT7/kBgk6zvsC1PieBGZES7bI1OEHfBOBMRzsENzupVvpg++Hl4EoSVhDZVGlZlUDBNI0iiS7T1fXDvuczNI/jcxABWudnInFWWoy5wSLNAQgq8Zdj/qpqK4bCYGyf3enTAQbqLllmxwinRsws19qHAHxcaLxipnALZiQlwq/v1VT WW95bC9j Oo3SkKFHwCSJKiBANpcyOlosLwXzYDpX8V8BvSX0S/3RPetT7NcDYMxeEOec0n8iIOSXeq0jJ7uu0IyUS5GFHnT5+Iwul7SdZdtijDzToi6qYRzY7ANG4MnF3yuL3Tf+OPp43/6QDwY5aCJTVKNrqQQ5jFz5gVciG4o4Iw3BRdehMJocE+vEPU1AB0w7pjsF5vtnXbFe7nZwo4XQiCc+9UY0d5ToL1fJdYPVxLidwmcc1r+gg129Z6Hb24rqjHNd5ioX8rvdxP6iZjTKMPHfallwY5qKq5jj2b2gTXNE7koKs/H6zbMzZkSUQ+6M/AfMoF2VPm3MS6VYsx49DJI7riP8/Y50wu9N8VlnXm+3N11vPT9jW3FdKShoyT1wLEMcMW3EJY3u4W3m4HlN55LCyuP+pM+gYesN5HK+4hqD5gX4U4KE3aOs9Pv3xa9jEkB8LR+rdDiSU2T53KUOvA4JyBt1QUdJskdCQi9n5/juw0NJOFh6c8fGG6unRC8viiA0cOwnJnmPfNp0GIwQ/0kJ/0UDHDGvyAC1ggmweWgBEQWgPyQS18cvLZwZClI235taahQV9azK19K4QK2JQNNwDh0aEREUxcah+wLJtBJUu5HCdrVt21c1FlyLlArHJlK/gk/mNXiTITPREwPvKPIMWTzU7vJmap1d+JGznzGUAnayBv1F0ma9a5eoCJn7hTYxaJpt34fcAQer0Qc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.07.24 07:02, Hillf Danton wrote: > On Fri, 19 Jul 2024 13:21:30 +0200 David Hildenbrand >> On 19.07.24 00:51, syzbot wrote: >>> Hello, >>> >>> syzbot found the following issue on: >>> >>> HEAD commit: 4d145e3f830b Merge tag 'i2c-for-6.10-rc8' of git://git.ker.. >>> git tree: upstream >>> console output: https://syzkaller.appspot.com/x/log.txt?x=11321495980000 >>> kernel config: https://syzkaller.appspot.com/x/.config?x=6b5a15443200e31 >>> dashboard link: https://syzkaller.appspot.com/bug?extid=ec4b7d82bb051330f15a >>> compiler: aarch64-linux-gnu-gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 >>> userspace arch: arm64 >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=113e054e980000 >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1366ab85980000 >>> >> >> The reproducer involves udmabuf. I suspect it has to do with it. >> >> But I'm curius, does the reproducer not trigger before 4d145e3f830b on >> mainliny? >> >> Viveks changes are not upstream yet, but I can only speculate that we >> have some issue similar to the one we had with hugetlb: udmabuf doing >> things with memfd/shmem pages that it shouldn't do, because it doesn't >> "own" these pages. >> >> "udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap" might help. > > cpu1 cpu2 > --- --- > evict() find folio2 in page cache > truncate_inode_folio() > truncate_cleanup_folio(); > // unmap folio2 from mmA > unmap_mapping_folio(folio2); > mmap folio2 to mmB > filemap_remove_folio(folio2); > > > If the window exists for mapping folio to userspace while indoe is evicted, > is this report false positive? I think what happens here is that filemap_unaccount_folio() will force the mapcount to be logically 0 (value -1). And if we then actually go ahead and unmap that folio from our udmabuf page tables, we will let it go negative (and also free up the refcount too early) resulting in all kinds of issues. filemap_unaccount_folio() was written under the assumption that the mapcount will only get modified when we map something via the pagecache, not when some other code (udmabuf) looked up something from the pagecache and then maps it to user space itself. "Fortunately", the issue only exists with CONFIG_DEBUG_VM. The right fix is probably to stop udmabuf from touching the mapcount (use a PFNMAP as that patch does). Another fix would be removing that debugging code from filemap_unaccount_folio(). I do see value in part of that debugging code. The refcount+mapcount modifications, not so much. But the "BUG: Bad page cache in process ..." message sounds helpful. -- Cheers, David / dhildenb