From: Laura Abbott <labbott@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Kai Heng Feng <kai.heng.feng@canonical.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")
Date: Thu, 8 Feb 2018 10:34:42 -0800 [thread overview]
Message-ID: <d7314317-f3d6-a38d-326a-7a27e05a5e67@redhat.com> (raw)
In-Reply-To: <20180208181800.GA9524@bombadil.infradead.org>
On 02/08/2018 10:18 AM, Matthew Wilcox wrote:
> On Thu, Feb 08, 2018 at 09:56:42AM -0800, Laura Abbott wrote:
>>> +++ b/drivers/media/v4l2-core/videobuf-dma-sg.c
>>> @@ -77,7 +77,7 @@ static struct scatterlist *videobuf_vmalloc_to_sg(unsigned char *virt,
>>> pg = vmalloc_to_page(virt);
>>> if (NULL == pg)
>>> goto err;
>>> - BUG_ON(PageHighMem(pg));
>>> + BUG_ON(page_to_pfn(pg) >= (1 << (32 - PAGE_SHIFT)));
>>> sg_set_page(&sglist[i], pg, PAGE_SIZE, 0);
>>> }
>>> return sglist;
>>>
>>
>> the vzalloc in this function needs to be switched to vmalloc32 if it
>> actually wants to guarantee 32-bit memory.
>
> Whoops, you got confused between the sglist allocation and the allocation
> of the pages which will be mapped ...
>
Ah yeah, clearly need more coffee this morning.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-08 18:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 6:29 Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly") Kai Heng Feng
2018-02-08 13:06 ` Matthew Wilcox
2018-02-08 17:56 ` Laura Abbott
2018-02-08 18:18 ` Matthew Wilcox
2018-02-08 18:34 ` Laura Abbott [this message]
2018-02-08 23:20 ` Matthew Wilcox
2018-02-09 4:08 ` Matthew Wilcox
2018-02-09 9:12 ` Kai Heng Feng
2018-02-09 14:07 ` Matthew Wilcox
2018-02-11 9:26 ` Michal Hocko
2018-02-11 11:28 ` Matthew Wilcox
2018-02-11 12:05 ` Matthew Wilcox
2018-02-11 23:51 ` Matthew Wilcox
2018-02-14 14:04 ` Michal Hocko
2018-02-12 9:50 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7314317-f3d6-a38d-326a-7a27e05a5e67@redhat.com \
--to=labbott@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).