From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB13C6FA8F for ; Wed, 30 Aug 2023 00:49:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E741E8E003F; Tue, 29 Aug 2023 20:49:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFDC18E000B; Tue, 29 Aug 2023 20:49:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9DEE8E003F; Tue, 29 Aug 2023 20:49:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BC1BF8E000B for ; Tue, 29 Aug 2023 20:49:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8A0EAA034A for ; Wed, 30 Aug 2023 00:49:11 +0000 (UTC) X-FDA: 81178936902.03.FA4C217 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id CBEFD120012 for ; Wed, 30 Aug 2023 00:49:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=R2eMjMGc; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693356549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l6ldWDOqGKIdEumDQQZraLp712clgs44Ub5voSyAlmQ=; b=1mA6yaHFYugLpypoS72lNqZPmzqfFKS8d+XJAyFoPzJa3wwoiwe0j3bfxBB7a0cGoZqgkn +cjlFOVS7OYN8Q91hRv1jxtUYPcOJWgWzCSOFIpTVcaOblM49Ly06R73+FHuU308/40SMA jGfN9uVEFaIWQbWXPLENPgRS6hxFCfs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=R2eMjMGc; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693356549; a=rsa-sha256; cv=none; b=4wbKjP1OlHJZM9R2XO4QJa8bS4Juu3mVzIj3badH1D2c46aw1XEu37tRTDZj/1uBUWAeEj iLygur04Er+Eh0gw4Yje9df4Cxqe4bOywqC0p610th3LDzXPoYInboBxq9VVXqV/yzdgR+ FzfDqPcWWKdjygbkkgw4bhNiY1pMOzk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7298663894; Wed, 30 Aug 2023 00:49:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15649C433C8; Wed, 30 Aug 2023 00:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693356547; bh=Y6mimTT4f5bHTNOgMAPJs7UzoDd9JcRrnEgta8s7/7g=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=R2eMjMGcVP6twJXzPd3GjCC/QAkoBXyIXwyF0PetiX1VDQJtkSU/FrVUdLPhlHeJk dBHqNW4EShjtZaWh7sFQvaiUl3mq77UH9KDN3DI2snJ6o1c+81N9JuEjNxovdv+bSx sgcIB4JoE+RW7C4bNpHemTP/NmKBpTL7+v/S4iHTHVlduZjb2wd1jti+ZtvOSZrtwV l+HJJMf2BwuQ5fHlwOGaHAX0BTHl6xVSRaJy3EeRODk9yD0xK9grM4eFB73+9nNR6U SUPRRhBT9hKA3cHo92ct+4AiPcoeZ/GYLow2fGYu2g/oM5lHg/5skk6mbUINrwlVsy FRJBQs41w8qcA== Message-ID: Subject: Re: [PATCH v2 08/92] fs: new helper: simple_rename_timestamp From: Jeff Layton To: Al Viro Cc: jk@ozlabs.org, arnd@arndb.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, cmllamas@google.com, surenb@google.com, dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, leon@kernel.org, bwarrum@linux.ibm.com, rituagar@linux.ibm.com, ericvh@kernel.org, lucho@ionkov.net, asmadeus@codewreck.org, linux_oss@crudebyte.com, dsterba@suse.com, dhowells@redhat.com, marc.dionne@auristor.com, raven@themaw.net, luisbg@kernel.org, salah.triki@gmail.com, aivazian.tigran@gmail.com, ebiederm@xmission.com, keescook@chromium.org, clm@fb.com, josef@toxicpanda.com, xiubli@redhat.com, idryomov@gmail.com, jaharkes@cs.cmu.edu, coda@cs.cmu.edu, jlbec@evilplan.org, hch@lst.de, nico@fluxnic.net, rafael@kernel.org, code@tyhicks.com, ardb@kernel.org, xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, jefflexu@linux.alibaba.com, linkinjeon@kernel.org, sj1557.seo@samsung.com, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, miklos@szeredi.hu, rpeterso@redhat.com, agruenba@redhat.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, mikulas@artax.karlin.mff.cuni.cz, mike.kravetz@oracle.com, muchun.song@linux.dev, dwmw2@infradead.org, shaggy@kernel.org, tj@kernel.org, trond.myklebust@hammerspace.com, anna@kernel.org, chuck.lever@oracle.com, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, konishi.ryusuke@gmail.com, anton@tuxera.com, almaz.alexandrovich@paragon-software.com, mark@fasheh.com, joseph.qi@linux.alibaba.com, me@bobcopeland.com, hubcap@omnibond.com, martin@omnibond.com, amir73il@gmail.com, mcgrof@kernel.org, yzaikin@google.com, tony.luck@intel.com, gpiccoli@igalia.com, al@alarsen.net, sfrench@samba.org, pc@manguebit.com, lsahlber@redhat.com, sprasad@microsoft.com, senozhatsky@chromium.org, phillip@squashfs.org.uk, rostedt@goodmis.org, mhiramat@kernel.org, dushistov@mail.ru, hdegoede@redhat.com, djwong@kernel.org, dlemoal@kernel.org, naohiro.aota@wdc.com, jth@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hughd@google.com, akpm@linux-foundation.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, john.johansen@canonical.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, jgross@suse.com, stern@rowland.harvard.edu, lrh2000@pku.edu.cn, sebastian.reichel@collabora.com, wsa+renesas@sang-engineering.com, quic_ugoswami@quicinc.com, quic_linyyuan@quicinc.com, john@keeping.me.uk, error27@gmail.com, quic_uaggarwa@quicinc.com, hayama@lineo.co.jp, jomajm@gmail.com, axboe@kernel.dk, dhavale@google.com, dchinner@redhat.com, hannes@cmpxchg.org, zhangpeng362@huawei.com, slava@dubeyko.com, gargaditya08@live.com, penguin-kernel@i-love.sakura.ne.jp, yifeliu@cs.stonybrook.edu, madkar@cs.stonybrook.edu, ezk@cs.stonybrook.edu, yuzhe@nfschina.com, willy@infradead.org, okanatov@gmail.com, jeffxu@chromium.org, linux@treblig.org, mirimmad17@gmail.com, yijiangshan@kylinos.cn, yang.yang29@zte.com.cn, xu.xin16@zte.com.cn, chengzhihao1@huawei.com, shr@devkernel.io, Liam.Howlett@oracle.com, adobriyan@gmail.com, chi.minghao@zte.com.cn, roberto.sassu@huawei.com, linuszeng@tencent.com, bvanassche@acm.org, zohar@linux.ibm.com, yi.zhang@huawei.com, trix@redhat.com, fmdefrancesco@gmail.com, ebiggers@google.com, princekumarmaurya06@gmail.com, chenzhongjin@huawei.com, riel@surriel.com, shaozhengchao@huawei.com, jingyuwang_vip@163.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Tue, 29 Aug 2023 20:48:48 -0400 In-Reply-To: <20230830001917.GC461907@ZenIV> References: <20230705185812.579118-1-jlayton@kernel.org> <20230705185812.579118-3-jlayton@kernel.org> <20230830001917.GC461907@ZenIV> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: CBEFD120012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: a4sor3h5aqyhyjfu45iwiz95u9fupty7 X-HE-Tag: 1693356549-84637 X-HE-Meta: U2FsdGVkX19VOfWzQ6v3bHTOrV429uLrkJaDV5VZBslZC010nA1zwmsU20k7gyQs2TovXjKRsSPzqTB0KeNPkwZ/QPSEh05lSw+p86v6UCsrUlivP1K/N6gU3k9ra5qhfh5HKtALKO6Q6tRDn6Yy9w7Rtm9wbftByO8+gNCNPSVSOXAJixianFWk2yWBQo17P3+5/hQfmE0028Qdkki9Vonbdis6x0CQlU2JKcUglgW4wGqB7mCwkBhpkAVevFhli52J3Hc7OCCGXNPKHTfGKnhbbvOpjmsjxuMUR21mm/XrYxdFjW/L26bl1Agpd+r5eXHQuvWU0OVk9FMYOB4mliwM1sUZzMUhJRw7joFVj/31ibItqnut1a1t7LtVyEwDhVca6y02I7U2793QeP73N6hzNV19sljraDnazCMamCqguykPlmaBLB0qTREUrekV0Zeb6jeweVMRlISdH5n13sKrmS1qXr3TgHsAFF6M5c4hoOyGSTvkwfdvnSwXSkQoCvYgK4Jpa6Nc/x6nx5MR2bc310RCAK3kAKZUGo5mn5axdZSzjlRr1IbjPcT0HyG8Tx5S5ojqQWFf9oSslCjR3fL/BT2yCCMXh+QYz5USmY/y2y24i/45UnZvU3mMEtuwVtegV8dVJ2SGPWB6x7G6fCDdALBefXofy5p5W/Jz/E8AbxmUr4lgtSFiZ3+OV4dca2qAa8rb8AY1jNZxYzh9Ov6XmvbxvJVkgFgHkV60kV7AEBXoii8MdfoSx0LH8SaSxpvo3HyY41jAhRsaHV/v6LNzgrdcH/eDPpq4q5fJTgKwU3esAbk3Lza3GmRpNlxVdcS2DiQxYcvW15Ik5+GsQLC4Qt5nRfVAEq9FssNJiJ1grfwnE9K2Gh/P5JVX91V79jcA3G1duDR7ViOOsjFeLNcWMaL2e6alEZ8+IpqJKzJjkgwNhRyWCchtpkPA5htVtXoHcfGMpHNJT2G0npP wBMes/tq 5G0/htbjn4EzCUSV+xaR2v5lQ455HttpF6bxcEqXkVIUz3HlKL7oOMPY4wzoU0moc04dtgHcZ89aqhZE9iSjpo/RV2E82TW5sBIvOTsx/ZVvoBW2JGA7aSiBUtDsivU0zBboy2NYEoQosjsRolGlCTZLUoik5TOwo/xYfU26L4CKn6FTylWnyPuCy84FYThHRHg6amod2IGl+br9ghmFoeOHlTgc3qyTbmTd0spnt3ez5rd3SDdQKIWNcfxNQ2K+slbSQuBA3zMDNalHWB0X/txQutGE4dpbawitl4kYrGiXGQKJD/y/WYtrATo9xjPcGHxrmJp5N/u1ZJc2Z1Pc9QwMqRsY6ef4d3kY136fdC6WwfIUe9sKnOWsj3vVfvQJ57mBD+hsmAGFqVSfP+YRmmnPpqA7DCko7jUD1I8CRZSBr6Mr/Jjs+B5JK4PuX45F4qArh6TONCE83b3RoQ8QtdaEvM4CbmYUQozjTu+BU/3+x0x0V1TCfz5v9GTq/fzq+QEaCpOmRxcBlsIEYsKG2f34h4GmiwXLISKPjgpksFHBycik90Qerm3oKUbmroYMoI+WqAMZLIPjB8fv0d0u9+3ldfCrsG/8NoOq8NbaRZ7VQHe4/pXB5fLU0PaxtbOmOBfWXaWyFj7foBsPvlqwzahS+pVcDiJqMvSFkXvyMXl9LrDA3dKZ04aKKVXEoLql3P0DT8mR7rx5h/XW3TXmGYFOOEjVzvR+aUPzuhtI6/iBrQQjqhB0tMfP2h+JMPfKqiPbL4X49b1TiP9QzZ/aZ9rdEmsMX+YHg7x6plwRPZgjFn07+iWNR4XsIg4CDl0O0UGNWPTeyq5zRYOF+FVpLgzJLPhbugndXAhKqR7WB09SePjEFnQbGIzdqeLjMuhWGN3CQ0bnNerWjYK4Yggd59+o158H9549hMubx2lXEHArVaWOFKNm+0TaOEKhrLOj6DpqFOsCniCswwXX3gLoCSDtpL3Xc MvACcNzW nOeFyhjJhAzCowR/06o6RABm22JEKKSaooRQBGApf1gdUIEBs9ZYfwyMso9gd2gjuSBx4C/9QeZ7xdwwlErWyLtmMvx2FHz5jUAa1yomnyYlN0oCv7WN6Fw5OBTatiDl7PG9aFMLmaT+tXSQcpYf4XUeCForkJB44ysygyqOlsnAOdzVkwtAa4AtDJCTayYKKdFBeMTuGS5uhAkv73XycfmUSnzlG9leQrHSds/NEMZLJmpXa59/caeuWAoFNB0r1+YeQORa4jl8Wbob2vSCByK+S6wUnHTiym5Pu/mfWuO3JtsWOfrCKx0OMF9fLiRW1rOAjwm+FySIkhYRf4VcCvvIChgxrleblVShib48aUpkaYwzeYOhH7dgLvpnKviqmSc3BjJHQ7tZZCLatoGugMA0i3gNT2hJzJB1/0YuAAenaf/fUp35UrgCdgy21KGlQ76KoHAFFcHSMKZCCwRscMXkasqjAz/jH3WWSpNK4k5oI8Y1O0jCBTpO9x2uibGqaIGQIAm9cfhAipYVznkSiNN69tyzYZyme2pumayC95C+7ppZz2h71xRZ91lEccmT/is32rxNT1BNK1xqQ4pq+IHlBMvmVZhYqsqpAAemdo6s/Sft8erqgL0llYZEHFJxDWrhXYLaiFS7k4cO/zS74jLMrYImRkexfZ/1ht9nyCbtszWpxZRYoqBbPDCmwwCRmAeWo1IafNK/qrOAt4TenloLwUDTb/4eBAleLl4KlK/7xK0ZhKdk9KMvVfWxzYVny3H63upIZWDlZUwgX06nIX4eJqYDdkYT9VAEY/5W/uSNcOZfDAY3AA/RR9zXxeqE8I8wvXv+CDEbLkguuxyEEuhfrJccTe4MAlUQTpUQhBtEkbE3D13UFdI2PWeH6ZoBqYOlZ38I+98VoSQBYgtEQGMvDBUmtgtnjtGauqKBufpVzvvyxFpoejb5tMDiaw2rma/5OFWsYEyZesAZT/tvd3vnFqeZt SkRXCd1K IIeOsY5j2SYLuFKwR1Pm6toS9MLv5A9VxTXEejjHtwZiO1uuvHxkvHJkAjyDw9mfi6+XV4ydh/CPw7AXA1+NSW5nkdEM2QasiJx5tAAUhlfJivya1x8VnKXaY0BsVY8iGBSBxjVu6LISdeSJ3O9LI2+VwuQaowpWLbEdgRX+nNMkDyHD7F/3DuarCyGMphki4Z82Zs8TIFLBW2Wd+2TqVSXfr5W5TiwM9M2Yhba1fVdztD96AcmKlyNAIz8MJvWtQA2OAsFkcfAFT2RJ+TawcAFhaD9XS/CdNSzzteFsWx8Z69Qi7hccP8Nrj/R+kwoKqLWrpSqpqPruphwVZbGsrBOs5ajSUcik1/wEUHR2nQv7ekT/hl2WQSjXVCZQCJBuDdN+14iNK/CtWkxXDK/6eiyLhR4RrrUt2xlwgKeLebRXkJbac07mXwy0cVo58z1kbEnljZq1GLH88c8vmm+G6AoOwXcg5/n99sf8Sl4TtlWReEqtwfCnjlrZrG5Y6PJiedkIj9WRjUbxM05Vez8omBdJyAtcmW2P12tB5LfA0Bkt2j1OUAeywqBO4zks/pGARmbNqDqzeNcBQM3My+rF4Wu2PkYmLJ+boTM3UgKrA1meoBHdt9h2fOBeqdh/E2VeAd/LMjkymPrCtkat8BLfGjduDy+XbWht6IvjYB+S5rvpT8236LF9kWvjFDb6726sF7Gx7hznH8EZLnQeLyY9547yCtwoWvWk6dQahN4Xpr708w7YT504+KsrR1+BTUpNl0S7LKZFaFp4NSAeghOt9GhHUAbH3fS+cW+m6e2MsmhYg3lUctYp/L1bReknDIECbSRW+9BW+gHYBzIh3gbyYMwCsvKHi+TOkZMn+xvw7lM1w7m7Fv22DF1Kkgv6WQMvQFT6yuhKyi6CnbSlQ41g7jUGjhFpuDvLAnusFqnH060EdOrU+xONDQXTIY1UM9nD3XIYSsSCrnKePuiFUq3H1F1eNLwjk bvr9ZBOy Mxtgv9/tVzmCxpaCZs5U8q02Pht7kLUbIk16VX4x1yHAgaTUNDZJ+HOwlOw/adNaPRKH9CJnxIXNxacE3oSRBc+lUVop8VwrJktfp5E9KQDLMxXS+FEy4CGjQ11lG7661KwBWp6bStDW1rvw3DaO07vawi23cy0hhTaL+bRxk5xHb7POYTMX6SVC/TrcwlL7Hvp8WSKtrJJdwBycd3zg9i+N1j9K8Lh2fPspaqdvWuz/R395+UVWqtQ9YCMh2dLDTj+fVciA8LCIc3EOrlWWIDT7eekBBnQK/jFjM4Cj7iozP/WPU57uM4uQQ4V22Q1kHtoRlzN6Jag9WcQ59S12qQ7Q5VYKy9xxUyqnzzecEEYdTY7EoNLKOwRIWhrN9T/mN90vlvO4j4zoAHr/+XC8UwmgILy6YfZbA4OBQYqKmbYFjQ0GBvqLiwPBOhQ7BlT3MGpoZ9wzTKS5ZrV3MPs6UpTfzGeAmla8L4qV4Dd9w2LfmLKjJi6NDnmLPM9tY4Vm0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.013055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-08-30 at 01:19 +0100, Al Viro wrote: > On Wed, Jul 05, 2023 at 02:58:11PM -0400, Jeff Layton wrote: >=20 > > + * POSIX mandates that the old and new parent directories have their c= time and > > + * mtime updated, and that inodes of @old_dentry and @new_dentry (if a= ny), have > > + * their ctime updated. >=20 > APPLICATION USAGE > Some implementations mark for update the last file status change timestam= p > of renamed files and some do not. Applications which make use of the > last file status change timestamp may behave differently with respect > to renamed files unless they are designed to allow for either behavior. > > So for children POSIX permits rather than mandates. Doesn't really matte= r; > Linux behaviour had been to touch ctime on children since way back, if > not since the very beginning. Mea culpa. You're quite correct. I'll plan to roll a small patch to update the comment over this function. Thanks! --=20 Jeff Layton