From: Nitin Gupta <ngupta@vflare.org>
To: "minchan.kim" <minchan.kim@gmail.com>
Cc: Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] Fix reset of ramzswap
Date: Tue, 12 Jan 2010 11:00:18 +0530 [thread overview]
Message-ID: <d760cf2d1001112130p8489b93uccd6a4650ff4a4a8@mail.gmail.com> (raw)
In-Reply-To: <1263271018.23507.8.camel@barrios-desktop>
On Tue, Jan 12, 2010 at 10:06 AM, minchan.kim <minchan.kim@gmail.com> wrote:
> ioctl(cmd=reset)
> -> bd_holder check (if whoever hold bdev, return -EBUSY)
> -> ramzswap_ioctl_reset_device
> -> reset_device
> -> bd_release
>
> bd_release is called by reset_device.
> but ramzswap_ioctl always checks bd_holder before
> reset_device. it means reset ioctl always fails.
Are you sure you checked this patch?
This check makes sure that you cannot reset an active swap device.
When device in swapoff'ed the ioctl works as expected.
Greg: Can you please exclude earlier 'Free memory when create_device
is failed' patch?
That patch is correct however, my pending patch series conflicts with
that. So, I will
instead include that fix with this patch series (and add appropriate
signed-off-by)
Thanks,
Nitin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-12 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 4:36 [PATCH] Fix reset of ramzswap minchan.kim
2010-01-12 5:30 ` Nitin Gupta [this message]
2010-01-12 5:48 ` Minchan Kim
2010-01-12 6:48 ` Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d760cf2d1001112130p8489b93uccd6a4650ff4a4a8@mail.gmail.com \
--to=ngupta@vflare.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).