From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E145FC7EE30 for ; Wed, 2 Jul 2025 00:55:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 185678E0008; Tue, 1 Jul 2025 20:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15D8A8E0001; Tue, 1 Jul 2025 20:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0247F8E0008; Tue, 1 Jul 2025 20:55:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E5EB28E0001 for ; Tue, 1 Jul 2025 20:55:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9793B8066F for ; Wed, 2 Jul 2025 00:55:28 +0000 (UTC) X-FDA: 83617506336.28.D42BC83 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf07.hostedemail.com (Postfix) with ESMTP id 7A87040007 for ; Wed, 2 Jul 2025 00:55:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=U7O8R+ts; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of sohil.mehta@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=sohil.mehta@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751417725; a=rsa-sha256; cv=fail; b=2svV6TGm7sYENoY1a5igL1SZDp4vVz5aguSTf7cVJOaY3+CNTLi5V3BvjstpUut9FctlHJ LsNnWreIC/YSzNHGvix3FVMMN5pdwyq6kyyglb24rr4raBEwGko5IbMlUi6S1sGQzWCKXA /6pNPvqy67xqoby6GguCASlI2b3QxSo= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=U7O8R+ts; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of sohil.mehta@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=sohil.mehta@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751417725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=94TSLge/MpE6gu4B+0gYGXDwynEJaYmghttopy+0u8w=; b=OrV456C/Ixpi3DD0h3TiZHE2oFWJI6FiSRlRHDehbIzfuBZixeHpOiyQzQupmM9ycbc1/4 ws2FX9BsUQZJfP7pcVAJ4s/wvQypcCJNEIP5Dt85npoCoXNaV6jEHEyHAPADVZOXgqFaRo /cs+n872uGTkd8Mjjz2MDRDJmRwGowU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751417724; x=1782953724; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=qqaV59dLgaO3xaEgX0wMVXaDkwXxR5hwcCBTLqXtoEU=; b=U7O8R+tsNCq39nWvraYrLPcXAMiJL1egNyFPArfJ/Sg4jlxhCdyRjMum SNqV0ZlV/UVhPy1xEKL23L1vDVDPhvqXaEMfaTHfaCnxiP+qNEmlM3BNF b7KvktiP0SqD7gX2T9tuBIBQoMGlgydkW7YtLV8/DQmjqnReBXTm6ilyb qHgDdChyv75KsdV1osWzMTSPPnPcx2YnwsIqIGFW3dg3gOTqLqZ2Pkvhu 6j6iORlRNfQ4TvuCVZ9kMrdvq7afwWweCdxWLEyARwVvD1Tir5UE94eDr 3a2P48K18cykaOTMMxXzQ+4WNVVfsSWWLygfOFuzY/3wZX5HkV1m67nkE A==; X-CSE-ConnectionGUID: c5hWAd8bSpuZcEH77njO+g== X-CSE-MsgGUID: 4fCg7IbIQHKJdsdD5vNrTw== X-IronPort-AV: E=McAfee;i="6800,10657,11481"; a="53791066" X-IronPort-AV: E=Sophos;i="6.16,280,1744095600"; d="scan'208";a="53791066" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2025 17:55:22 -0700 X-CSE-ConnectionGUID: rTH68FldRzOnNywyXx6KeA== X-CSE-MsgGUID: ZBZxilsYQi+Dt7+UrEDH9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,280,1744095600"; d="scan'208";a="154469058" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2025 17:55:20 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Tue, 1 Jul 2025 17:55:19 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Tue, 1 Jul 2025 17:55:19 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (40.107.94.89) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Tue, 1 Jul 2025 17:55:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FdK42rei0IruZ9aRyS4DKqxYki3o7fwpkIN4Kqvqj/At3FehxBimCOmxvf66F3OVXwDqjOVBe3AfEjjuqiycFE4waFQezz8p6X0eu+LRw/8yArsp4oVM5o9GzeuizZgHuGObNdtMvCxXeui8uQoSBzJetc0fQ0q8ss5ObhoYcRwdKuqOJ2MBYzsqThS3Qk0ONnD4r88lUnjg1mm1noM1mKaixv88rqNCu9RfbQ9Z39QhDxXl1S/pboOw/IhDgi9JMuSfz7JmUhhQ46FQvCLKkIlS87CJV+z1XiRDyZGjHh93etxqj7kTboEc8V9YIxaLLOW7SDJU1eyBeFKaSEhsEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=94TSLge/MpE6gu4B+0gYGXDwynEJaYmghttopy+0u8w=; b=jrJVdbYBRIN12GknKckDVYB7JtbMpFBAC6vVreG4eD3ADpWkcoZtXxnPYnKS7lT8KdD+m/Zg13zmBiaVL4wQTG9FZzAWarpSDt/KXXEMSMrsKf1u9F42+FvrZKN2QY8rgIQeZPGofKBM6s6n4T66kwJ9MtW6ZH5wSwoilzZltymcrHRCZHeybfTCbfoM26nyCJeMdreE1/AQJ9tXy5YNIO5a2ennCdP1Ad+elLDQA4t0m2aFnl2fglHX7KPUyEkglbMBt7jkAX/j/YUFMy5rZflyCpuPHfuYovvpQSqYzE7SdtRsqdflIxYPzlsyQaRckb4B+Nu2hQ6zhTjcnOl4Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) by DS7PR11MB7949.namprd11.prod.outlook.com (2603:10b6:8:eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.29; Wed, 2 Jul 2025 00:54:47 +0000 Received: from BYAPR11MB3320.namprd11.prod.outlook.com ([fe80::e8c4:59e3:f1d5:af3b]) by BYAPR11MB3320.namprd11.prod.outlook.com ([fe80::e8c4:59e3:f1d5:af3b%4]) with mapi id 15.20.8880.027; Wed, 2 Jul 2025 00:54:47 +0000 Message-ID: Date: Tue, 1 Jul 2025 17:54:44 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv8 13/17] x86/traps: Generalize #GP address decode and hint code Content-Language: en-US To: "Kirill A. Shutemov" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin CC: Jonathan Corbet , Ingo Molnar , "Pawan Gupta" , Daniel Sneddon , Kai Huang , "Sandipan Das" , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , "Rasmus Villemoes" , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , "Geert Uytterhoeven" , Namhyung Kim , Arnaldo Carvalho de Melo , , , , References: <20250701095849.2360685-1-kirill.shutemov@linux.intel.com> <20250701095849.2360685-14-kirill.shutemov@linux.intel.com> From: Sohil Mehta In-Reply-To: <20250701095849.2360685-14-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P223CA0014.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::19) To BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3320:EE_|DS7PR11MB7949:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fa2efc1-619e-42d3-1f6a-08ddb9030ad1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cWtPdDV6R0NCbG1Pc09OSXNxdEVYQXFzNEdQL1ZSeTQreDhhRHpUYWtVc1da?= =?utf-8?B?LytKM1d4dWNvajVoUWZyYzQ0V3dER0xGc3loRFJPelBydndKS1JkQTdMSjBo?= =?utf-8?B?YVhLVWw5UVlMNzA0a1J2VU1zZVllOXluWkRjbnJvZWw4V3JkSmNWdXJTdXJn?= =?utf-8?B?L2FZcGt3VE9LSFd4dlpwMHZzYUhrN2FVL1pxR3l4Q0J2WVFCUVBNa2s4bTh2?= =?utf-8?B?WHlhNHJOdzVTejNET2ZhbjA1dHhpcnptMlpXa29KWC9oYW5PcnpVNzZnMmIy?= =?utf-8?B?dzk5TlJQQ0lvRzFxQ1F2d1c2cnB2MjVPRlNMRjUvQUNnZHFvdWNFcWNGRzRu?= =?utf-8?B?dEhZNGdQWjRoS2crM29ZUXk3a1JYS1JkZlB0eVN0UE5kbCtCQ3I0SG5TRUJL?= =?utf-8?B?MnhPODI5ZzhGV3J0aUZ2UmVkNDJLdFAzZHM5MFB1M3RNTDZraXJwc0djQjRy?= =?utf-8?B?dlBLaFA2SktOY2RTTkZrS0s3dVNiTFlWQ3pNaHNQQ3ozdEgycTdOMldMU1Ax?= =?utf-8?B?MWlNUHczQjVlK1ZXMWZjS2dHNFhxYi9yRHp4Y3M3dFVFUHh3SU5JTjQvSVZI?= =?utf-8?B?YkZTT2dhc1QyQ1ZVMVBZT0dBOGltUWJpREZpREFMTVRzUkRDK01XZlpXWStt?= =?utf-8?B?Nk94NVdLcEtDYXBwYW9SMlVvYjNHTmZ2UExmRnY1RjN2dlZ6WTRNTW5hY2tw?= =?utf-8?B?VVZMeDU4THVMdUtPZlZIMVFwMW5ZUXowQTNSUEdsUzZyRVIvcWJZNS8vdXY3?= =?utf-8?B?ZkxMT04ySjNCUXRqMzFIMFVhdXlrOVRmNGRBdEoxSlZzbmRLQTJaYVNkdWFv?= =?utf-8?B?NU9XdWhvLytRbFN4RDdZMGlDOTB1YTNSQjROSFluOEtVR1d0ZVhXa0VHekg3?= =?utf-8?B?OEQvaktDR05nM2lLbkRmUkRobWdxRmNoNWhLOXQyOG9pa3Yvc2QrL3BMR0Zk?= =?utf-8?B?OVRwT0FIbXJFSXhZZXdGOVcwaXJET2RFMjI1Wk9IUE9QZ1VYdWc5RjdwUFBI?= =?utf-8?B?RXRKSTZFTGVzaEgrLzlReXNZSFRRSUE3S2lBQzVsRTRkUFRJbDlmdXFqUE92?= =?utf-8?B?YXN0WVhUeTRTalRMTHNYU0lqOUwrZk93aU9wUlplWU9HNTFVUFBtVHdSNU1j?= =?utf-8?B?MForNHB6Si9IdFpEMStvTFRuSUcrUVdIWURHd0FUMnM3clRyTEtva2d4VGtV?= =?utf-8?B?bDFnVFdyL3JLTXNyeStFc3pqV3VhNVoxVGNPVnVuQ3NzTWZ5SjlEV1BZVHhx?= =?utf-8?B?VjZDekNLV3JKL0Z5NzRreE9rc3IrbEIybnIxbWtkNnpIUTJGc29SVTFvb21j?= =?utf-8?B?UzNqTmpPSFhYQUV5Umw3MnR4UGhiYlVHMXdIZzZRU1p1cUpoQ21rcURSSjh5?= =?utf-8?B?UXJRcDBvSmJiN0pJS2dyTmtWZ2ZEZjJCWi85T3czTmhhS0tUK2NQZW5DMlFa?= =?utf-8?B?N0sydW9VaGVYUUk2Y2FxNld5U3lyM2J0cVI3NUVMT1Q1QmFPZjVmMU1CaVNw?= =?utf-8?B?amh4OGIxN21TLzhBWHdBdHo0TVVhYUM5djhiU3BGZkVCMG43TXZFK09VdWZE?= =?utf-8?B?b3k2RnhRRzUzVnJhdzhrUDRBWHRUQzJhNDVLdlVYdjFVYmRFNG8ybHJLeU05?= =?utf-8?B?d1ZDTEd4MEtrbUZwM2JISi9GK0hWOXIvdE45ZEZQNVl4KzhETnVwUjBGcDBn?= =?utf-8?B?Q2RQeVpHVFJmeEVaTHlOZDZSRVBza2lPdUhvQTNRYWJDdWVabnRBOVFQWTdx?= =?utf-8?B?WmczaTc0OXBqbGsrYWw4VUdlMzRhUkVlU2N3eHVRMmI5b2o5bVczVE9NbUlx?= =?utf-8?B?cmw2V0FVNUE4SmJMdXZCNjJzSGlsNEVFYnZ1eUhFVjVQUVc1K051UFN2YjlQ?= =?utf-8?B?N2FkcFNFWlRadStYbjhZcmNISkZHaVd2UzVNb3F1U2tGUG5ZdkdYMGlKdGxz?= =?utf-8?B?MmZjbmxKSi9QOUN2RDFkRFNDWkdHWTRHczlMRmVUa08xOCtBSjB4alV6ajNZ?= =?utf-8?B?T3hXYU0vTlRBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3320.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SklodjA3YnpENFp6cmpXL0JvQVhMQlc1OHlwTGg3cnpvWlUyV3RjZGNIK0RS?= =?utf-8?B?dU5BazIxUmt3ZTdlWi90WEpRZmNFS1ZTTm94aDArNXcyL3hqcjhUUE9XdGlY?= =?utf-8?B?T2tMQzVjVlhXV2ZsdVVmYytUWnRsM2lYY1JBZUdFZXBhTmJleWZseTVCYXNM?= =?utf-8?B?MVFNSWloNTZWOWJ6TlExMy9YcHZQUjFvcjJWU2VQNmZDdTJnN3RZRlN0bURu?= =?utf-8?B?VlVJaDdlMmtkTWkvNGViWTAxcDVqMHFWNzVOalVteFN4TjFUWHdHV0pWdkIx?= =?utf-8?B?akhSZDBTanU2amNmT0RycG9NOG9mK3VVcmFWQWJhaGFGTkFCbDNpc0ZickFi?= =?utf-8?B?WmZNQmFjaUVQSURvSU9SR2oySzFoTjRBckxPWDhVWW1Ba2F4K1VaMlBERFF0?= =?utf-8?B?OUs2b045ZzQ4NGV2QWtoTnlma2MvV3Ayb211U0VsckVza0JBNU00UU95aXhO?= =?utf-8?B?TnJPTFFXRjhVTjB3Z3Boa0hPZ1ROaUgySFR1MUNjOGg5eDFNQXA4bmljTnkx?= =?utf-8?B?S3lQMzlTZXNqL1JUSXJ0K3ovelJMLzYvWjVsN0E3Z1pIOHJaQWg0MEtUNW54?= =?utf-8?B?SmNiSWcvSXRUc1gzblllL3ozQmFaTVloVTc4REc1akpVSG16d25DVWJZRXhs?= =?utf-8?B?TkFOQVd5azA3cmxiclg2eVBSMlhjNHNINW1OdkhBN3RqWFVwdUYyMS8xZTYz?= =?utf-8?B?cWptYkV3aHpiY3FKdktmUXBpS1l4TER4Q0haS0tUeFhReE9UNnZqaWNIaTlO?= =?utf-8?B?UVM5Q2RLWmEvcW5CcUt5Uk1yZjRvUW55THVZQkUvbEQyaS83YW9XanBLV1VI?= =?utf-8?B?OFFYWXZ1RFRQbUxVMHVKQ0ZsL05MODdMdWY4L1NyTUhKSFlTaFB2NVRQREs5?= =?utf-8?B?b0x4N2FhckVWdHROSTVjMzVhbXVrMzFSaXNqNU5Vb0k4cjRGdk5FN2VaTVBy?= =?utf-8?B?bmk5SXk3Q2VyVVYwaHE0eVM4K09LSG5YOTI1VFpYTDFkTlJ5b3dvWVc0bCtl?= =?utf-8?B?T3U0aGowZ3JESEE4bVRQK0xxNW1KeXZkdnlSeTEvR1YzSFFuay9RWkpqdnB5?= =?utf-8?B?dVRlaEVONzhTRTNCelVyWmR3c0pBaWFOdTZqZ2dqUThJNHV6QVhQSHJXSStB?= =?utf-8?B?cGhvYitvZHUrdFBXY0dYVWVmbit3QXJqSkowRDhteXhoRFdjYUsrcVhES0wy?= =?utf-8?B?bS9EUTJ1Z1FRbjRGM21kWTg3Ym5JOEI4TFJCSFQ1MHFGNUZHOFRNN0hCWUg5?= =?utf-8?B?b1poUVpwa3Q4eFRlWnU5NzJQRmRhVEJmVjQvb080WWtlR3lhbnlteTlFTVcx?= =?utf-8?B?RlJiN3E1SmJzeW12U0oxeCsvUUZ1eVFTSnFva2xSeGVhOFdxbm1FckR3cTM3?= =?utf-8?B?TXNsR1ZuMkJmcjZsaGk3TDJLcjM4ZGJ0NUpvNXVqdmFWMUJlbG8rREpWL0da?= =?utf-8?B?RDZqR05NeWREdytyZjRoOXVnMGVTaFBOTWNnMzhlY1FqQ0RpOGowWUlXM2o0?= =?utf-8?B?NVRJZExqUEx6UmJYT2RNV1YzaXhLa05jMXdvTjV3clo4UUVSWVpCTFkvV3lh?= =?utf-8?B?ekNBSXV3Vy8xN0tGMVZKVktLQk5QSlRCclZJM09QdzM4Q0Q1L1ZYU05GU0ZN?= =?utf-8?B?Vlp5TklXUUhNWXpzVlAreGpxekttT1pZT1RXMmxkU3VzN0xRaUs2dHhIMmRV?= =?utf-8?B?VSttMitmTnBINHhnOE54TWo4bytSSlhtMFE1cUtkTktsNWc2UnlDOVEzZWc5?= =?utf-8?B?VGY0UGtjNFhJbWtoVm9SYVV2aTJPc0NqQStOUElEM1g5aDUxdmFRQnB5UTRS?= =?utf-8?B?Ni9lZElYRlN3c2NxeGdqdTJMdlRFaTV3eWhWUXlBTWlpemxrTVdPOS9lQzRC?= =?utf-8?B?VHY0NVZGUnNMZktMd29ZUXljTGRnOVQ4SUpPNTMvRTdXb1BZby9uVFJXMldL?= =?utf-8?B?VE9iQTJ3VDdNWHdyMGppY0tjcXFXWWdaRWQvT05CYUFScW93OFJlR1JlMXBt?= =?utf-8?B?c1UwV3dDM1dwd1FtQXI0Wk41OGdiOXRGa2lnazM5SnJ5dlRKUXVadjBxVlE1?= =?utf-8?B?aXNlbGFvbFZDWmVyZ2g2ZlNON1J3Nm5yM3hpWkJBczZhVmR1ZWtTZG5SS1Bk?= =?utf-8?Q?9qMHA2TUBu+AzNTEw3baTX5j7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0fa2efc1-619e-42d3-1f6a-08ddb9030ad1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2025 00:54:47.5744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E7gTw6uO2V3Bvhpt1lBjy1bEfEe1mHyhcj9Hl7000zbJ2DloIwEvHPp5XSlYjXJ04bLW6TJO9atuIPwfiPXQvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7949 X-OriginatorOrg: intel.com X-Stat-Signature: m8ynyiw5f91zym4gzc3gaiknwdg8ck78 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7A87040007 X-Rspam-User: X-HE-Tag: 1751417724-689011 X-HE-Meta: U2FsdGVkX19kAGgIopDWdv7aWB+JPO9aaUE7RcQnM+gIbhjuriRm/6Ao7nVVpvUyq+ktK3AnrF1wP4MrSiD+05RbGPZ1ZmatS8YmR62f1GUletlCg4f3IwQ8xg9hjjSK4aSE7iNlgaal7EfsbHcXr5knT/FY2rmDSnZUEi55ObjAXQc7myDGJFl6if5KP+MUmwLrNJMgvkAKM05YBw31zBd9O55YB4m5vBeEs6dS9sVbf+mzgTKdx/VoAd4pWP15irOsZ/RNfPt/uPOBqdAXBi06F/7P3t0lx7atk7YLTwOnqnXONuGpN81jgiGgFgLbSKDQe53GQGc/vRa0KBxwiIDFvQyS400woYc4Hw3+UuEFT9sBVdf8co5VElQ7IU1MR92/i1S60IiBBNzqzMbHEgDprOagIe0mVYG8rJRNp1WythUrUphz9cg5cHXBWLQba+wvNeGeyD+n4zhWPqs72pi9E+VMyK0XFfxI8rrpm9wDaTHqJjs+LnDkJ+5YeIYyOfHfwLZTxYe7ErpDxAK2jWOO+RidlsEVjwMat0NcYreTwzYi4qBAFuqkBiQeU12IvSdL/SRutS31dDowqMHklOVdrpzkBBA+kQWpE62UwG9vDpJ5G2B8+Onrz3o+efdJyAxQlXgN8L9OGOqsMrX72hX2zSNnqm+e6tBJkuTNcH8d+/sDuXq7DETNYWwsq15UP8zoqMobgv1hB2tponcWgxa3lqPrzL3nSURMVfGabDptrpUMexuZVg3+sOw5liuqbarHzx77oIm5oducTO+tdxSs7tsgRkm6gDR4rdLQv15wkaiP+fnbFLgSuhIB/jqK31UoLJ7RqKBQVkdBbeUjbdAeJFxrc1MvEoJakDfwkSTdbHr0I4QDmiy5YLDTJnoJzJr5jcRyJHaxL+PEFvWKSGVMknzSSDR9ANxyHKlyPxjDy2eLBRqojCudQJWR9RBN+l8Xsq99bG/jVlw4b2C 5SJTakbr qSk09Gw1tGgdVino5hDZk9T2RVD4HXBO/+0LzNHgclNmaZ3vFLln6VtAr2ofiIqa20vp7SoDiQBzKlSjRyPdSM0f0fKQZ7urdK6cI9UiOHIv7rvQGxkG+c/uGHK8edeexWRIpDXT/M8w9Gix/14tx4oatz+RPfUMxjC3kn/kX5z39J1Y7a95ZE7/KsilwYy/BYf5wKIEg1Olm8R2klFsVzW5S2IT+IPkFOveVICuQoJpAb/lkXxXFhkx4uz9wSrLRV1qxqdgvksRuqx4CYP8/uvPFDrdJaJvj5nEyDsryjygszhu0mtSWCeSteKxiargsggB6e9YAPTHKV3mOoznJIuygLHqZeZFE7PNekrN5dW2uc0+cO1sF4eErwoWYrgWMd6auE2nrtHvOjbZ4sW0fImQoudICD/jkZ2DLboMgQmsPzJ6wc9M8I72uMQPpVeS5LJlUfPIoWTElJ2urhPOJsJBFuMskHqa+RGIlwHllz6dmCLN58lB5xMhxbUNfihHBkjVHj/2r4W6qyR1AMwJ2ZN1qWrQ37al5uN+P9XrU5TAc9hxk0A4uuVACSEcppQn5ZUIy07FMvPfeqt/oYlKG+0S8KD6FL70K1GWsEC2dMu+wJgo8yAx9G+Koxj1+Ks6XaQb3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/1/2025 2:58 AM, Kirill A. Shutemov wrote: > Handlers for #GP and #SS will now share code to decode the exception > address and retrieve the exception hint string. > This is missing an essential "why"? Why do #GP and #SS handlers need to share code? None of the patches prior to this have hinted this. It can probably be deduced from a later patch, but it needs to be clarified in this one. Maybe a simplified version of the text from the SDM: "In most cases, an access causing a LASS violation results in a general protection exception (#GP); for stack accesses (those due to stack-oriented instructions, as well as accesses that implicitly or explicitly use the SS segment register), a stack fault (#SS) is generated." > The helper, enum, and array should be renamed as they are no longer > specific to #GP. > > No functional change intended. > > Signed-off-by: Kirill A. Shutemov > --- > arch/x86/kernel/traps.c | 62 ++++++++++++++++++++--------------------- > 1 file changed, 31 insertions(+), 31 deletions(-) > The code changes look okay to me except a minor nit below. > #define GPFSTR "general protection fault" > @@ -808,8 +808,8 @@ static void gp_user_force_sig_segv(struct pt_regs *regs, int trapnr, > DEFINE_IDTENTRY_ERRORCODE(exc_general_protection) > { > char desc[sizeof(GPFSTR) + 50 + 2*sizeof(unsigned long) + 1] = GPFSTR; > - enum kernel_gp_hint hint = GP_NO_HINT; > - unsigned long gp_addr; gp_addr is a local variable to the #GP handler. It can probably stay the same. > + enum kernel_exc_hint hint = EXC_NO_HINT; > + unsigned long exc_addr; > > if (user_mode(regs) && try_fixup_enqcmd_gp()) > return; > @@ -846,21 +846,21 @@ DEFINE_IDTENTRY_ERRORCODE(exc_general_protection) > if (error_code) > snprintf(desc, sizeof(desc), "segment-related " GPFSTR); > else > - hint = get_kernel_gp_address(regs, &gp_addr); > + hint = get_kernel_exc_address(regs, &exc_addr); > > - if (hint != GP_NO_HINT) { > + if (hint != EXC_NO_HINT) { > snprintf(desc, sizeof(desc), GPFSTR ", %s 0x%lx", > - kernel_gp_hint_help[hint], gp_addr); > + kernel_exc_hint_help[hint], exc_addr); > } > > /* > * KASAN is interested only in the non-canonical case, clear it > * otherwise. > */ > - if (hint != GP_NON_CANONICAL) > - gp_addr = 0; > + if (hint != EXC_NON_CANONICAL) > + exc_addr = 0; > > - die_addr(desc, regs, error_code, gp_addr); > + die_addr(desc, regs, error_code, exc_addr); > > exit: > cond_local_irq_disable(regs);