From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E4BC5479D for ; Mon, 9 Jan 2023 08:04:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C50258E0002; Mon, 9 Jan 2023 03:04:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C00968E0001; Mon, 9 Jan 2023 03:04:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA1488E0002; Mon, 9 Jan 2023 03:04:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 982D48E0001 for ; Mon, 9 Jan 2023 03:04:52 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 66E721206E9 for ; Mon, 9 Jan 2023 08:04:52 +0000 (UTC) X-FDA: 80334524424.09.918CA2D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 5EDFA40012 for ; Mon, 9 Jan 2023 08:04:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e8fj0Vtr; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673251489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SVp8yLY7DCe2qLwsvuHHLAbl1dGoybQYwVuHEDJuma4=; b=IxrLWETaXJxeWSEj5A0rp1ndSN7S+/Fi0ONxr9iHYRBdf5Wq6OZayASpwVoccjjb7OIb+I VikhLh/TCHK5M4e81rUB521NNRX/+Jj14xHUTWjjbLH4ANHDWGgLnjduO2rphS1RdVIVHt bROlN/WC4epeCOL1ZHms7/hOMxtQXug= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e8fj0Vtr; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673251489; a=rsa-sha256; cv=none; b=cCcy2wW2H6pnIXz8lwwDtzcUFM7otS8YaB2OkyQGSNnwLQqL6voe0Kp3d+i1e4BIJ1OL23 MCrsyn5N6/T8VzQkVf47FsV6hlIa7N4fxpLDs0zy+0uhj7icKPEd1YmMcLIn4BXpRzxVLI TXQp+uvJXtIJiBgsygFcyvylRXZXTTk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673251488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SVp8yLY7DCe2qLwsvuHHLAbl1dGoybQYwVuHEDJuma4=; b=e8fj0VtraTkIAf5iaEHCI2Pk9jq/hO7DzGuYx+pmHm7tkDTQ5rQo2Vr3FXsUbop1HKDB8l Mtmj0NWOcZhRECnS0wFJuQPwJOURdSbIPUvl6KZQRIT4cplXr3WbDBDZ/MAtILr5nWt+xv AGTyZivUoYv64FoHPil2p27ZOBmYQDk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-627-aRuV7XA3NMqrEVIQFnvWMQ-1; Mon, 09 Jan 2023 03:04:47 -0500 X-MC-Unique: aRuV7XA3NMqrEVIQFnvWMQ-1 Received: by mail-wm1-f72.google.com with SMTP id l31-20020a05600c1d1f00b003d9720d2a0eso6856424wms.7 for ; Mon, 09 Jan 2023 00:04:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SVp8yLY7DCe2qLwsvuHHLAbl1dGoybQYwVuHEDJuma4=; b=V99m4rO/K+kkD88xfbA+lVtChsD3uo0hjEsxbRWR6jj161HDXIfbdoIMYe10y/32Mu q0l6JxVC51KMsxD3uwrtn1zk9gaGyFaJVRUq67GE4xFHFnUOFlDKkkv5HCggnRzK1oui NY0JUI/lcU655L1QdVw9uSKjzLqItvZX9XljnkqIvCcYgd2b8eUXCran2a4TiaS+LXmo BmLEh+FSI8qBAa0s0pNRVs5gGpui1cgH+s5gSBwq4x0gI5ZkM/xZln/P7cjzMhyHJZYl jKApd9PdjJ6c/GwFkfGSUvJ5X9Xi7cKMcaAVsWiNMnBW9CwaiBwARJtyEXNqe4/gRn54 89ew== X-Gm-Message-State: AFqh2kofTIKkcuybfkPX/S4ktdbzOAaUlhvGtQ8fJuZwRlnDQ0WnKvX1 2GY3/swUip2HzgvnKHg2WuT+qZOGZ/OZhJOsAnLkKXwjM4BlNb17Z5Ty3k3d8UZSVW0qjHds7Wu uthMV/XiHV9E= X-Received: by 2002:a05:600c:3ac3:b0:3d1:cfcb:7d19 with SMTP id d3-20020a05600c3ac300b003d1cfcb7d19mr54883744wms.32.1673251486356; Mon, 09 Jan 2023 00:04:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXuEIbEs0BiKh6OBaBy+pLrnxzSqTb2/JpYfXaQpIO4/gJWRJT1WYGNbmyhE0+56JxjRsJNzdg== X-Received: by 2002:a05:600c:3ac3:b0:3d1:cfcb:7d19 with SMTP id d3-20020a05600c3ac300b003d1cfcb7d19mr54883732wms.32.1673251486123; Mon, 09 Jan 2023 00:04:46 -0800 (PST) Received: from [192.168.3.108] (p5b0c66da.dip0.t-ipconnect.de. [91.12.102.218]) by smtp.gmail.com with ESMTPSA id e18-20020a05600c4e5200b003d9876aa04asm12410490wmq.41.2023.01.09.00.04.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 00:04:45 -0800 (PST) Message-ID: Date: Mon, 9 Jan 2023 09:04:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/3] mm/mprotect: Use long for page accountings and retval To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Kravetz , Muchun Song , Nadav Amit , Andrea Arcangeli , James Houghton , Axel Rasmussen , Andrew Morton References: <20230104225207.1066932-1-peterx@redhat.com> <20230104225207.1066932-3-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5EDFA40012 X-Stat-Signature: hkabbs4kge6ibiz8cj94856q5bny176e X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673251489-190641 X-HE-Meta: U2FsdGVkX18BmNnTX69TdczxRQP1D2ctbTBp5QNZhvgU7jHrX0BenBCRG3I5g05NXRIoOFTZp31lw+UIIDh3NnXcuLP9gVV+MsSlTcB93tpONJBYKuEGktR2gj/gbU4S3xNI4mzIB9SoKTRySLnVZfr5N+MMnuHc19WklxdGf6th3huZMLoZIbNhv73f9V8ULrr8VPJEroYYGl0om3HWwveHvdQsWy37Eok5uaXjtaH2SoAMGF3VxPX19DOS5u3DIFIotfIemk1c7dktxtDP5Cb5rGn7MCaNMhxIqZapwl0yvqadGiZygpinnbZaDJVHTHy5YuOEn4zZ9slURwzPFmeRlTopyj0o+fWTfx/ff8oqfhJVEwTdIkwMYd9zWV+THP5kBd9DK4lAa4zrTAq20gmX6+hHjwq1HN+moUPrX8YuBKf6nfS2dkrYWeFI3YDsEQVgDuoLMIgS1Otii33jgEUttkMQ5IzTY5phObf7KEowTo1ST/o5eqAa+i4uDQS7ueS6DwCZKtBaN9/qRK9793hHQYu17/Tr06AxpwWJmAi7BIdvV0phza/bLOp4Hska7hLjguuf/YaU2WOxoAjqXc5Xx9uWPtpwc9OKtE9pF/TwjLX2rUhiNfTi/tw3rc5hXu1DDlXEST8+rYyfHVR25yKl+pG0pIVrYQDiZgWeT3WKVCWbggJq24LTbtkOoeScP3fOuT18838/Pu+dVEAvzJkG75+Tb9GTD8wL9HvIiIqKa0J+onG5OpnmKlcnIuFDkq8bReLMZsKhwY9jA4bm6j4QOuvX6p6md9jHwSoWoBaK8u473moSdmeCT+a1UwLpu+GIABNkxvETn/CDqULVcUsXiO7K/dh4xJTCEYg7A9c5lVxuLy/izlppsdwf+VHJdmnkHEfgxTlI60Jf0Jolj7yryPkwYPBMOXJFmV1ucLfImJY7jNgu/9SQ5EOsPq33L7JrlLe59rIOos5ZpvV Own9w15w TyhwiDHBruxojL6OJP9zczAKsi7A/sdwQx84vA9AZBoQFdIyfHb8+1QsK6I8B7iLHVySm5sEe3pa3Ce70Ej94ESvKPHpRoC6HnX3JWbXsi9cQ9d72L76ld3MH2Pq1TiK/+1fr04cPMMQbJ4Rqr/ETLLkWZjrHw5kprkQUaA+oDa6ynfXGN8eLg1LQKGA2oxrKotBsNotmLDj9V1ch6FI4cApUrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.23 20:22, Peter Xu wrote: > On Thu, Jan 05, 2023 at 09:44:16AM +0100, David Hildenbrand wrote: >> I'm wondering if we should just return the number of changed pages via a >> separate pointer and later using an int for returning errors -- when >> touching this interface already. >> >> Only who's actually interested in the number of pages would pass a pointer >> to an unsigned long (NUMA). >> >> And code that expects that there never ever are failures (mprotect, NUMA) >> could simply check for WARN_ON_ONCE(ret). >> >> I assume you evaluated that option as well, what was your conclusion? > > Since a single long can cover both things as retval, it's better to keep it > simple? Thanks, > Fine with me. -- Thanks, David / dhildenb