From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82982C54E69 for ; Fri, 15 Mar 2024 10:43:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF68B80116; Fri, 15 Mar 2024 06:43:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6E2800B4; Fri, 15 Mar 2024 06:43:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D205080116; Fri, 15 Mar 2024 06:43:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BCE37800B4 for ; Fri, 15 Mar 2024 06:43:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8AD47A09BC for ; Fri, 15 Mar 2024 10:43:28 +0000 (UTC) X-FDA: 81898936896.24.A154D1B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 7DC701C0002 for ; Fri, 15 Mar 2024 10:43:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mi59K9cR; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710499406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mFYTL2COBcL0eDhJwzMKJs1wuhd9ev/OLLtfRXuhw8w=; b=13gW6LRVso6bZdxsXKvw46qgj71ClWUfZiUc0qQwOBL43aw0nFO/yHEVnu2uRUHKBfvfej eiTDZX8pfDShevGvEmGvLUCpeNg8GTRXSN0iRY3K3asPCiSOa8wFJPFi3sID+21dMUcBH4 EOMdYLa2pEqyNYiV+tG5kzwoHyoOugA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mi59K9cR; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710499406; a=rsa-sha256; cv=none; b=ZtQ53oulL4QW6by3cm31fSJcMWqoJr/Wl+jv4OGEDQAsYQjMfPC0a5B4g7uo80uSEXC5IH 6RQknpXQTZWeKTg3+TWLw+GCCmEDjjKRfnoLRg6YJwgb/MD4y4Dp03xAD74ychYi8By6Tj jpA9r+4b1eCJHvZEbov7M6lC2pQV65Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710499405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mFYTL2COBcL0eDhJwzMKJs1wuhd9ev/OLLtfRXuhw8w=; b=Mi59K9cREHOD9aXd6FcIjZ9SbPgeBfWb42f3sPn3pf88PKivX1Zp80SMVAKXBKb6bOjONC aI4SGxscbBoS54PAfz/uiBgd/vQGz4qSrl92NO+KMduusTHxAojcqLC73E5cdS1IKZpdCp 6YRMzC7+to7sgeLlaZfBT3vK7O4kpkc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-vQ5SPyZzNb-Aes_TqDdNcw-1; Fri, 15 Mar 2024 06:43:22 -0400 X-MC-Unique: vQ5SPyZzNb-Aes_TqDdNcw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33ed0a8beb5so338685f8f.1 for ; Fri, 15 Mar 2024 03:43:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710499401; x=1711104201; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mFYTL2COBcL0eDhJwzMKJs1wuhd9ev/OLLtfRXuhw8w=; b=ADy5fLbj2xAEIrXJ6Y8HLMe9+J5iT7IwBXKsspe0fb6AoptnQXnKNsNt3F8ZV0qQlG KKlof7Adnb81QpMOF6lgceJ2gMvufeyuPGBWavdQ6EMnFY2BCaqRGdDeBPuC9VZBqI5k nucht9df1z5XYConvSM8OhC6Kie28it54AerntGE0WRx9lgMucaE7RzLfAXHajXz1utO dB7zal590oSylOByw/4qT/NkI4eegC/q3hrexC0PB2BxYdJsdw7l3L7TzKQtLhEHyhH/ s5sA+K340TC43jMg8uBMywFILc1HwHjmIzhtIuxYwlNM9YFGA+4U8rNnn55sch/JQCzd N/0A== X-Gm-Message-State: AOJu0YwEL8Y2YRU4MuqVy6bQXp/ovFAJNXVtHX7fooKOmgBDyc+3wCFJ QIRdy0NMDbXojVE5K5CxhZbtQ8NgbNhP2nApcUo1uDCFymzQm2t6gfDO2yrFc9HbxE2SL4nqK1M U32QCfsomLExmUkaLTFS1iQrgX2fmPTimd8B8CiCYEsUaX4z+ X-Received: by 2002:adf:f448:0:b0:33e:d65c:b493 with SMTP id f8-20020adff448000000b0033ed65cb493mr129604wrp.62.1710499401034; Fri, 15 Mar 2024 03:43:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEL7oU7U/Z0lGKC7FlgrWPD3b6tu18IRtNermovqCqf62+MZsfaLnoVa9N8jnhrUhetWqC1cA== X-Received: by 2002:adf:f448:0:b0:33e:d65c:b493 with SMTP id f8-20020adff448000000b0033ed65cb493mr129580wrp.62.1710499400614; Fri, 15 Mar 2024 03:43:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:7700:ef08:112b:278d:7d90? (p200300cbc7197700ef08112b278d7d90.dip0.t-ipconnect.de. [2003:cb:c719:7700:ef08:112b:278d:7d90]) by smtp.gmail.com with ESMTPSA id bt17-20020a056000081100b0033ec8c1c233sm2967767wrb.19.2024.03.15.03.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 03:43:20 -0700 (PDT) Message-ID: Date: Fri, 15 Mar 2024 11:43:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] mm: vmscan: Avoid split during shrink_folio_list() To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311150058.1122862-1-ryan.roberts@arm.com> <20240311150058.1122862-6-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240311150058.1122862-6-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7DC701C0002 X-Rspam-User: X-Stat-Signature: 38cppkbnmbg79jcydf5kh8mwus75msjb X-Rspamd-Server: rspam01 X-HE-Tag: 1710499406-609907 X-HE-Meta: U2FsdGVkX1/Vx1B3KWZVYpHJuGPep3WuvGlEpmceJ+QTJJF7KHxtH14h+2PVDpA5PNhobykGLq+FUxugkvztORTC0N8AE7PDkh5Pa5o2B6i+OurQi8IdtLXKfXlnpIhNpa2UPDjeXEkGO6qfvo6duFBNOMAUpv24ZU4nnMY7KWbkWR7REK4gSHK39VL7bUh5lvEwmVbp/wpcdW0vDmWmPgkn4wQQW8x5aW/bZawy4TkZbNA+waw6zVILRlg/JszVni2Zs8gOFtN3pDwF7WU7sgx7J8Sgi0FdYXftLe+ggypFkDybF0dwinSnrAsNzheKD997tIXwagqoU2Uve3/ig7rdDmdZgIjGiMAkwm1ES1KxwjG0DSJaiZ6hdL2Ba8k6EzplbpkWrMdCjIqrcJY/3whwuCZY6N5JS+mNDKN/FAo5ZBMtMmHBv5rvepDXmIQ7qpKsomUVSV8txqkDd1oSqxOx3Ojd7kC8AJKezovJPKMBq+SakDtE7t0XBdoc4IriPOw0TgUBgPLEZvvN+I5wnxWjeh9CKMSV6nOgWT+nnum/kSari4APgZYXwKYM/pUYSVWavOKfLqDwNa++8ibCrk50kiQOaNYi/3P7HaSVrkAZS1m7+hJOXSNzLWOD74l882lqhTiTswMLRMYfDnZ1pYhGq14aJsVGJQjyVlS3tQawWm8fa8w0zcMDvv2ydUp9r4uwjex7ZupfC5h2gGIVMSQW7vbH2h0n9RQlQ8P2+krohahMFJEllZn9hlTnMGt6DYpfPSL90SjE2qo3GRvYjilZvfWjI0r4bCrIF1cJRjPWGJjrXOW6a8kZ0HryCprnvZBZTfKyT0/p9Y1WaFa+dMhRRhoqOLFF+XGbGyKvQc9P08Z2qBTB/jnW5gU4YYiq3GGP84zm+5kpqswJXa9AhKxRPD/71GvanN+lV6xjYBiSlkydujpKpgpQ6YzuWbigHo6bcrZN+grv8T46+lZ akSquma0 rsP4luxZ6co+nPn2p27B3f1q3PUweNPzE4bHf7kdsUKauqA0BHw3qb7OpxXX5/iFykEqU8jZqaHKzHG95bk+vSZ1WogOSYkVSheqBZ2oEwft9KO1Xf6Gwje+lZIyCyTkPuG+CBN7i9GFShiocBeznavBFoEcpeGnMKX0SQ1+/vJrqeei3MA3dLHg/bmuBKDWYVZsRYHj7VbLJ9na/Ejjps/HdQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.03.24 16:00, Ryan Roberts wrote: > Now that swap supports storing all mTHP sizes, avoid splitting large > folios before swap-out. This benefits performance of the swap-out path > by eliding split_folio_to_list(), which is expensive, and also sets us > up for swapping in large folios in a future series. > > If the folio is partially mapped, we continue to split it since we want > to avoid the extra IO overhead and storage of writing out pages > uneccessarily. > > Signed-off-by: Ryan Roberts > --- > mm/vmscan.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index cf7d4cf47f1a..0ebec99e04c6 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1222,11 +1222,12 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > if (!can_split_folio(folio, NULL)) > goto activate_locked; > /* > - * Split folios without a PMD map right > - * away. Chances are some or all of the > - * tail pages can be freed without IO. > + * Split partially mapped folios map > + * right away. Chances are some or all > + * of the tail pages can be freed > + * without IO. > */ > - if (!folio_entire_mapcount(folio) && > + if (!list_empty(&folio->_deferred_list) && > split_folio_to_list(folio, > folio_list)) > goto activate_locked; Not sure if we might have to annotate that with data_race(). Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb